diff options
author | Jia He <hejianet@gmail.com> | 2016-09-29 23:29:02 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2016-09-30 01:50:45 -0400 |
commit | 07613873f1731aa47fdf06a1cbd2e3cd1974c026 (patch) | |
tree | a6b3008f9c31c048ab595ef39db5929ffb294d9c /net/xfrm | |
parent | 7d64a94be2f9fadb1dd95742650f1fdbac69f25b (diff) |
proc: Reduce cache miss in xfrm_statistics_seq_show
This is to use the generic interfaces snmp_get_cpu_field{,64}_batch to
aggregate the data by going through all the items of each cpu sequentially.
Signed-off-by: Jia He <hejianet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/xfrm')
-rw-r--r-- | net/xfrm/xfrm_proc.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/net/xfrm/xfrm_proc.c b/net/xfrm/xfrm_proc.c index 9c4fbd8935f4..ba2b539879bc 100644 --- a/net/xfrm/xfrm_proc.c +++ b/net/xfrm/xfrm_proc.c | |||
@@ -50,12 +50,18 @@ static const struct snmp_mib xfrm_mib_list[] = { | |||
50 | 50 | ||
51 | static int xfrm_statistics_seq_show(struct seq_file *seq, void *v) | 51 | static int xfrm_statistics_seq_show(struct seq_file *seq, void *v) |
52 | { | 52 | { |
53 | unsigned long buff[LINUX_MIB_XFRMMAX]; | ||
53 | struct net *net = seq->private; | 54 | struct net *net = seq->private; |
54 | int i; | 55 | int i; |
56 | |||
57 | memset(buff, 0, sizeof(unsigned long) * LINUX_MIB_XFRMMAX); | ||
58 | |||
59 | snmp_get_cpu_field_batch(buff, xfrm_mib_list, | ||
60 | net->mib.xfrm_statistics); | ||
55 | for (i = 0; xfrm_mib_list[i].name; i++) | 61 | for (i = 0; xfrm_mib_list[i].name; i++) |
56 | seq_printf(seq, "%-24s\t%lu\n", xfrm_mib_list[i].name, | 62 | seq_printf(seq, "%-24s\t%lu\n", xfrm_mib_list[i].name, |
57 | snmp_fold_field(net->mib.xfrm_statistics, | 63 | buff[i]); |
58 | xfrm_mib_list[i].entry)); | 64 | |
59 | return 0; | 65 | return 0; |
60 | } | 66 | } |
61 | 67 | ||