cfg80211: Validate cipher suite against supported ciphers

Instead of using a hardcoded list of cipher suites in nl80211.c, use a
shared function in util.c to verify that the driver advertises support
for the specified cipher. This provides more accurate validation of the
values and allows vendor-specific cipher suites to be added in drivers.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

1 files changed, 4 insertions, 12 deletions

diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 1722998f4984..a3e26951fd8b 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -4126,16 +4126,6 @@ static bool nl80211_valid_wpa_versions(u32 wpa_versions)
                                   NL80211_WPA_VERSION_2));
 }
 
-static bool nl80211_valid_cipher_suite(u32 cipher)
-{
-        return cipher == WLAN_CIPHER_SUITE_WEP40 ||
-                cipher == WLAN_CIPHER_SUITE_WEP104 ||
-                cipher == WLAN_CIPHER_SUITE_TKIP ||
-                cipher == WLAN_CIPHER_SUITE_CCMP ||
-                cipher == WLAN_CIPHER_SUITE_AES_CMAC;
-}
-
-
 static int nl80211_authenticate(struct sk_buff *skb, struct genl_info *info)
 {
         struct cfg80211_registered_device *rdev = info->user_ptr[0];
@@ -4268,7 +4258,8 @@ static int nl80211_crypto_settings(struct cfg80211_registered_device *rdev,
                 memcpy(settings->ciphers_pairwise, data, len);
 
                 for (i = 0; i < settings->n_ciphers_pairwise; i++)
-                        if (!nl80211_valid_cipher_suite(
+                        if (!cfg80211_supported_cipher_suite(
+                                        &rdev->wiphy,
                                         settings->ciphers_pairwise[i]))
                                 return -EINVAL;
         }
@@ -4276,7 +4267,8 @@ static int nl80211_crypto_settings(struct cfg80211_registered_device *rdev,
         if (info->attrs[NL80211_ATTR_CIPHER_SUITE_GROUP]) {
                 settings->cipher_group =
                         nla_get_u32(info->attrs[NL80211_ATTR_CIPHER_SUITE_GROUP]);
-                if (!nl80211_valid_cipher_suite(settings->cipher_group))
+                if (!cfg80211_supported_cipher_suite(&rdev->wiphy,
+                                                     settings->cipher_group))
                         return -EINVAL;
         }