diff options
| author | Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> | 2013-11-14 17:31:57 -0500 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-11-14 19:32:20 -0500 |
| commit | 652586df95e5d76b37d07a11839126dcfede1621 (patch) | |
| tree | e3a668265cade256302830ea3ff8b3699ab2977e /net/phonet | |
| parent | 839cc2a94cc3665bafe32203c2f095f4dd470a80 (diff) | |
seq_file: remove "%n" usage from seq_file users
All seq_printf() users are using "%n" for calculating padding size,
convert them to use seq_setwidth() / seq_pad() pair.
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: Joe Perches <joe@perches.com>
Cc: David Miller <davem@davemloft.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'net/phonet')
| -rw-r--r-- | net/phonet/socket.c | 24 |
1 files changed, 11 insertions, 13 deletions
diff --git a/net/phonet/socket.c b/net/phonet/socket.c index 77e38f733496..008214a3d5eb 100644 --- a/net/phonet/socket.c +++ b/net/phonet/socket.c | |||
| @@ -595,26 +595,25 @@ static void pn_sock_seq_stop(struct seq_file *seq, void *v) | |||
| 595 | 595 | ||
| 596 | static int pn_sock_seq_show(struct seq_file *seq, void *v) | 596 | static int pn_sock_seq_show(struct seq_file *seq, void *v) |
| 597 | { | 597 | { |
| 598 | int len; | 598 | seq_setwidth(seq, 127); |
| 599 | |||
| 600 | if (v == SEQ_START_TOKEN) | 599 | if (v == SEQ_START_TOKEN) |
| 601 | seq_printf(seq, "%s%n", "pt loc rem rs st tx_queue rx_queue " | 600 | seq_puts(seq, "pt loc rem rs st tx_queue rx_queue " |
| 602 | " uid inode ref pointer drops", &len); | 601 | " uid inode ref pointer drops"); |
| 603 | else { | 602 | else { |
| 604 | struct sock *sk = v; | 603 | struct sock *sk = v; |
| 605 | struct pn_sock *pn = pn_sk(sk); | 604 | struct pn_sock *pn = pn_sk(sk); |
| 606 | 605 | ||
| 607 | seq_printf(seq, "%2d %04X:%04X:%02X %02X %08X:%08X %5d %lu " | 606 | seq_printf(seq, "%2d %04X:%04X:%02X %02X %08X:%08X %5d %lu " |
| 608 | "%d %pK %d%n", | 607 | "%d %pK %d", |
| 609 | sk->sk_protocol, pn->sobject, pn->dobject, | 608 | sk->sk_protocol, pn->sobject, pn->dobject, |
| 610 | pn->resource, sk->sk_state, | 609 | pn->resource, sk->sk_state, |
| 611 | sk_wmem_alloc_get(sk), sk_rmem_alloc_get(sk), | 610 | sk_wmem_alloc_get(sk), sk_rmem_alloc_get(sk), |
| 612 | from_kuid_munged(seq_user_ns(seq), sock_i_uid(sk)), | 611 | from_kuid_munged(seq_user_ns(seq), sock_i_uid(sk)), |
| 613 | sock_i_ino(sk), | 612 | sock_i_ino(sk), |
| 614 | atomic_read(&sk->sk_refcnt), sk, | 613 | atomic_read(&sk->sk_refcnt), sk, |
| 615 | atomic_read(&sk->sk_drops), &len); | 614 | atomic_read(&sk->sk_drops)); |
| 616 | } | 615 | } |
| 617 | seq_printf(seq, "%*s\n", 127 - len, ""); | 616 | seq_pad(seq, '\n'); |
| 618 | return 0; | 617 | return 0; |
| 619 | } | 618 | } |
| 620 | 619 | ||
| @@ -785,20 +784,19 @@ static void pn_res_seq_stop(struct seq_file *seq, void *v) | |||
| 785 | 784 | ||
| 786 | static int pn_res_seq_show(struct seq_file *seq, void *v) | 785 | static int pn_res_seq_show(struct seq_file *seq, void *v) |
| 787 | { | 786 | { |
| 788 | int len; | 787 | seq_setwidth(seq, 63); |
| 789 | |||
| 790 | if (v == SEQ_START_TOKEN) | 788 | if (v == SEQ_START_TOKEN) |
| 791 | seq_printf(seq, "%s%n", "rs uid inode", &len); | 789 | seq_puts(seq, "rs uid inode"); |
| 792 | else { | 790 | else { |
| 793 | struct sock **psk = v; | 791 | struct sock **psk = v; |
| 794 | struct sock *sk = *psk; | 792 | struct sock *sk = *psk; |
| 795 | 793 | ||
| 796 | seq_printf(seq, "%02X %5u %lu%n", | 794 | seq_printf(seq, "%02X %5u %lu", |
| 797 | (int) (psk - pnres.sk), | 795 | (int) (psk - pnres.sk), |
| 798 | from_kuid_munged(seq_user_ns(seq), sock_i_uid(sk)), | 796 | from_kuid_munged(seq_user_ns(seq), sock_i_uid(sk)), |
| 799 | sock_i_ino(sk), &len); | 797 | sock_i_ino(sk)); |
| 800 | } | 798 | } |
| 801 | seq_printf(seq, "%*s\n", 63 - len, ""); | 799 | seq_pad(seq, '\n'); |
| 802 | return 0; | 800 | return 0; |
| 803 | } | 801 | } |
| 804 | 802 | ||
