diff options
author | Markus Elfring <elfring@users.sourceforge.net> | 2014-11-18 15:03:13 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-11-19 15:27:40 -0500 |
commit | fcd4d35ecc1636c8ac50e3a6266a620eb8ff0626 (patch) | |
tree | e0567c4658db21364382ea3e1990a4ec5f223fb8 /net/netlink | |
parent | ef87c5d6a11af45c31910728e46642e77aa8db61 (diff) |
netlink: Deletion of an unnecessary check before the function call "__module_get"
The __module_get() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/netlink')
-rw-r--r-- | net/netlink/af_netlink.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index d479b32d5826..e1aad6eeac14 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c | |||
@@ -142,8 +142,7 @@ int netlink_add_tap(struct netlink_tap *nt) | |||
142 | list_add_rcu(&nt->list, &netlink_tap_all); | 142 | list_add_rcu(&nt->list, &netlink_tap_all); |
143 | spin_unlock(&netlink_tap_lock); | 143 | spin_unlock(&netlink_tap_lock); |
144 | 144 | ||
145 | if (nt->module) | 145 | __module_get(nt->module); |
146 | __module_get(nt->module); | ||
147 | 146 | ||
148 | return 0; | 147 | return 0; |
149 | } | 148 | } |