diff options
author | Stephen Hemminger <shemminger@vyatta.com> | 2010-05-13 09:02:08 -0400 |
---|---|---|
committer | Patrick McHardy <kaber@trash.net> | 2010-05-13 09:02:08 -0400 |
commit | 654d0fbdc8fe1041918741ed5b6abc8ad6b4c1d8 (patch) | |
tree | 6888917854682b983b17aecd82b5d8d7039175a9 /net/netfilter | |
parent | af5676039a9479e6ff42c6aab9fac1149ac9597f (diff) |
netfilter: cleanup printk messages
Make sure all printk messages have a severity level.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Diffstat (limited to 'net/netfilter')
-rw-r--r-- | net/netfilter/nf_conntrack_amanda.c | 2 | ||||
-rw-r--r-- | net/netfilter/nf_conntrack_core.c | 2 | ||||
-rw-r--r-- | net/netfilter/nf_conntrack_ftp.c | 4 | ||||
-rw-r--r-- | net/netfilter/nf_conntrack_h323_main.c | 6 | ||||
-rw-r--r-- | net/netfilter/nf_conntrack_irc.c | 4 | ||||
-rw-r--r-- | net/netfilter/nf_conntrack_netlink.c | 12 | ||||
-rw-r--r-- | net/netfilter/nf_conntrack_proto_sctp.c | 4 | ||||
-rw-r--r-- | net/netfilter/nf_conntrack_sip.c | 4 | ||||
-rw-r--r-- | net/netfilter/nf_conntrack_standalone.c | 2 | ||||
-rw-r--r-- | net/netfilter/nf_conntrack_tftp.c | 4 | ||||
-rw-r--r-- | net/netfilter/nf_internals.h | 2 | ||||
-rw-r--r-- | net/netfilter/nfnetlink.c | 4 | ||||
-rw-r--r-- | net/netfilter/nfnetlink_log.c | 4 |
13 files changed, 27 insertions, 27 deletions
diff --git a/net/netfilter/nf_conntrack_amanda.c b/net/netfilter/nf_conntrack_amanda.c index 372e80f07a81..13fd2c55e329 100644 --- a/net/netfilter/nf_conntrack_amanda.c +++ b/net/netfilter/nf_conntrack_amanda.c | |||
@@ -108,7 +108,7 @@ static int amanda_help(struct sk_buff *skb, | |||
108 | dataoff = protoff + sizeof(struct udphdr); | 108 | dataoff = protoff + sizeof(struct udphdr); |
109 | if (dataoff >= skb->len) { | 109 | if (dataoff >= skb->len) { |
110 | if (net_ratelimit()) | 110 | if (net_ratelimit()) |
111 | printk("amanda_help: skblen = %u\n", skb->len); | 111 | printk(KERN_ERR "amanda_help: skblen = %u\n", skb->len); |
112 | return NF_ACCEPT; | 112 | return NF_ACCEPT; |
113 | } | 113 | } |
114 | 114 | ||
diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c index 3907efb97a7c..b83c530c5e0a 100644 --- a/net/netfilter/nf_conntrack_core.c +++ b/net/netfilter/nf_conntrack_core.c | |||
@@ -1335,7 +1335,7 @@ static int nf_conntrack_init_init_net(void) | |||
1335 | } | 1335 | } |
1336 | nf_conntrack_max = max_factor * nf_conntrack_htable_size; | 1336 | nf_conntrack_max = max_factor * nf_conntrack_htable_size; |
1337 | 1337 | ||
1338 | printk("nf_conntrack version %s (%u buckets, %d max)\n", | 1338 | printk(KERN_INFO "nf_conntrack version %s (%u buckets, %d max)\n", |
1339 | NF_CONNTRACK_VERSION, nf_conntrack_htable_size, | 1339 | NF_CONNTRACK_VERSION, nf_conntrack_htable_size, |
1340 | nf_conntrack_max); | 1340 | nf_conntrack_max); |
1341 | 1341 | ||
diff --git a/net/netfilter/nf_conntrack_ftp.c b/net/netfilter/nf_conntrack_ftp.c index 2ae3169e7633..e17cb7c7dd8f 100644 --- a/net/netfilter/nf_conntrack_ftp.c +++ b/net/netfilter/nf_conntrack_ftp.c | |||
@@ -573,8 +573,8 @@ static int __init nf_conntrack_ftp_init(void) | |||
573 | ftp[i][j].tuple.src.l3num, ports[i]); | 573 | ftp[i][j].tuple.src.l3num, ports[i]); |
574 | ret = nf_conntrack_helper_register(&ftp[i][j]); | 574 | ret = nf_conntrack_helper_register(&ftp[i][j]); |
575 | if (ret) { | 575 | if (ret) { |
576 | printk("nf_ct_ftp: failed to register helper " | 576 | printk(KERN_ERR "nf_ct_ftp: failed to register" |
577 | " for pf: %d port: %d\n", | 577 | " helper for pf: %d port: %d\n", |
578 | ftp[i][j].tuple.src.l3num, ports[i]); | 578 | ftp[i][j].tuple.src.l3num, ports[i]); |
579 | nf_conntrack_ftp_fini(); | 579 | nf_conntrack_ftp_fini(); |
580 | return ret; | 580 | return ret; |
diff --git a/net/netfilter/nf_conntrack_h323_main.c b/net/netfilter/nf_conntrack_h323_main.c index 48bf15073a85..6eaee7c8a337 100644 --- a/net/netfilter/nf_conntrack_h323_main.c +++ b/net/netfilter/nf_conntrack_h323_main.c | |||
@@ -607,7 +607,7 @@ static int h245_help(struct sk_buff *skb, unsigned int protoff, | |||
607 | drop: | 607 | drop: |
608 | spin_unlock_bh(&nf_h323_lock); | 608 | spin_unlock_bh(&nf_h323_lock); |
609 | if (net_ratelimit()) | 609 | if (net_ratelimit()) |
610 | printk("nf_ct_h245: packet dropped\n"); | 610 | pr_info("nf_ct_h245: packet dropped\n"); |
611 | return NF_DROP; | 611 | return NF_DROP; |
612 | } | 612 | } |
613 | 613 | ||
@@ -1152,7 +1152,7 @@ static int q931_help(struct sk_buff *skb, unsigned int protoff, | |||
1152 | drop: | 1152 | drop: |
1153 | spin_unlock_bh(&nf_h323_lock); | 1153 | spin_unlock_bh(&nf_h323_lock); |
1154 | if (net_ratelimit()) | 1154 | if (net_ratelimit()) |
1155 | printk("nf_ct_q931: packet dropped\n"); | 1155 | pr_info("nf_ct_q931: packet dropped\n"); |
1156 | return NF_DROP; | 1156 | return NF_DROP; |
1157 | } | 1157 | } |
1158 | 1158 | ||
@@ -1727,7 +1727,7 @@ static int ras_help(struct sk_buff *skb, unsigned int protoff, | |||
1727 | drop: | 1727 | drop: |
1728 | spin_unlock_bh(&nf_h323_lock); | 1728 | spin_unlock_bh(&nf_h323_lock); |
1729 | if (net_ratelimit()) | 1729 | if (net_ratelimit()) |
1730 | printk("nf_ct_ras: packet dropped\n"); | 1730 | pr_info("nf_ct_ras: packet dropped\n"); |
1731 | return NF_DROP; | 1731 | return NF_DROP; |
1732 | } | 1732 | } |
1733 | 1733 | ||
diff --git a/net/netfilter/nf_conntrack_irc.c b/net/netfilter/nf_conntrack_irc.c index 7673930ca342..b394aa318776 100644 --- a/net/netfilter/nf_conntrack_irc.c +++ b/net/netfilter/nf_conntrack_irc.c | |||
@@ -235,7 +235,7 @@ static int __init nf_conntrack_irc_init(void) | |||
235 | char *tmpname; | 235 | char *tmpname; |
236 | 236 | ||
237 | if (max_dcc_channels < 1) { | 237 | if (max_dcc_channels < 1) { |
238 | printk("nf_ct_irc: max_dcc_channels must not be zero\n"); | 238 | printk(KERN_ERR "nf_ct_irc: max_dcc_channels must not be zero\n"); |
239 | return -EINVAL; | 239 | return -EINVAL; |
240 | } | 240 | } |
241 | 241 | ||
@@ -267,7 +267,7 @@ static int __init nf_conntrack_irc_init(void) | |||
267 | 267 | ||
268 | ret = nf_conntrack_helper_register(&irc[i]); | 268 | ret = nf_conntrack_helper_register(&irc[i]); |
269 | if (ret) { | 269 | if (ret) { |
270 | printk("nf_ct_irc: failed to register helper " | 270 | printk(KERN_ERR "nf_ct_irc: failed to register helper " |
271 | "for pf: %u port: %u\n", | 271 | "for pf: %u port: %u\n", |
272 | irc[i].tuple.src.l3num, ports[i]); | 272 | irc[i].tuple.src.l3num, ports[i]); |
273 | nf_conntrack_irc_fini(); | 273 | nf_conntrack_irc_fini(); |
diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c index 4e55403bf263..961fb6a85294 100644 --- a/net/netfilter/nf_conntrack_netlink.c +++ b/net/netfilter/nf_conntrack_netlink.c | |||
@@ -2057,29 +2057,29 @@ static int __init ctnetlink_init(void) | |||
2057 | { | 2057 | { |
2058 | int ret; | 2058 | int ret; |
2059 | 2059 | ||
2060 | printk("ctnetlink v%s: registering with nfnetlink.\n", version); | 2060 | pr_info("ctnetlink v%s: registering with nfnetlink.\n", version); |
2061 | ret = nfnetlink_subsys_register(&ctnl_subsys); | 2061 | ret = nfnetlink_subsys_register(&ctnl_subsys); |
2062 | if (ret < 0) { | 2062 | if (ret < 0) { |
2063 | printk("ctnetlink_init: cannot register with nfnetlink.\n"); | 2063 | pr_err("ctnetlink_init: cannot register with nfnetlink.\n"); |
2064 | goto err_out; | 2064 | goto err_out; |
2065 | } | 2065 | } |
2066 | 2066 | ||
2067 | ret = nfnetlink_subsys_register(&ctnl_exp_subsys); | 2067 | ret = nfnetlink_subsys_register(&ctnl_exp_subsys); |
2068 | if (ret < 0) { | 2068 | if (ret < 0) { |
2069 | printk("ctnetlink_init: cannot register exp with nfnetlink.\n"); | 2069 | pr_err("ctnetlink_init: cannot register exp with nfnetlink.\n"); |
2070 | goto err_unreg_subsys; | 2070 | goto err_unreg_subsys; |
2071 | } | 2071 | } |
2072 | 2072 | ||
2073 | #ifdef CONFIG_NF_CONNTRACK_EVENTS | 2073 | #ifdef CONFIG_NF_CONNTRACK_EVENTS |
2074 | ret = nf_conntrack_register_notifier(&ctnl_notifier); | 2074 | ret = nf_conntrack_register_notifier(&ctnl_notifier); |
2075 | if (ret < 0) { | 2075 | if (ret < 0) { |
2076 | printk("ctnetlink_init: cannot register notifier.\n"); | 2076 | pr_err("ctnetlink_init: cannot register notifier.\n"); |
2077 | goto err_unreg_exp_subsys; | 2077 | goto err_unreg_exp_subsys; |
2078 | } | 2078 | } |
2079 | 2079 | ||
2080 | ret = nf_ct_expect_register_notifier(&ctnl_notifier_exp); | 2080 | ret = nf_ct_expect_register_notifier(&ctnl_notifier_exp); |
2081 | if (ret < 0) { | 2081 | if (ret < 0) { |
2082 | printk("ctnetlink_init: cannot expect register notifier.\n"); | 2082 | pr_err("ctnetlink_init: cannot expect register notifier.\n"); |
2083 | goto err_unreg_notifier; | 2083 | goto err_unreg_notifier; |
2084 | } | 2084 | } |
2085 | #endif | 2085 | #endif |
@@ -2100,7 +2100,7 @@ err_out: | |||
2100 | 2100 | ||
2101 | static void __exit ctnetlink_exit(void) | 2101 | static void __exit ctnetlink_exit(void) |
2102 | { | 2102 | { |
2103 | printk("ctnetlink: unregistering from nfnetlink.\n"); | 2103 | pr_info("ctnetlink: unregistering from nfnetlink.\n"); |
2104 | 2104 | ||
2105 | #ifdef CONFIG_NF_CONNTRACK_EVENTS | 2105 | #ifdef CONFIG_NF_CONNTRACK_EVENTS |
2106 | nf_ct_expect_unregister_notifier(&ctnl_notifier_exp); | 2106 | nf_ct_expect_unregister_notifier(&ctnl_notifier_exp); |
diff --git a/net/netfilter/nf_conntrack_proto_sctp.c b/net/netfilter/nf_conntrack_proto_sctp.c index b68ff15ed979..c6049c2d5ea8 100644 --- a/net/netfilter/nf_conntrack_proto_sctp.c +++ b/net/netfilter/nf_conntrack_proto_sctp.c | |||
@@ -717,12 +717,12 @@ static int __init nf_conntrack_proto_sctp_init(void) | |||
717 | 717 | ||
718 | ret = nf_conntrack_l4proto_register(&nf_conntrack_l4proto_sctp4); | 718 | ret = nf_conntrack_l4proto_register(&nf_conntrack_l4proto_sctp4); |
719 | if (ret) { | 719 | if (ret) { |
720 | printk("nf_conntrack_l4proto_sctp4: protocol register failed\n"); | 720 | pr_err("nf_conntrack_l4proto_sctp4: protocol register failed\n"); |
721 | goto out; | 721 | goto out; |
722 | } | 722 | } |
723 | ret = nf_conntrack_l4proto_register(&nf_conntrack_l4proto_sctp6); | 723 | ret = nf_conntrack_l4proto_register(&nf_conntrack_l4proto_sctp6); |
724 | if (ret) { | 724 | if (ret) { |
725 | printk("nf_conntrack_l4proto_sctp6: protocol register failed\n"); | 725 | pr_err("nf_conntrack_l4proto_sctp6: protocol register failed\n"); |
726 | goto cleanup_sctp4; | 726 | goto cleanup_sctp4; |
727 | } | 727 | } |
728 | 728 | ||
diff --git a/net/netfilter/nf_conntrack_sip.c b/net/netfilter/nf_conntrack_sip.c index c6cd1b84eddd..b20f4275893c 100644 --- a/net/netfilter/nf_conntrack_sip.c +++ b/net/netfilter/nf_conntrack_sip.c | |||
@@ -1549,8 +1549,8 @@ static int __init nf_conntrack_sip_init(void) | |||
1549 | 1549 | ||
1550 | ret = nf_conntrack_helper_register(&sip[i][j]); | 1550 | ret = nf_conntrack_helper_register(&sip[i][j]); |
1551 | if (ret) { | 1551 | if (ret) { |
1552 | printk("nf_ct_sip: failed to register helper " | 1552 | printk(KERN_ERR "nf_ct_sip: failed to register" |
1553 | "for pf: %u port: %u\n", | 1553 | " helper for pf: %u port: %u\n", |
1554 | sip[i][j].tuple.src.l3num, ports[i]); | 1554 | sip[i][j].tuple.src.l3num, ports[i]); |
1555 | nf_conntrack_sip_fini(); | 1555 | nf_conntrack_sip_fini(); |
1556 | return ret; | 1556 | return ret; |
diff --git a/net/netfilter/nf_conntrack_standalone.c b/net/netfilter/nf_conntrack_standalone.c index ea4a8d384234..eb973fcd67ab 100644 --- a/net/netfilter/nf_conntrack_standalone.c +++ b/net/netfilter/nf_conntrack_standalone.c | |||
@@ -446,7 +446,7 @@ out_kmemdup: | |||
446 | if (net_eq(net, &init_net)) | 446 | if (net_eq(net, &init_net)) |
447 | unregister_sysctl_table(nf_ct_netfilter_header); | 447 | unregister_sysctl_table(nf_ct_netfilter_header); |
448 | out: | 448 | out: |
449 | printk("nf_conntrack: can't register to sysctl.\n"); | 449 | printk(KERN_ERR "nf_conntrack: can't register to sysctl.\n"); |
450 | return -ENOMEM; | 450 | return -ENOMEM; |
451 | } | 451 | } |
452 | 452 | ||
diff --git a/net/netfilter/nf_conntrack_tftp.c b/net/netfilter/nf_conntrack_tftp.c index 46e646b2e9b9..75466fd72f4f 100644 --- a/net/netfilter/nf_conntrack_tftp.c +++ b/net/netfilter/nf_conntrack_tftp.c | |||
@@ -138,8 +138,8 @@ static int __init nf_conntrack_tftp_init(void) | |||
138 | 138 | ||
139 | ret = nf_conntrack_helper_register(&tftp[i][j]); | 139 | ret = nf_conntrack_helper_register(&tftp[i][j]); |
140 | if (ret) { | 140 | if (ret) { |
141 | printk("nf_ct_tftp: failed to register helper " | 141 | printk(KERN_ERR "nf_ct_tftp: failed to register" |
142 | "for pf: %u port: %u\n", | 142 | " helper for pf: %u port: %u\n", |
143 | tftp[i][j].tuple.src.l3num, ports[i]); | 143 | tftp[i][j].tuple.src.l3num, ports[i]); |
144 | nf_conntrack_tftp_fini(); | 144 | nf_conntrack_tftp_fini(); |
145 | return ret; | 145 | return ret; |
diff --git a/net/netfilter/nf_internals.h b/net/netfilter/nf_internals.h index bf6609978af7..770f76432ad0 100644 --- a/net/netfilter/nf_internals.h +++ b/net/netfilter/nf_internals.h | |||
@@ -6,7 +6,7 @@ | |||
6 | #include <linux/netdevice.h> | 6 | #include <linux/netdevice.h> |
7 | 7 | ||
8 | #ifdef CONFIG_NETFILTER_DEBUG | 8 | #ifdef CONFIG_NETFILTER_DEBUG |
9 | #define NFDEBUG(format, args...) printk(format , ## args) | 9 | #define NFDEBUG(format, args...) printk(KERN_DEBUG format , ## args) |
10 | #else | 10 | #else |
11 | #define NFDEBUG(format, args...) | 11 | #define NFDEBUG(format, args...) |
12 | #endif | 12 | #endif |
diff --git a/net/netfilter/nfnetlink.c b/net/netfilter/nfnetlink.c index 39b0e3100575..b4a4532823e8 100644 --- a/net/netfilter/nfnetlink.c +++ b/net/netfilter/nfnetlink.c | |||
@@ -212,13 +212,13 @@ static struct pernet_operations nfnetlink_net_ops = { | |||
212 | 212 | ||
213 | static int __init nfnetlink_init(void) | 213 | static int __init nfnetlink_init(void) |
214 | { | 214 | { |
215 | printk("Netfilter messages via NETLINK v%s.\n", nfversion); | 215 | pr_info("Netfilter messages via NETLINK v%s.\n", nfversion); |
216 | return register_pernet_subsys(&nfnetlink_net_ops); | 216 | return register_pernet_subsys(&nfnetlink_net_ops); |
217 | } | 217 | } |
218 | 218 | ||
219 | static void __exit nfnetlink_exit(void) | 219 | static void __exit nfnetlink_exit(void) |
220 | { | 220 | { |
221 | printk("Removing netfilter NETLINK layer.\n"); | 221 | pr_info("Removing netfilter NETLINK layer.\n"); |
222 | unregister_pernet_subsys(&nfnetlink_net_ops); | 222 | unregister_pernet_subsys(&nfnetlink_net_ops); |
223 | } | 223 | } |
224 | module_init(nfnetlink_init); | 224 | module_init(nfnetlink_init); |
diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c index 203643fb2c52..fc9a211e629e 100644 --- a/net/netfilter/nfnetlink_log.c +++ b/net/netfilter/nfnetlink_log.c | |||
@@ -297,7 +297,7 @@ nfulnl_alloc_skb(unsigned int inst_size, unsigned int pkt_size) | |||
297 | n = max(inst_size, pkt_size); | 297 | n = max(inst_size, pkt_size); |
298 | skb = alloc_skb(n, GFP_ATOMIC); | 298 | skb = alloc_skb(n, GFP_ATOMIC); |
299 | if (!skb) { | 299 | if (!skb) { |
300 | PRINTR("nfnetlink_log: can't alloc whole buffer (%u bytes)\n", | 300 | pr_notice("nfnetlink_log: can't alloc whole buffer (%u bytes)\n", |
301 | inst_size); | 301 | inst_size); |
302 | 302 | ||
303 | if (n > pkt_size) { | 303 | if (n > pkt_size) { |
@@ -306,7 +306,7 @@ nfulnl_alloc_skb(unsigned int inst_size, unsigned int pkt_size) | |||
306 | 306 | ||
307 | skb = alloc_skb(pkt_size, GFP_ATOMIC); | 307 | skb = alloc_skb(pkt_size, GFP_ATOMIC); |
308 | if (!skb) | 308 | if (!skb) |
309 | PRINTR("nfnetlink_log: can't even alloc %u " | 309 | pr_err("nfnetlink_log: can't even alloc %u " |
310 | "bytes\n", pkt_size); | 310 | "bytes\n", pkt_size); |
311 | } | 311 | } |
312 | } | 312 | } |