diff options
author | John Crispin <john@phrozen.org> | 2016-09-19 09:28:01 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2016-09-20 04:47:44 -0400 |
commit | 092183df0fa1f4b49baad3a980c55d55de07dfb7 (patch) | |
tree | 5e3c4a89f506bf3c488204ccf519e772c9944cde /net/dsa | |
parent | 06f8ec9041f02d44bb0b75d47668e2fe00d5e0c3 (diff) |
net-next: dsa: make the set_addr() operation optional
Only 1 of the 3 drivers currently has a set_addr() operation. Make the
set_addr() callback optional to reduce the amount of empty stubs inside
the drivers.
Signed-off-by: John Crispin <john@phrozen.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/dsa')
-rw-r--r-- | net/dsa/dsa.c | 8 | ||||
-rw-r--r-- | net/dsa/dsa2.c | 8 |
2 files changed, 10 insertions, 6 deletions
diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c index 66e31acfcad8..a6902c1e2f28 100644 --- a/net/dsa/dsa.c +++ b/net/dsa/dsa.c | |||
@@ -378,9 +378,11 @@ static int dsa_switch_setup_one(struct dsa_switch *ds, struct device *parent) | |||
378 | if (ret < 0) | 378 | if (ret < 0) |
379 | goto out; | 379 | goto out; |
380 | 380 | ||
381 | ret = ops->set_addr(ds, dst->master_netdev->dev_addr); | 381 | if (ops->set_addr) { |
382 | if (ret < 0) | 382 | ret = ops->set_addr(ds, dst->master_netdev->dev_addr); |
383 | goto out; | 383 | if (ret < 0) |
384 | goto out; | ||
385 | } | ||
384 | 386 | ||
385 | if (!ds->slave_mii_bus && ops->phy_read) { | 387 | if (!ds->slave_mii_bus && ops->phy_read) { |
386 | ds->slave_mii_bus = devm_mdiobus_alloc(parent); | 388 | ds->slave_mii_bus = devm_mdiobus_alloc(parent); |
diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c index cffc19e972a1..f8a7d9aab437 100644 --- a/net/dsa/dsa2.c +++ b/net/dsa/dsa2.c | |||
@@ -304,9 +304,11 @@ static int dsa_ds_apply(struct dsa_switch_tree *dst, struct dsa_switch *ds) | |||
304 | if (err < 0) | 304 | if (err < 0) |
305 | return err; | 305 | return err; |
306 | 306 | ||
307 | err = ds->ops->set_addr(ds, dst->master_netdev->dev_addr); | 307 | if (ds->ops->set_addr) { |
308 | if (err < 0) | 308 | err = ds->ops->set_addr(ds, dst->master_netdev->dev_addr); |
309 | return err; | 309 | if (err < 0) |
310 | return err; | ||
311 | } | ||
310 | 312 | ||
311 | if (!ds->slave_mii_bus && ds->ops->phy_read) { | 313 | if (!ds->slave_mii_bus && ds->ops->phy_read) { |
312 | ds->slave_mii_bus = devm_mdiobus_alloc(ds->dev); | 314 | ds->slave_mii_bus = devm_mdiobus_alloc(ds->dev); |