diff options
author | Cody P Schafer <cody@linux.vnet.ibm.com> | 2013-07-03 18:02:10 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-07-03 19:07:29 -0400 |
commit | aa47228a18e6d49369df877463095b899aff495f (patch) | |
tree | 60fe5efaba2759046abb107cb25ea694505b1890 /mm | |
parent | 114d4b79f7e561fd76fb98eba79e18df7cdd60f0 (diff) |
memory_hotplug: use pgdat_resize_lock() in online_pages()
mmzone.h documents node_size_lock (which pgdat_resize_lock() locks) as
follows:
* Must be held any time you expect node_start_pfn, node_present_pages
* or node_spanned_pages stay constant. [...]
So actually hold it when we update node_present_pages in online_pages().
Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
Cc: David Rientjes <rientjes@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm')
-rw-r--r-- | mm/memory_hotplug.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 1ad92b46753e..527c51084bb8 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c | |||
@@ -918,6 +918,7 @@ static void node_states_set_node(int node, struct memory_notify *arg) | |||
918 | 918 | ||
919 | int __ref online_pages(unsigned long pfn, unsigned long nr_pages, int online_type) | 919 | int __ref online_pages(unsigned long pfn, unsigned long nr_pages, int online_type) |
920 | { | 920 | { |
921 | unsigned long flags; | ||
921 | unsigned long onlined_pages = 0; | 922 | unsigned long onlined_pages = 0; |
922 | struct zone *zone; | 923 | struct zone *zone; |
923 | int need_zonelists_rebuild = 0; | 924 | int need_zonelists_rebuild = 0; |
@@ -996,7 +997,11 @@ int __ref online_pages(unsigned long pfn, unsigned long nr_pages, int online_typ | |||
996 | 997 | ||
997 | zone->managed_pages += onlined_pages; | 998 | zone->managed_pages += onlined_pages; |
998 | zone->present_pages += onlined_pages; | 999 | zone->present_pages += onlined_pages; |
1000 | |||
1001 | pgdat_resize_lock(zone->zone_pgdat, &flags); | ||
999 | zone->zone_pgdat->node_present_pages += onlined_pages; | 1002 | zone->zone_pgdat->node_present_pages += onlined_pages; |
1003 | pgdat_resize_unlock(zone->zone_pgdat, &flags); | ||
1004 | |||
1000 | if (onlined_pages) { | 1005 | if (onlined_pages) { |
1001 | node_states_set_node(zone_to_nid(zone), &arg); | 1006 | node_states_set_node(zone_to_nid(zone), &arg); |
1002 | if (need_zonelists_rebuild) | 1007 | if (need_zonelists_rebuild) |