diff options
| author | Fabian Frederick <fabf@skynet.be> | 2014-06-07 07:43:08 -0400 |
|---|---|---|
| committer | Steven Rostedt <rostedt@goodmis.org> | 2014-07-01 07:13:42 -0400 |
| commit | 3448bac32953f051be91cef6d67025869f08dc4d (patch) | |
| tree | f65b912368d1072370cb2bc8545f0cae03111c1a /kernel/trace | |
| parent | ef2fbe16ac176c21e3b3013c169e6fdb71ec56c7 (diff) | |
tracing: Convert pr_warning() to pr_warn() in trace_events.c
Convert pr_warning to standard pr_warn
Define pr_fmt(fmt) fmt to avoid any future default fmt definition
Link: http://lkml.kernel.org/p/1402141388-21144-1-git-send-email-fabf@skynet.be
Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'kernel/trace')
| -rw-r--r-- | kernel/trace/trace_events.c | 56 |
1 files changed, 27 insertions, 29 deletions
diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c index f99e0b3bca8c..e7a814b3906b 100644 --- a/kernel/trace/trace_events.c +++ b/kernel/trace/trace_events.c | |||
| @@ -8,6 +8,8 @@ | |||
| 8 | * | 8 | * |
| 9 | */ | 9 | */ |
| 10 | 10 | ||
| 11 | #define pr_fmt(fmt) fmt | ||
| 12 | |||
| 11 | #include <linux/workqueue.h> | 13 | #include <linux/workqueue.h> |
| 12 | #include <linux/spinlock.h> | 14 | #include <linux/spinlock.h> |
| 13 | #include <linux/kthread.h> | 15 | #include <linux/kthread.h> |
| @@ -1490,7 +1492,7 @@ event_subsystem_dir(struct trace_array *tr, const char *name, | |||
| 1490 | 1492 | ||
| 1491 | dir->entry = debugfs_create_dir(name, parent); | 1493 | dir->entry = debugfs_create_dir(name, parent); |
| 1492 | if (!dir->entry) { | 1494 | if (!dir->entry) { |
| 1493 | pr_warning("Failed to create system directory %s\n", name); | 1495 | pr_warn("Failed to create system directory %s\n", name); |
| 1494 | __put_system(system); | 1496 | __put_system(system); |
| 1495 | goto out_free; | 1497 | goto out_free; |
| 1496 | } | 1498 | } |
| @@ -1506,7 +1508,7 @@ event_subsystem_dir(struct trace_array *tr, const char *name, | |||
| 1506 | if (!entry) { | 1508 | if (!entry) { |
| 1507 | kfree(system->filter); | 1509 | kfree(system->filter); |
| 1508 | system->filter = NULL; | 1510 | system->filter = NULL; |
| 1509 | pr_warning("Could not create debugfs '%s/filter' entry\n", name); | 1511 | pr_warn("Could not create debugfs '%s/filter' entry\n", name); |
| 1510 | } | 1512 | } |
| 1511 | 1513 | ||
| 1512 | trace_create_file("enable", 0644, dir->entry, dir, | 1514 | trace_create_file("enable", 0644, dir->entry, dir, |
| @@ -1521,8 +1523,7 @@ event_subsystem_dir(struct trace_array *tr, const char *name, | |||
| 1521 | out_fail: | 1523 | out_fail: |
| 1522 | /* Only print this message if failed on memory allocation */ | 1524 | /* Only print this message if failed on memory allocation */ |
| 1523 | if (!dir || !system) | 1525 | if (!dir || !system) |
| 1524 | pr_warning("No memory to create event subsystem %s\n", | 1526 | pr_warn("No memory to create event subsystem %s\n", name); |
| 1525 | name); | ||
| 1526 | return NULL; | 1527 | return NULL; |
| 1527 | } | 1528 | } |
| 1528 | 1529 | ||
| @@ -1550,8 +1551,7 @@ event_create_dir(struct dentry *parent, struct ftrace_event_file *file) | |||
| 1550 | name = ftrace_event_name(call); | 1551 | name = ftrace_event_name(call); |
| 1551 | file->dir = debugfs_create_dir(name, d_events); | 1552 | file->dir = debugfs_create_dir(name, d_events); |
| 1552 | if (!file->dir) { | 1553 | if (!file->dir) { |
| 1553 | pr_warning("Could not create debugfs '%s' directory\n", | 1554 | pr_warn("Could not create debugfs '%s' directory\n", name); |
| 1554 | name); | ||
| 1555 | return -1; | 1555 | return -1; |
| 1556 | } | 1556 | } |
| 1557 | 1557 | ||
| @@ -1574,8 +1574,8 @@ event_create_dir(struct dentry *parent, struct ftrace_event_file *file) | |||
| 1574 | if (list_empty(head)) { | 1574 | if (list_empty(head)) { |
| 1575 | ret = call->class->define_fields(call); | 1575 | ret = call->class->define_fields(call); |
| 1576 | if (ret < 0) { | 1576 | if (ret < 0) { |
| 1577 | pr_warning("Could not initialize trace point" | 1577 | pr_warn("Could not initialize trace point events/%s\n", |
| 1578 | " events/%s\n", name); | 1578 | name); |
| 1579 | return -1; | 1579 | return -1; |
| 1580 | } | 1580 | } |
| 1581 | } | 1581 | } |
| @@ -1648,8 +1648,7 @@ static int event_init(struct ftrace_event_call *call) | |||
| 1648 | if (call->class->raw_init) { | 1648 | if (call->class->raw_init) { |
| 1649 | ret = call->class->raw_init(call); | 1649 | ret = call->class->raw_init(call); |
| 1650 | if (ret < 0 && ret != -ENOSYS) | 1650 | if (ret < 0 && ret != -ENOSYS) |
| 1651 | pr_warn("Could not initialize trace events/%s\n", | 1651 | pr_warn("Could not initialize trace events/%s\n", name); |
| 1652 | name); | ||
| 1653 | } | 1652 | } |
| 1654 | 1653 | ||
| 1655 | return ret; | 1654 | return ret; |
| @@ -1894,8 +1893,8 @@ __trace_add_event_dirs(struct trace_array *tr) | |||
| 1894 | list_for_each_entry(call, &ftrace_events, list) { | 1893 | list_for_each_entry(call, &ftrace_events, list) { |
| 1895 | ret = __trace_add_new_event(call, tr); | 1894 | ret = __trace_add_new_event(call, tr); |
| 1896 | if (ret < 0) | 1895 | if (ret < 0) |
| 1897 | pr_warning("Could not create directory for event %s\n", | 1896 | pr_warn("Could not create directory for event %s\n", |
| 1898 | ftrace_event_name(call)); | 1897 | ftrace_event_name(call)); |
| 1899 | } | 1898 | } |
| 1900 | } | 1899 | } |
| 1901 | 1900 | ||
| @@ -2207,8 +2206,8 @@ __trace_early_add_event_dirs(struct trace_array *tr) | |||
| 2207 | list_for_each_entry(file, &tr->events, list) { | 2206 | list_for_each_entry(file, &tr->events, list) { |
| 2208 | ret = event_create_dir(tr->event_dir, file); | 2207 | ret = event_create_dir(tr->event_dir, file); |
| 2209 | if (ret < 0) | 2208 | if (ret < 0) |
| 2210 | pr_warning("Could not create directory for event %s\n", | 2209 | pr_warn("Could not create directory for event %s\n", |
| 2211 | ftrace_event_name(file->event_call)); | 2210 | ftrace_event_name(file->event_call)); |
| 2212 | } | 2211 | } |
| 2213 | } | 2212 | } |
| 2214 | 2213 | ||
| @@ -2231,8 +2230,8 @@ __trace_early_add_events(struct trace_array *tr) | |||
| 2231 | 2230 | ||
| 2232 | ret = __trace_early_add_new_event(call, tr); | 2231 | ret = __trace_early_add_new_event(call, tr); |
| 2233 | if (ret < 0) | 2232 | if (ret < 0) |
| 2234 | pr_warning("Could not create early event %s\n", | 2233 | pr_warn("Could not create early event %s\n", |
| 2235 | ftrace_event_name(call)); | 2234 | ftrace_event_name(call)); |
| 2236 | } | 2235 | } |
| 2237 | } | 2236 | } |
| 2238 | 2237 | ||
| @@ -2279,13 +2278,13 @@ create_event_toplevel_files(struct dentry *parent, struct trace_array *tr) | |||
| 2279 | entry = debugfs_create_file("set_event", 0644, parent, | 2278 | entry = debugfs_create_file("set_event", 0644, parent, |
| 2280 | tr, &ftrace_set_event_fops); | 2279 | tr, &ftrace_set_event_fops); |
| 2281 | if (!entry) { | 2280 | if (!entry) { |
| 2282 | pr_warning("Could not create debugfs 'set_event' entry\n"); | 2281 | pr_warn("Could not create debugfs 'set_event' entry\n"); |
| 2283 | return -ENOMEM; | 2282 | return -ENOMEM; |
| 2284 | } | 2283 | } |
| 2285 | 2284 | ||
| 2286 | d_events = debugfs_create_dir("events", parent); | 2285 | d_events = debugfs_create_dir("events", parent); |
| 2287 | if (!d_events) { | 2286 | if (!d_events) { |
| 2288 | pr_warning("Could not create debugfs 'events' directory\n"); | 2287 | pr_warn("Could not create debugfs 'events' directory\n"); |
| 2289 | return -ENOMEM; | 2288 | return -ENOMEM; |
| 2290 | } | 2289 | } |
| 2291 | 2290 | ||
| @@ -2461,11 +2460,10 @@ static __init int event_trace_init(void) | |||
| 2461 | entry = debugfs_create_file("available_events", 0444, d_tracer, | 2460 | entry = debugfs_create_file("available_events", 0444, d_tracer, |
| 2462 | tr, &ftrace_avail_fops); | 2461 | tr, &ftrace_avail_fops); |
| 2463 | if (!entry) | 2462 | if (!entry) |
| 2464 | pr_warning("Could not create debugfs " | 2463 | pr_warn("Could not create debugfs 'available_events' entry\n"); |
| 2465 | "'available_events' entry\n"); | ||
| 2466 | 2464 | ||
| 2467 | if (trace_define_common_fields()) | 2465 | if (trace_define_common_fields()) |
| 2468 | pr_warning("tracing: Failed to allocate common fields"); | 2466 | pr_warn("tracing: Failed to allocate common fields"); |
| 2469 | 2467 | ||
| 2470 | ret = early_event_add_tracer(d_tracer, tr); | 2468 | ret = early_event_add_tracer(d_tracer, tr); |
| 2471 | if (ret) | 2469 | if (ret) |
| @@ -2474,7 +2472,7 @@ static __init int event_trace_init(void) | |||
| 2474 | #ifdef CONFIG_MODULES | 2472 | #ifdef CONFIG_MODULES |
| 2475 | ret = register_module_notifier(&trace_module_nb); | 2473 | ret = register_module_notifier(&trace_module_nb); |
| 2476 | if (ret) | 2474 | if (ret) |
| 2477 | pr_warning("Failed to register trace events module notifier\n"); | 2475 | pr_warn("Failed to register trace events module notifier\n"); |
| 2478 | #endif | 2476 | #endif |
| 2479 | return 0; | 2477 | return 0; |
| 2480 | } | 2478 | } |
| @@ -2578,7 +2576,7 @@ static __init void event_trace_self_tests(void) | |||
| 2578 | * it and the self test should not be on. | 2576 | * it and the self test should not be on. |
| 2579 | */ | 2577 | */ |
| 2580 | if (file->flags & FTRACE_EVENT_FL_ENABLED) { | 2578 | if (file->flags & FTRACE_EVENT_FL_ENABLED) { |
| 2581 | pr_warning("Enabled event during self test!\n"); | 2579 | pr_warn("Enabled event during self test!\n"); |
| 2582 | WARN_ON_ONCE(1); | 2580 | WARN_ON_ONCE(1); |
| 2583 | continue; | 2581 | continue; |
| 2584 | } | 2582 | } |
| @@ -2606,8 +2604,8 @@ static __init void event_trace_self_tests(void) | |||
| 2606 | 2604 | ||
| 2607 | ret = __ftrace_set_clr_event(tr, NULL, system->name, NULL, 1); | 2605 | ret = __ftrace_set_clr_event(tr, NULL, system->name, NULL, 1); |
| 2608 | if (WARN_ON_ONCE(ret)) { | 2606 | if (WARN_ON_ONCE(ret)) { |
| 2609 | pr_warning("error enabling system %s\n", | 2607 | pr_warn("error enabling system %s\n", |
| 2610 | system->name); | 2608 | system->name); |
| 2611 | continue; | 2609 | continue; |
| 2612 | } | 2610 | } |
| 2613 | 2611 | ||
| @@ -2615,8 +2613,8 @@ static __init void event_trace_self_tests(void) | |||
| 2615 | 2613 | ||
| 2616 | ret = __ftrace_set_clr_event(tr, NULL, system->name, NULL, 0); | 2614 | ret = __ftrace_set_clr_event(tr, NULL, system->name, NULL, 0); |
| 2617 | if (WARN_ON_ONCE(ret | ||
