diff options
| author | Nicolas Dichtel <nicolas.dichtel@6wind.com> | 2016-03-04 05:52:16 -0500 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-03-04 16:10:36 -0500 |
| commit | b5d3755a22e0cc4c369c0985aef0c52c2477c1e7 (patch) | |
| tree | 2fef71a2d85dde83950727068fd890a4f10c8be6 /include/uapi/linux | |
| parent | 9b2f8f616a8d992243be31ff47d3f64031bf168a (diff) | |
uapi: define DIV_ROUND_UP for userland
DIV_ROUND_UP is defined in linux/kernel.h only for the kernel.
When ethtool.h is included by a userland app, we got the following error:
include/linux/ethtool.h:1218:8: error: variably modified 'queue_mask' at file scope
__u32 queue_mask[DIV_ROUND_UP(MAX_NUM_QUEUE, 32)];
^
Let's add a common definition in uapi and use it everywhere.
Fixes: ac2c7ad0e5d6 ("net/ethtool: introduce a new ioctl for per queue setting")
CC: Kan Liang <kan.liang@intel.com>
Suggested-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/uapi/linux')
| -rw-r--r-- | include/uapi/linux/ethtool.h | 3 | ||||
| -rw-r--r-- | include/uapi/linux/kernel.h | 1 | ||||
| -rw-r--r-- | include/uapi/linux/mroute6.h | 9 |
3 files changed, 5 insertions, 8 deletions
diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h index 37fd6dc33de4..9c22249ebf35 100644 --- a/include/uapi/linux/ethtool.h +++ b/include/uapi/linux/ethtool.h | |||
| @@ -13,6 +13,7 @@ | |||
| 13 | #ifndef _UAPI_LINUX_ETHTOOL_H | 13 | #ifndef _UAPI_LINUX_ETHTOOL_H |
| 14 | #define _UAPI_LINUX_ETHTOOL_H | 14 | #define _UAPI_LINUX_ETHTOOL_H |
| 15 | 15 | ||
| 16 | #include <linux/kernel.h> | ||
| 16 | #include <linux/types.h> | 17 | #include <linux/types.h> |
| 17 | #include <linux/if_ether.h> | 18 | #include <linux/if_ether.h> |
| 18 | 19 | ||
| @@ -1215,7 +1216,7 @@ enum ethtool_sfeatures_retval_bits { | |||
| 1215 | struct ethtool_per_queue_op { | 1216 | struct ethtool_per_queue_op { |
| 1216 | __u32 cmd; | 1217 | __u32 cmd; |
| 1217 | __u32 sub_command; | 1218 | __u32 sub_command; |
| 1218 | __u32 queue_mask[DIV_ROUND_UP(MAX_NUM_QUEUE, 32)]; | 1219 | __u32 queue_mask[__KERNEL_DIV_ROUND_UP(MAX_NUM_QUEUE, 32)]; |
| 1219 | char data[]; | 1220 | char data[]; |
| 1220 | }; | 1221 | }; |
| 1221 | 1222 | ||
diff --git a/include/uapi/linux/kernel.h b/include/uapi/linux/kernel.h index 321e399457f5..466073f0ce46 100644 --- a/include/uapi/linux/kernel.h +++ b/include/uapi/linux/kernel.h | |||
| @@ -9,5 +9,6 @@ | |||
| 9 | #define __ALIGN_KERNEL(x, a) __ALIGN_KERNEL_MASK(x, (typeof(x))(a) - 1) | 9 | #define __ALIGN_KERNEL(x, a) __ALIGN_KERNEL_MASK(x, (typeof(x))(a) - 1) |
| 10 | #define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask)) | 10 | #define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask)) |
| 11 | 11 | ||
| 12 | #define __KERNEL_DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d)) | ||
| 12 | 13 | ||
| 13 | #endif /* _UAPI_LINUX_KERNEL_H */ | 14 | #endif /* _UAPI_LINUX_KERNEL_H */ |
diff --git a/include/uapi/linux/mroute6.h b/include/uapi/linux/mroute6.h index ce91215cf7e6..5062fb5751e1 100644 --- a/include/uapi/linux/mroute6.h +++ b/include/uapi/linux/mroute6.h | |||
| @@ -1,6 +1,7 @@ | |||
| 1 | #ifndef _UAPI__LINUX_MROUTE6_H | 1 | #ifndef _UAPI__LINUX_MROUTE6_H |
| 2 | #define _UAPI__LINUX_MROUTE6_H | 2 | #define _UAPI__LINUX_MROUTE6_H |
| 3 | 3 | ||
| 4 | #include <linux/kernel.h> | ||
| 4 | #include <linux/types.h> | 5 | #include <linux/types.h> |
| 5 | #include <linux/sockios.h> | 6 | #include <linux/sockios.h> |
| 6 | 7 | ||
| @@ -46,14 +47,8 @@ typedef unsigned short mifi_t; | |||
| 46 | typedef __u32 if_mask; | 47 | typedef __u32 if_mask; |
| 47 | #define NIFBITS (sizeof(if_mask) * 8) /* bits per mask */ | 48 | #define NIFBITS (sizeof(if_mask) * 8) /* bits per mask */ |
| 48 | 49 | ||
| 49 | #if !defined(__KERNEL__) | ||
| 50 | #if !defined(DIV_ROUND_UP) | ||
| 51 | #define DIV_ROUND_UP(x,y) (((x) + ((y) - 1)) / (y)) | ||
| 52 | #endif | ||
| 53 | #endif | ||
| 54 | |||
| 55 | typedef struct if_set { | 50 | typedef struct if_set { |
| 56 | if_mask ifs_bits[DIV_ROUND_UP(IF_SETSIZE, NIFBITS)]; | 51 | if_mask ifs_bits[__KERNEL_DIV_ROUND_UP(IF_SETSIZE, NIFBITS)]; |
| 57 | } if_set; | 52 | } if_set; |
| 58 | 53 | ||
| 59 | #define IF_SET(n, p) ((p)->ifs_bits[(n)/NIFBITS] |= (1 << ((n) % NIFBITS))) | 54 | #define IF_SET(n, p) ((p)->ifs_bits[(n)/NIFBITS] |= (1 << ((n) % NIFBITS))) |
