diff options
| author | Peter Zijlstra <peterz@infradead.org> | 2014-01-22 05:24:35 -0500 |
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2014-01-23 08:48:35 -0500 |
| commit | 215393bc1fab3d61a5a296838bdffce22f27ffda (patch) | |
| tree | 8e2c937a90c53d2e52fe16f380e8eeaaceef2bcd /include/linux/preempt.h | |
| parent | 9390675af0835ae1d654d33bfcf16096028550ad (diff) | |
sched/preempt/x86: Fix voluntary preempt for x86
The #ifdef CONFIG_PREEMPT is both not needed and wrong.
Its not required because asm/preempt.h should provide
{set,clear}_preempt_need_resched() regardless and its wrong because
for voluntary preempt we still rely on PREEMPT_NEED_RESCHED.
Reported-and-Tested-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Fixes: 8cb75e0c4ec9 ("sched/preempt: Fix up missed PREEMPT_NEED_RESCHED folding")
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: Dipankar Sarma <dipankar@in.ibm.com>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/20140122102435.GH31570@twins.programming.kicks-ass.net
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'include/linux/preempt.h')
| -rw-r--r-- | include/linux/preempt.h | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/include/linux/preempt.h b/include/linux/preempt.h index 59749fc48328..de83b4eb1642 100644 --- a/include/linux/preempt.h +++ b/include/linux/preempt.h | |||
| @@ -134,7 +134,6 @@ do { \ | |||
| 134 | #undef preempt_check_resched | 134 | #undef preempt_check_resched |
| 135 | #endif | 135 | #endif |
| 136 | 136 | ||
| 137 | #ifdef CONFIG_PREEMPT | ||
| 138 | #define preempt_set_need_resched() \ | 137 | #define preempt_set_need_resched() \ |
| 139 | do { \ | 138 | do { \ |
| 140 | set_preempt_need_resched(); \ | 139 | set_preempt_need_resched(); \ |
| @@ -144,10 +143,6 @@ do { \ | |||
| 144 | if (tif_need_resched()) \ | 143 | if (tif_need_resched()) \ |
| 145 | set_preempt_need_resched(); \ | 144 | set_preempt_need_resched(); \ |
| 146 | } while (0) | 145 | } while (0) |
| 147 | #else | ||
| 148 | #define preempt_set_need_resched() do { } while (0) | ||
| 149 | #define preempt_fold_need_resched() do { } while (0) | ||
| 150 | #endif | ||
| 151 | 146 | ||
| 152 | #ifdef CONFIG_PREEMPT_NOTIFIERS | 147 | #ifdef CONFIG_PREEMPT_NOTIFIERS |
| 153 | 148 | ||
