diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2014-05-23 06:20:42 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2014-06-05 05:52:13 -0400 |
commit | fa93384f40deeb294fd29f2fdcadbd0ebc2dedf1 (patch) | |
tree | 7948bf37a7b399f753937a311488b3f23b01622e /include/linux/kvm_host.h | |
parent | 2538d960d0c74cdc639f05723e04a67aed1efdf9 (diff) |
sched: Fix signedness bug in yield_to()
yield_to() is supposed to return -ESRCH if there is no task to
yield to, but because the type is bool that is the same as returning
true.
The only place I see which cares is kvm_vcpu_on_spin().
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Raghavendra <raghavendra.kt@linux.vnet.ibm.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: Gleb Natapov <gleb@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org
Link: http://lkml.kernel.org/r/20140523102042.GA7267@mwanda
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'include/linux/kvm_host.h')
-rw-r--r-- | include/linux/kvm_host.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h index 7d21cf9f4380..3c4bcf146159 100644 --- a/include/linux/kvm_host.h +++ b/include/linux/kvm_host.h | |||
@@ -584,7 +584,7 @@ void mark_page_dirty(struct kvm *kvm, gfn_t gfn); | |||
584 | 584 | ||
585 | void kvm_vcpu_block(struct kvm_vcpu *vcpu); | 585 | void kvm_vcpu_block(struct kvm_vcpu *vcpu); |
586 | void kvm_vcpu_kick(struct kvm_vcpu *vcpu); | 586 | void kvm_vcpu_kick(struct kvm_vcpu *vcpu); |
587 | bool kvm_vcpu_yield_to(struct kvm_vcpu *target); | 587 | int kvm_vcpu_yield_to(struct kvm_vcpu *target); |
588 | void kvm_vcpu_on_spin(struct kvm_vcpu *vcpu); | 588 | void kvm_vcpu_on_spin(struct kvm_vcpu *vcpu); |
589 | void kvm_load_guest_fpu(struct kvm_vcpu *vcpu); | 589 | void kvm_load_guest_fpu(struct kvm_vcpu *vcpu); |
590 | void kvm_put_guest_fpu(struct kvm_vcpu *vcpu); | 590 | void kvm_put_guest_fpu(struct kvm_vcpu *vcpu); |