diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2016-08-23 09:09:40 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-09-02 09:05:48 -0400 |
| commit | d2f5a7311bcaed681a41cb3419b8fe92a7b68bf5 (patch) | |
| tree | 9a7669cb11f6314817fced673fd63d26d7bc5153 /include/linux/dma | |
| parent | 46e36683f433528bfb7e5754ca5c5c86c204c40a (diff) | |
dmaengine: hsu: refactor hsu_dma_do_irq() to return int
Since we have nice macro IRQ_RETVAL() we would use it to convert a flag of
handled interrupt from int to irqreturn_t.
The rationale of doing this is:
a) hence we implicitly mark hsu_dma_do_irq() as an auxiliary function that
can't be used as interrupt handler directly, and
b) to be in align with serial driver which is using serial8250_handle_irq()
that returns plain int by design.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include/linux/dma')
| -rw-r--r-- | include/linux/dma/hsu.h | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/include/linux/dma/hsu.h b/include/linux/dma/hsu.h index aaff68efba5d..197eec63e501 100644 --- a/include/linux/dma/hsu.h +++ b/include/linux/dma/hsu.h | |||
| @@ -41,8 +41,7 @@ struct hsu_dma_chip { | |||
| 41 | /* Export to the internal users */ | 41 | /* Export to the internal users */ |
| 42 | int hsu_dma_get_status(struct hsu_dma_chip *chip, unsigned short nr, | 42 | int hsu_dma_get_status(struct hsu_dma_chip *chip, unsigned short nr, |
| 43 | u32 *status); | 43 | u32 *status); |
| 44 | irqreturn_t hsu_dma_do_irq(struct hsu_dma_chip *chip, unsigned short nr, | 44 | int hsu_dma_do_irq(struct hsu_dma_chip *chip, unsigned short nr, u32 status); |
| 45 | u32 status); | ||
| 46 | 45 | ||
| 47 | /* Export to the platform drivers */ | 46 | /* Export to the platform drivers */ |
| 48 | int hsu_dma_probe(struct hsu_dma_chip *chip); | 47 | int hsu_dma_probe(struct hsu_dma_chip *chip); |
| @@ -53,10 +52,10 @@ static inline int hsu_dma_get_status(struct hsu_dma_chip *chip, | |||
| 53 | { | 52 | { |
| 54 | return 0; | 53 | return 0; |
| 55 | } | 54 | } |
| 56 | static inline irqreturn_t hsu_dma_do_irq(struct hsu_dma_chip *chip, | 55 | static inline int hsu_dma_do_irq(struct hsu_dma_chip *chip, unsigned short nr, |
| 57 | unsigned short nr, u32 status) | 56 | u32 status) |
| 58 | { | 57 | { |
| 59 | return IRQ_NONE; | 58 | return 0; |
| 60 | } | 59 | } |
| 61 | static inline int hsu_dma_probe(struct hsu_dma_chip *chip) { return -ENODEV; } | 60 | static inline int hsu_dma_probe(struct hsu_dma_chip *chip) { return -ENODEV; } |
| 62 | static inline int hsu_dma_remove(struct hsu_dma_chip *chip) { return 0; } | 61 | static inline int hsu_dma_remove(struct hsu_dma_chip *chip) { return 0; } |
