diff options
author | Matthew Wilcox <willy@linux.intel.com> | 2015-09-08 17:59:11 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2015-09-08 18:35:28 -0400 |
commit | e676a4c191653787c3fe851fe3b9f1f33d49dac2 (patch) | |
tree | 5b83a284b5a4fbe41da5a34f0e321e09e0d4c188 /fs | |
parent | dd8a2b6c29a3221c19ab475c8408fc2b914ccfab (diff) |
ext4: use ext4_get_block_write() for DAX
DAX relies on the get_block function either zeroing newly allocated
blocks before they're findable by subsequent calls to get_block, or
marking newly allocated blocks as unwritten. ext4_get_block() cannot
create unwritten extents, but ext4_get_block_write() can.
Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
Reported-by: Andy Rudoff <andy.rudoff@intel.com>
Cc: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/ext4/file.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/fs/ext4/file.c b/fs/ext4/file.c index 953d519e799c..ca5302a256ea 100644 --- a/fs/ext4/file.c +++ b/fs/ext4/file.c | |||
@@ -196,7 +196,7 @@ out: | |||
196 | static void ext4_end_io_unwritten(struct buffer_head *bh, int uptodate) | 196 | static void ext4_end_io_unwritten(struct buffer_head *bh, int uptodate) |
197 | { | 197 | { |
198 | struct inode *inode = bh->b_assoc_map->host; | 198 | struct inode *inode = bh->b_assoc_map->host; |
199 | /* XXX: breaks on 32-bit > 16GB. Is that even supported? */ | 199 | /* XXX: breaks on 32-bit > 16TB. Is that even supported? */ |
200 | loff_t offset = (loff_t)(uintptr_t)bh->b_private << inode->i_blkbits; | 200 | loff_t offset = (loff_t)(uintptr_t)bh->b_private << inode->i_blkbits; |
201 | int err; | 201 | int err; |
202 | if (!uptodate) | 202 | if (!uptodate) |
@@ -207,8 +207,7 @@ static void ext4_end_io_unwritten(struct buffer_head *bh, int uptodate) | |||
207 | 207 | ||
208 | static int ext4_dax_fault(struct vm_area_struct *vma, struct vm_fault *vmf) | 208 | static int ext4_dax_fault(struct vm_area_struct *vma, struct vm_fault *vmf) |
209 | { | 209 | { |
210 | return dax_fault(vma, vmf, ext4_get_block, ext4_end_io_unwritten); | 210 | return dax_fault(vma, vmf, ext4_get_block_write, ext4_end_io_unwritten); |
211 | /* Is this the right get_block? */ | ||
212 | } | 211 | } |
213 | 212 | ||
214 | static int ext4_dax_pmd_fault(struct vm_area_struct *vma, unsigned long addr, | 213 | static int ext4_dax_pmd_fault(struct vm_area_struct *vma, unsigned long addr, |
@@ -220,7 +219,8 @@ static int ext4_dax_pmd_fault(struct vm_area_struct *vma, unsigned long addr, | |||
220 | 219 | ||
221 | static int ext4_dax_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf) | 220 | static int ext4_dax_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf) |
222 | { | 221 | { |
223 | return dax_mkwrite(vma, vmf, ext4_get_block, ext4_end_io_unwritten); | 222 | return dax_mkwrite(vma, vmf, ext4_get_block_write, |
223 | ext4_end_io_unwritten); | ||
224 | } | 224 | } |
225 | 225 | ||
226 | static const struct vm_operations_struct ext4_dax_vm_ops = { | 226 | static const struct vm_operations_struct ext4_dax_vm_ops = { |