diff options
author | Wang Xiaoguang <wangxg.fnst@cn.fujitsu.com> | 2016-06-19 21:18:52 -0400 |
---|---|---|
committer | David Sterba <dsterba@suse.com> | 2016-10-24 12:20:29 -0400 |
commit | 9d1032cc49a8a1065e79ee323de66bcb4fdbd535 (patch) | |
tree | 949523d20856471ba5d48aaca9cf26c70638b59a /fs | |
parent | 9c894696f56f5d84fb5766af81bcda4a7cb9a842 (diff) |
btrfs: fix WARNING in btrfs_select_ref_head()
This issue was found when testing in-band dedupe enospc behaviour,
sometimes run_one_delayed_ref() may fail for enospc reason, then
__btrfs_run_delayed_refs()will return, but forget to add num_heads_read
back, which will trigger "WARN_ON(delayed_refs->num_heads_ready == 0)" in
btrfs_select_ref_head().
Signed-off-by: Wang Xiaoguang <wangxg.fnst@cn.fujitsu.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/btrfs/extent-tree.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index 210c94ac8818..4607af38c72e 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c | |||
@@ -2647,7 +2647,10 @@ static noinline int __btrfs_run_delayed_refs(struct btrfs_trans_handle *trans, | |||
2647 | 2647 | ||
2648 | btrfs_free_delayed_extent_op(extent_op); | 2648 | btrfs_free_delayed_extent_op(extent_op); |
2649 | if (ret) { | 2649 | if (ret) { |
2650 | spin_lock(&delayed_refs->lock); | ||
2650 | locked_ref->processing = 0; | 2651 | locked_ref->processing = 0; |
2652 | delayed_refs->num_heads_ready++; | ||
2653 | spin_unlock(&delayed_refs->lock); | ||
2651 | btrfs_delayed_ref_unlock(locked_ref); | 2654 | btrfs_delayed_ref_unlock(locked_ref); |
2652 | btrfs_put_delayed_ref(ref); | 2655 | btrfs_put_delayed_ref(ref); |
2653 | btrfs_debug(fs_info, "run_one_delayed_ref returned %d", | 2656 | btrfs_debug(fs_info, "run_one_delayed_ref returned %d", |