diff options
author | David Disseldorp <ddiss@suse.de> | 2017-05-03 11:39:08 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-05-20 08:28:40 -0400 |
commit | 411346640ccd04ea8571eb5871659b0bd33b007e (patch) | |
tree | dc6f89b66a357f25ebee331ca63c1844f5e9e9cd /fs | |
parent | 449a74439d1525b43357be9da42b84fcdbd6b5a9 (diff) |
cifs: fix CIFS_ENUMERATE_SNAPSHOTS oops
commit 6026685de33b0db5b2b6b0e9b41b3a1a3261033c upstream.
As with 618763958b22, an open directory may have a NULL private_data
pointer prior to readdir. CIFS_ENUMERATE_SNAPSHOTS must check for this
before dereference.
Fixes: 834170c85978 ("Enable previous version support")
Signed-off-by: David Disseldorp <ddiss@suse.de>
Signed-off-by: Steve French <smfrench@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/cifs/ioctl.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/cifs/ioctl.c b/fs/cifs/ioctl.c index 001528781b6b..b52b7ffa6d34 100644 --- a/fs/cifs/ioctl.c +++ b/fs/cifs/ioctl.c | |||
@@ -268,6 +268,8 @@ long cifs_ioctl(struct file *filep, unsigned int command, unsigned long arg) | |||
268 | rc = smb_mnt_get_fsinfo(xid, tcon, (void __user *)arg); | 268 | rc = smb_mnt_get_fsinfo(xid, tcon, (void __user *)arg); |
269 | break; | 269 | break; |
270 | case CIFS_ENUMERATE_SNAPSHOTS: | 270 | case CIFS_ENUMERATE_SNAPSHOTS: |
271 | if (pSMBFile == NULL) | ||
272 | break; | ||
271 | if (arg == 0) { | 273 | if (arg == 0) { |
272 | rc = -EINVAL; | 274 | rc = -EINVAL; |
273 | goto cifs_ioc_exit; | 275 | goto cifs_ioc_exit; |