aboutsummaryrefslogtreecommitdiffstats
path: root/fs/hfsplus
diff options
context:
space:
mode:
authorAl Viro <viro@zeniv.linux.org.uk>2015-11-17 01:07:57 -0500
committerAl Viro <viro@zeniv.linux.org.uk>2015-12-08 22:41:36 -0500
commit21fc61c73c3903c4c312d0802da01ec2b323d174 (patch)
treea26c29e3fbb766f00b023724e9e5b8b9bba9b879 /fs/hfsplus
parentaa80deab33a8fb180e718f5e45514db19aade165 (diff)
don't put symlink bodies in pagecache into highmem
kmap() in page_follow_link_light() needed to go - allowing to hold an arbitrary number of kmaps for long is a great way to deadlocking the system. new helper (inode_nohighmem(inode)) needs to be used for pagecache symlinks inodes; done for all in-tree cases. page_follow_link_light() instrumented to yell about anything missed. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/hfsplus')
-rw-r--r--fs/hfsplus/inode.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/hfsplus/inode.c b/fs/hfsplus/inode.c
index 6dd107d7421e..19b33f8151f1 100644
--- a/fs/hfsplus/inode.c
+++ b/fs/hfsplus/inode.c
@@ -403,6 +403,7 @@ struct inode *hfsplus_new_inode(struct super_block *sb, umode_t mode)
403 } else if (S_ISLNK(inode->i_mode)) { 403 } else if (S_ISLNK(inode->i_mode)) {
404 sbi->file_count++; 404 sbi->file_count++;
405 inode->i_op = &page_symlink_inode_operations; 405 inode->i_op = &page_symlink_inode_operations;
406 inode_nohighmem(inode);
406 inode->i_mapping->a_ops = &hfsplus_aops; 407 inode->i_mapping->a_ops = &hfsplus_aops;
407 hip->clump_blocks = 1; 408 hip->clump_blocks = 1;
408 } else 409 } else
@@ -526,6 +527,7 @@ int hfsplus_cat_read_inode(struct inode *inode, struct hfs_find_data *fd)
526 inode->i_mapping->a_ops = &hfsplus_aops; 527 inode->i_mapping->a_ops = &hfsplus_aops;
527 } else if (S_ISLNK(inode->i_mode)) { 528 } else if (S_ISLNK(inode->i_mode)) {
528 inode->i_op = &page_symlink_inode_operations; 529 inode->i_op = &page_symlink_inode_operations;
530 inode_nohighmem(inode);
529 inode->i_mapping->a_ops = &hfsplus_aops; 531 inode->i_mapping->a_ops = &hfsplus_aops;
530 } else { 532 } else {
531 init_special_inode(inode, inode->i_mode, 533 init_special_inode(inode, inode->i_mode,