diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2013-10-03 13:16:50 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2013-10-24 23:43:28 -0400 |
commit | cac45b062c67f86dc1d91d675128838773523243 (patch) | |
tree | fcc7dc448d0e14f992794657eae1f052e0826f5a /fs/fat | |
parent | 2e32cf5ef2683a196df24ccd2cd2b4ed735ad9d3 (diff) |
fat: rcu-delay unloading nls and freeing sbi
makes ->d_hash() and ->d_compare() safety in RCU mode independent
from vfsmount_lock.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/fat')
-rw-r--r-- | fs/fat/fat.h | 1 | ||||
-rw-r--r-- | fs/fat/inode.c | 19 |
2 files changed, 12 insertions, 8 deletions
diff --git a/fs/fat/fat.h b/fs/fat/fat.h index 4241e6f39e86..7c31f4bc74a9 100644 --- a/fs/fat/fat.h +++ b/fs/fat/fat.h | |||
@@ -102,6 +102,7 @@ struct msdos_sb_info { | |||
102 | struct hlist_head dir_hashtable[FAT_HASH_SIZE]; | 102 | struct hlist_head dir_hashtable[FAT_HASH_SIZE]; |
103 | 103 | ||
104 | unsigned int dirty; /* fs state before mount */ | 104 | unsigned int dirty; /* fs state before mount */ |
105 | struct rcu_head rcu; | ||
105 | }; | 106 | }; |
106 | 107 | ||
107 | #define FAT_CACHE_VALID 0 /* special case for valid cache */ | 108 | #define FAT_CACHE_VALID 0 /* special case for valid cache */ |
diff --git a/fs/fat/inode.c b/fs/fat/inode.c index 0062da21dd8b..854b578f6695 100644 --- a/fs/fat/inode.c +++ b/fs/fat/inode.c | |||
@@ -548,6 +548,16 @@ static void fat_set_state(struct super_block *sb, | |||
548 | brelse(bh); | 548 | brelse(bh); |
549 | } | 549 | } |
550 | 550 | ||
551 | static void delayed_free(struct rcu_head *p) | ||
552 | { | ||
553 | struct msdos_sb_info *sbi = container_of(p, struct msdos_sb_info, rcu); | ||
554 | unload_nls(sbi->nls_disk); | ||
555 | unload_nls(sbi->nls_io); | ||
556 | if (sbi->options.iocharset != fat_default_iocharset) | ||
557 | kfree(sbi->options.iocharset); | ||
558 | kfree(sbi); | ||
559 | } | ||
560 | |||
551 | static void fat_put_super(struct super_block *sb) | 561 | static void fat_put_super(struct super_block *sb) |
552 | { | 562 | { |
553 | struct msdos_sb_info *sbi = MSDOS_SB(sb); | 563 | struct msdos_sb_info *sbi = MSDOS_SB(sb); |
@@ -557,14 +567,7 @@ static void fat_put_super(struct super_block *sb) | |||
557 | iput(sbi->fsinfo_inode); | 567 | iput(sbi->fsinfo_inode); |
558 | iput(sbi->fat_inode); | 568 | iput(sbi->fat_inode); |
559 | 569 | ||
560 | unload_nls(sbi->nls_disk); | 570 | call_rcu(&sbi->rcu, delayed_free); |
561 | unload_nls(sbi->nls_io); | ||
562 | |||
563 | if (sbi->options.iocharset != fat_default_iocharset) | ||
564 | kfree(sbi->options.iocharset); | ||
565 | |||
566 | sb->s_fs_info = NULL; | ||
567 | kfree(sbi); | ||
568 | } | 571 | } |
569 | 572 | ||
570 | static struct kmem_cache *fat_inode_cachep; | 573 | static struct kmem_cache *fat_inode_cachep; |