diff options
author | Yunlei He <heyunlei@huawei.com> | 2015-12-28 08:48:32 -0500 |
---|---|---|
committer | Jaegeuk Kim <jaegeuk@kernel.org> | 2015-12-30 13:14:17 -0500 |
commit | 179448bfe4cd201e98e728391c6b01b25c849fe8 (patch) | |
tree | ecf6295f3123872805bbeb31671ac7f7425b8df8 /fs/f2fs | |
parent | 9a950d52b7f0e1c64c2cc70d350562fb18c8b451 (diff) |
f2fs: add a max block check for get_data_block_bmap
This patch adds a max block check for get_data_block_bmap.
Trinity test program will send a block number as parameter into
ioctl_fibmap, which will be used in get_node_path(), when the block
number large than f2fs max blocks, it will trigger kernel bug.
Signed-off-by: Yunlei He <heyunlei@huawei.com>
Signed-off-by: Xue Liu <liuxueliu.liu@huawei.com>
[Jaegeuk Kim: fix missing condition, pointed by Chao Yu]
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'fs/f2fs')
-rw-r--r-- | fs/f2fs/data.c | 4 | ||||
-rw-r--r-- | fs/f2fs/f2fs.h | 1 | ||||
-rw-r--r-- | fs/f2fs/super.c | 2 |
3 files changed, 6 insertions, 1 deletions
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index d67c599510d9..6fbfc70ac8a0 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c | |||
@@ -761,6 +761,10 @@ static int get_data_block_dio(struct inode *inode, sector_t iblock, | |||
761 | static int get_data_block_bmap(struct inode *inode, sector_t iblock, | 761 | static int get_data_block_bmap(struct inode *inode, sector_t iblock, |
762 | struct buffer_head *bh_result, int create) | 762 | struct buffer_head *bh_result, int create) |
763 | { | 763 | { |
764 | /* Block number less than F2FS MAX BLOCKS */ | ||
765 | if (unlikely(iblock >= max_file_size(0))) | ||
766 | return -EFBIG; | ||
767 | |||
764 | return __get_data_block(inode, iblock, bh_result, create, | 768 | return __get_data_block(inode, iblock, bh_result, create, |
765 | F2FS_GET_BLOCK_BMAP); | 769 | F2FS_GET_BLOCK_BMAP); |
766 | } | 770 | } |
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 3406e9966064..e04b2be6cd64 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h | |||
@@ -1726,6 +1726,7 @@ static inline int f2fs_add_link(struct dentry *dentry, struct inode *inode) | |||
1726 | * super.c | 1726 | * super.c |
1727 | */ | 1727 | */ |
1728 | int f2fs_commit_super(struct f2fs_sb_info *, bool); | 1728 | int f2fs_commit_super(struct f2fs_sb_info *, bool); |
1729 | loff_t max_file_size(unsigned bits); | ||
1729 | int f2fs_sync_fs(struct super_block *, int); | 1730 | int f2fs_sync_fs(struct super_block *, int); |
1730 | extern __printf(3, 4) | 1731 | extern __printf(3, 4) |
1731 | void f2fs_msg(struct super_block *, const char *, const char *, ...); | 1732 | void f2fs_msg(struct super_block *, const char *, const char *, ...); |
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index 75704d9caae2..a2e3a8f893ed 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c | |||
@@ -907,7 +907,7 @@ static const struct export_operations f2fs_export_ops = { | |||
907 | .get_parent = f2fs_get_parent, | 907 | .get_parent = f2fs_get_parent, |
908 | }; | 908 | }; |
909 | 909 | ||
910 | static loff_t max_file_size(unsigned bits) | 910 | loff_t max_file_size(unsigned bits) |
911 | { | 911 | { |
912 | loff_t result = (DEF_ADDRS_PER_INODE - F2FS_INLINE_XATTR_ADDRS); | 912 | loff_t result = (DEF_ADDRS_PER_INODE - F2FS_INLINE_XATTR_ADDRS); |
913 | loff_t leaf_count = ADDRS_PER_BLOCK; | 913 | loff_t leaf_count = ADDRS_PER_BLOCK; |