aboutsummaryrefslogtreecommitdiffstats
path: root/fs/dcache.c
diff options
context:
space:
mode:
authorEric W. Biederman <ebiederm@xmission.com>2015-05-24 10:25:00 -0400
committerEric W. Biederman <ebiederm@xmission.com>2015-07-01 11:36:51 -0400
commit93e3bce6287e1fb3e60d3324ed08555b5bbafa89 (patch)
tree4455bc56fc885d380ca6a145f29786c1f9c05d8c /fs/dcache.c
parent7236c85e1be51a9e25ba0f6e087a66ca89605a49 (diff)
vfs: Remove incorrect debugging WARN in prepend_path
The warning message in prepend_path is unclear and outdated. It was added as a warning that the mechanism for generating names of pseudo files had been removed from prepend_path and d_dname should be used instead. Unfortunately the warning reads like a general warning, making it unclear what to do with it. Remove the warning. The transition it was added to warn about is long over, and I added code several years ago which in rare cases causes the warning to fire on legitimate code, and the warning is now firing and scaring people for no good reason. Cc: stable@vger.kernel.org Reported-by: Ivan Delalande <colona@arista.com> Reported-by: Omar Sandoval <osandov@osandov.com> Fixes: f48cfddc6729e ("vfs: In d_path don't call d_dname on a mount point") Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Diffstat (limited to 'fs/dcache.c')
-rw-r--r--fs/dcache.c11
1 files changed, 0 insertions, 11 deletions
diff --git a/fs/dcache.c b/fs/dcache.c
index 656ce522a218..615dfc2aa752 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -2927,17 +2927,6 @@ restart:
2927 vfsmnt = &mnt->mnt; 2927 vfsmnt = &mnt->mnt;
2928 continue; 2928 continue;
2929 } 2929 }
2930 /*
2931 * Filesystems needing to implement special "root names"
2932 * should do so with ->d_dname()
2933 */
2934 if (IS_ROOT(dentry) &&
2935 (dentry->d_name.len != 1 ||
2936 dentry->d_name.name[0] != '/')) {
2937 WARN(1, "Root dentry has weird name <%.*s>\n",
2938 (int) dentry->d_name.len,
2939 dentry->d_name.name);
2940 }
2941 if (!error) 2930 if (!error)
2942 error = is_mounted(vfsmnt) ? 1 : 2; 2931 error = is_mounted(vfsmnt) ? 1 : 2;
2943 break; 2932 break;