diff options
author | Fabian Frederick <fabf@skynet.be> | 2015-02-17 16:46:20 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2015-02-17 17:34:52 -0500 |
commit | eeb36f8e938d151fc5e12e96ae13d0e283be357e (patch) | |
tree | f7c9cc24c84059586ff5c51f41a5fa8ce3e45df5 /fs/affs | |
parent | 4d29e571e1942f8f418bf776af0134a9cb5a35c9 (diff) |
fs/affs: use unsigned int for string lengths
- Some min() were used with different types.
- Create a new variable in __affs_hash_dentry() to process
affs_check_name()/min() return
Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/affs')
-rw-r--r-- | fs/affs/amigaffs.c | 2 | ||||
-rw-r--r-- | fs/affs/namei.c | 15 |
2 files changed, 9 insertions, 8 deletions
diff --git a/fs/affs/amigaffs.c b/fs/affs/amigaffs.c index 511ab6b12618..0836f6fff641 100644 --- a/fs/affs/amigaffs.c +++ b/fs/affs/amigaffs.c | |||
@@ -508,7 +508,7 @@ affs_check_name(const unsigned char *name, int len, bool notruncate) | |||
508 | int | 508 | int |
509 | affs_copy_name(unsigned char *bstr, struct dentry *dentry) | 509 | affs_copy_name(unsigned char *bstr, struct dentry *dentry) |
510 | { | 510 | { |
511 | int len = min(dentry->d_name.len, 30u); | 511 | u32 len = min(dentry->d_name.len, 30u); |
512 | 512 | ||
513 | *bstr++ = len; | 513 | *bstr++ = len; |
514 | memcpy(bstr, dentry->d_name.name, len); | 514 | memcpy(bstr, dentry->d_name.name, len); |
diff --git a/fs/affs/namei.c b/fs/affs/namei.c index de84f4d3e9ec..66c6cb349bf6 100644 --- a/fs/affs/namei.c +++ b/fs/affs/namei.c | |||
@@ -64,15 +64,16 @@ __affs_hash_dentry(struct qstr *qstr, toupper_t toupper, bool notruncate) | |||
64 | { | 64 | { |
65 | const u8 *name = qstr->name; | 65 | const u8 *name = qstr->name; |
66 | unsigned long hash; | 66 | unsigned long hash; |
67 | int i; | 67 | int retval; |
68 | u32 len; | ||
68 | 69 | ||
69 | i = affs_check_name(qstr->name, qstr->len, notruncate); | 70 | retval = affs_check_name(qstr->name, qstr->len, notruncate); |
70 | if (i) | 71 | if (retval) |
71 | return i; | 72 | return retval; |
72 | 73 | ||
73 | hash = init_name_hash(); | 74 | hash = init_name_hash(); |
74 | i = min(qstr->len, 30u); | 75 | len = min(qstr->len, 30u); |
75 | for (; i > 0; name++, i--) | 76 | for (; len > 0; name++, len--) |
76 | hash = partial_name_hash(toupper(*name), hash); | 77 | hash = partial_name_hash(toupper(*name), hash); |
77 | qstr->hash = end_name_hash(hash); | 78 | qstr->hash = end_name_hash(hash); |
78 | 79 | ||
@@ -173,7 +174,7 @@ int | |||
173 | affs_hash_name(struct super_block *sb, const u8 *name, unsigned int len) | 174 | affs_hash_name(struct super_block *sb, const u8 *name, unsigned int len) |
174 | { | 175 | { |
175 | toupper_t toupper = affs_get_toupper(sb); | 176 | toupper_t toupper = affs_get_toupper(sb); |
176 | int hash; | 177 | u32 hash; |
177 | 178 | ||
178 | hash = len = min(len, 30u); | 179 | hash = len = min(len, 30u); |
179 | for (; len > 0; len--) | 180 | for (; len > 0; len--) |