diff options
author | Ryan Desfosses <ryan@desfo.org> | 2014-04-18 20:13:50 -0400 |
---|---|---|
committer | Bjorn Helgaas <bhelgaas@google.com> | 2014-06-10 22:20:42 -0400 |
commit | 227f06470502c4fea3d93df1f12a77e3e37f6263 (patch) | |
tree | 817a80fa89d17305a47a3e4e4012d36ae6cac36c /drivers | |
parent | 3c78bc61f5ef3bc87e7f94f67ec737d2273f120b (diff) |
PCI: Merge multi-line quoted strings
Merge quoted strings that are broken across lines into a single entity.
The compiler merges them anyway, but checkpatch complains about it, and
merging them makes it easier to grep for strings.
No functional change.
[bhelgaas: changelog, do the same for everything under drivers/pci]
Signed-off-by: Ryan Desfosses <ryan@desfo.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'drivers')
28 files changed, 169 insertions, 249 deletions
diff --git a/drivers/pci/access.c b/drivers/pci/access.c index 8c148f39e8d7..d292d7cb3417 100644 --- a/drivers/pci/access.c +++ b/drivers/pci/access.c | |||
@@ -231,10 +231,7 @@ static int pci_vpd_pci22_wait(struct pci_dev *dev) | |||
231 | } | 231 | } |
232 | 232 | ||
233 | if (time_after(jiffies, timeout)) { | 233 | if (time_after(jiffies, timeout)) { |
234 | dev_printk(KERN_DEBUG, &dev->dev, | 234 | dev_printk(KERN_DEBUG, &dev->dev, "vpd r/w failed. This is likely a firmware bug on this device. Contact the card vendor for a firmware update\n"); |
235 | "vpd r/w failed. This is likely a firmware " | ||
236 | "bug on this device. Contact the card " | ||
237 | "vendor for a firmware update."); | ||
238 | return -ETIMEDOUT; | 235 | return -ETIMEDOUT; |
239 | } | 236 | } |
240 | if (fatal_signal_pending(current)) | 237 | if (fatal_signal_pending(current)) |
diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c index 8e06124aa80f..f7d3de32c9a0 100644 --- a/drivers/pci/host/pcie-rcar.c +++ b/drivers/pci/host/pcie-rcar.c | |||
@@ -277,9 +277,8 @@ static int rcar_pcie_read_conf(struct pci_bus *bus, unsigned int devfn, | |||
277 | else if (size == 2) | 277 | else if (size == 2) |
278 | *val = (*val >> (8 * (where & 2))) & 0xffff; | 278 | *val = (*val >> (8 * (where & 2))) & 0xffff; |
279 | 279 | ||
280 | dev_dbg(&bus->dev, "pcie-config-read: bus=%3d devfn=0x%04x " | 280 | dev_dbg(&bus->dev, "pcie-config-read: bus=%3d devfn=0x%04x where=0x%04x size=%d val=0x%08lx\n", |
281 | "where=0x%04x size=%d val=0x%08lx\n", bus->number, | 281 | bus->number, devfn, where, size, (unsigned long)*val); |
282 | devfn, where, size, (unsigned long)*val); | ||
283 | 282 | ||
284 | return ret; | 283 | return ret; |
285 | } | 284 | } |
@@ -302,9 +301,8 @@ static int rcar_pcie_write_conf(struct pci_bus *bus, unsigned int devfn, | |||
302 | if (ret != PCIBIOS_SUCCESSFUL) | 301 | if (ret != PCIBIOS_SUCCESSFUL) |
303 | return ret; | 302 | return ret; |
304 | 303 | ||
305 | dev_dbg(&bus->dev, "pcie-config-write: bus=%3d devfn=0x%04x " | 304 | dev_dbg(&bus->dev, "pcie-config-write: bus=%3d devfn=0x%04x where=0x%04x size=%d val=0x%08lx\n", |
306 | "where=0x%04x size=%d val=0x%08lx\n", bus->number, | 305 | bus->number, devfn, where, size, (unsigned long)val); |
307 | devfn, where, size, (unsigned long)val); | ||
308 | 306 | ||
309 | if (size == 1) { | 307 | if (size == 1) { |
310 | shift = 8 * (where & 3); | 308 | shift = 8 * (where & 3); |
diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c index 75e178330215..772d8766338a 100644 --- a/drivers/pci/hotplug/acpiphp_glue.c +++ b/drivers/pci/hotplug/acpiphp_glue.c | |||
@@ -351,11 +351,9 @@ static acpi_status acpiphp_add_context(acpi_handle handle, u32 lvl, void *data, | |||
351 | slot->slot = NULL; | 351 | slot->slot = NULL; |
352 | bridge->nr_slots--; | 352 | bridge->nr_slots--; |
353 | if (retval == -EBUSY) | 353 | if (retval == -EBUSY) |
354 | pr_warn("Slot %llu already registered by another " | 354 | pr_warn("Slot %llu already registered by another hotplug driver\n", sun); |
355 | "hotplug driver\n", sun); | ||
356 | else | 355 | else |
357 | pr_warn("acpiphp_register_hotplug_slot failed " | 356 | pr_warn("acpiphp_register_hotplug_slot failed (err code = 0x%x)\n", retval); |
358 | "(err code = 0x%x)\n", retval); | ||
359 | } | 357 | } |
360 | /* Even if the slot registration fails, we can still use it. */ | 358 | /* Even if the slot registration fails, we can still use it. */ |
361 | } | 359 | } |
diff --git a/drivers/pci/hotplug/cpqphp_core.c b/drivers/pci/hotplug/cpqphp_core.c index 868e62fc869b..4aaee746df88 100644 --- a/drivers/pci/hotplug/cpqphp_core.c +++ b/drivers/pci/hotplug/cpqphp_core.c | |||
@@ -706,8 +706,7 @@ static int ctrl_slot_setup(struct controller *ctrl, | |||
706 | hotplug_slot_info->adapter_status = | 706 | hotplug_slot_info->adapter_status = |
707 | get_presence_status(ctrl, slot); | 707 | get_presence_status(ctrl, slot); |
708 | 708 | ||
709 | dbg("registering bus %d, dev %d, number %d, " | 709 | dbg("registering bus %d, dev %d, number %d, ctrl->slot_device_offset %d, slot %d\n", |
710 | "ctrl->slot_device_offset %d, slot %d\n", | ||
711 | slot->bus, slot->device, | 710 | slot->bus, slot->device, |
712 | slot->number, ctrl->slot_device_offset, | 711 | slot->number, ctrl->slot_device_offset, |
713 | slot_number); | 712 | slot_number); |
@@ -837,8 +836,7 @@ static int cpqhpc_probe(struct pci_dev *pdev, const struct pci_device_id *ent) | |||
837 | 836 | ||
838 | bus = pdev->subordinate; | 837 | bus = pdev->subordinate; |
839 | if (!bus) { | 838 | if (!bus) { |
840 | dev_notice(&pdev->dev, "the device is not a bridge, " | 839 | dev_notice(&pdev->dev, "the device is not a bridge, skipping\n"); |
841 | "skipping\n"); | ||
842 | rc = -ENODEV; | 840 | rc = -ENODEV; |
843 | goto err_disable_device; | 841 | goto err_disable_device; |
844 | } | 842 | } |
diff --git a/drivers/pci/hotplug/ibmphp_core.c b/drivers/pci/hotplug/ibmphp_core.c index 5794057f7ec1..f7b8684a7739 100644 --- a/drivers/pci/hotplug/ibmphp_core.c +++ b/drivers/pci/hotplug/ibmphp_core.c | |||
@@ -1045,8 +1045,7 @@ static int enable_slot(struct hotplug_slot *hs) | |||
1045 | rc = check_limitations(slot_cur); | 1045 | rc = check_limitations(slot_cur); |
1046 | if (rc) { | 1046 | if (rc) { |
1047 | err("Adding this card exceeds the limitations of this bus.\n"); | 1047 | err("Adding this card exceeds the limitations of this bus.\n"); |
1048 | err("(i.e., >1 133MHz cards running on same bus, or " | 1048 | err("(i.e., >1 133MHz cards running on same bus, or >2 66 PCI cards running on same bus.\n"); |
1049 | ">2 66 PCI cards running on same bus.\n"); | ||
1050 | err("Try hot-adding into another bus\n"); | 1049 | err("Try hot-adding into another bus\n"); |
1051 | rc = -EINVAL; | 1050 | rc = -EINVAL; |
1052 | goto error_nopower; | 1051 | goto error_nopower; |
@@ -1070,12 +1069,10 @@ static int enable_slot(struct hotplug_slot *hs) | |||
1070 | !(SLOT_PWRGD(slot_cur->status))) | 1069 | !(SLOT_PWRGD(slot_cur->status))) |
1071 | err("power fault occurred trying to power up\n"); | 1070 | err("power fault occurred trying to power up\n"); |
1072 | else if (SLOT_BUS_SPEED(slot_cur->status)) { | 1071 | else if (SLOT_BUS_SPEED(slot_cur->status)) { |
1073 | err("bus speed mismatch occurred. please check " | 1072 | err("bus speed mismatch occurred. please check current bus speed and card capability\n"); |
1074 | "current bus speed and card capability\n"); | ||
1075 | print_card_capability(slot_cur); | 1073 | print_card_capability(slot_cur); |
1076 | } else if (SLOT_BUS_MODE(slot_cur->ext_status)) { | 1074 | } else if (SLOT_BUS_MODE(slot_cur->ext_status)) { |
1077 | err("bus mode mismatch occurred. please check " | 1075 | err("bus mode mismatch occurred. please check current bus mode and card capability\n"); |
1078 | "current bus mode and card capability\n"); | ||
1079 | print_card_capability(slot_cur); | 1076 | print_card_capability(slot_cur); |
1080 | } | 1077 | } |
1081 | ibmphp_update_slot_info(slot_cur); | 1078 | ibmphp_update_slot_info(slot_cur); |
@@ -1098,8 +1095,7 @@ static int enable_slot(struct hotplug_slot *hs) | |||
1098 | goto error_power; | 1095 | goto error_power; |
1099 | } | 1096 | } |
1100 | if (SLOT_POWER(slot_cur->status) && (SLOT_BUS_SPEED(slot_cur->status))) { | 1097 | if (SLOT_POWER(slot_cur->status) && (SLOT_BUS_SPEED(slot_cur->status))) { |
1101 | err("bus speed mismatch occurred. please check current bus " | 1098 | err("bus speed mismatch occurred. please check current bus speed and card capability\n"); |
1102 | "speed and card capability\n"); | ||
1103 | print_card_capability(slot_cur); | 1099 | print_card_capability(slot_cur); |
1104 | goto error_power; | 1100 | goto error_power; |
1105 | } | 1101 | } |
diff --git a/drivers/pci/hotplug/ibmphp_pci.c b/drivers/pci/hotplug/ibmphp_pci.c index f53b7c5b9a3f..2fd296706ce7 100644 --- a/drivers/pci/hotplug/ibmphp_pci.c +++ b/drivers/pci/hotplug/ibmphp_pci.c | |||
@@ -137,8 +137,8 @@ int ibmphp_configure_card (struct pci_func *func, u8 slotno) | |||
137 | "Please choose another device.\n", cur_func->device); | 137 | "Please choose another device.\n", cur_func->device); |
138 | return -ENODEV; | 138 | return -ENODEV; |
139 | } else if (class == PCI_CLASS_DISPLAY_VGA) { | 139 | } else if (class == PCI_CLASS_DISPLAY_VGA) { |
140 | err ("The device %x is not supported for hot plugging. " | 140 | err ("The device %x is not supported for hot plugging. Please choose another device.\n", |
141 | "Please choose another device.\n", cur_func->device); | 141 | cur_func->device); |
142 | return -ENODEV; | 142 | return -ENODEV; |
143 | } | 143 | } |
144 | switch (hdr_type) { | 144 | switch (hdr_type) { |
@@ -179,8 +179,8 @@ int ibmphp_configure_card (struct pci_func *func, u8 slotno) | |||
179 | case PCI_HEADER_TYPE_MULTIBRIDGE: | 179 | case PCI_HEADER_TYPE_MULTIBRIDGE: |
180 | class >>= 8; | 180 | class >>= 8; |
181 | if (class != PCI_CLASS_BRIDGE_PCI) { | 181 | if (class != PCI_CLASS_BRIDGE_PCI) { |
182 | err ("This %x is not PCI-to-PCI bridge, and as is not supported for hot-plugging. " | 182 | err ("This %x is not PCI-to-PCI bridge, and as is not supported for hot-plugging. Please insert another card.\n", |
183 | "Please insert another card.\n", cur_func->device); | 183 | cur_func->device); |
184 | return -ENODEV; | 184 | return -ENODEV; |
185 | } | 185 | } |
186 | assign_alt_irq (cur_func, class_code); | 186 | assign_alt_irq (cur_func, class_code); |
@@ -247,8 +247,8 @@ int ibmphp_configure_card (struct pci_func *func, u8 slotno) | |||
247 | class >>= 8; | 247 | class >>= 8; |
248 | debug ("class now is %x\n", class); | 248 | debug ("class now is %x\n", class); |
249 | if (class != PCI_CLASS_BRIDGE_PCI) { | 249 | if (class != PCI_CLASS_BRIDGE_PCI) { |
250 | err ("This %x is not PCI-to-PCI bridge, and as is not supported for hot-plugging. " | 250 | err ("This %x is not PCI-to-PCI bridge, and as is not supported for hot-plugging. Please insert another card.\n", |
251 | "Please insert another card.\n", cur_func->device); | 251 | cur_func->device); |
252 | return -ENODEV; | 252 | return -ENODEV; |
253 | } | 253 | } |
254 | 254 | ||
@@ -1125,13 +1125,11 @@ static struct res_needed *scan_behind_bridge (struct pci_func *func, u8 busno) | |||
1125 | 1125 | ||
1126 | class >>= 8; /* to take revision out, class = class.subclass.prog i/f */ | 1126 | class >>= 8; /* to take revision out, class = class.subclass.prog i/f */ |
1127 | if (class == PCI_CLASS_NOT_DEFINED_VGA) { | 1127 | if (class == PCI_CLASS_NOT_DEFINED_VGA) { |
1128 | err ("The device %x is VGA compatible and as is not supported for hot plugging. " | 1128 | err ("The device %x is VGA compatible and as is not supported for hot plugging. Please choose another device.\n", device); |
1129 | "Please choose another device.\n", device); | ||
1130 | amount->not_correct = 1; | 1129 | amount->not_correct = 1; |
1131 | return amount; | 1130 | return amount; |
1132 | } else if (class == PCI_CLASS_DISPLAY_VGA) { | 1131 | } else if (class == PCI_CLASS_DISPLAY_VGA) { |
1133 | err ("The device %x is not supported for hot plugging. " | 1132 | err ("The device %x is not supported for hot plugging. Please choose another device.\n", device); |
1134 | "Please choose another device.\n", device); | ||
1135 | amount->not_correct = 1; | 1133 | amount->not_correct = 1; |
1136 | return amount; | 1134 | return amount; |
1137 | } | 1135 | } |
@@ -1483,12 +1481,10 @@ static int unconfigure_boot_card (struct slot *slot_cur) | |||
1483 | debug ("hdr_type %x, class %x\n", hdr_type, class); | 1481 | debug ("hdr_type %x, class %x\n", hdr_type, class); |
1484 | class >>= 8; /* to take revision out, class = class.subclass.prog i/f */ | 1482 | class >>= 8; /* to take revision out, class = class.subclass.prog i/f */ |
1485 | if (class == PCI_CLASS_NOT_DEFINED_VGA) { | 1483 | if (class == PCI_CLASS_NOT_DEFINED_VGA) { |
1486 | err ("The device %x function %x is VGA compatible and is not supported for hot removing. " | 1484 | err ("The device %x function %x is VGA compatible and is not supported for hot removing. Please choose another device.\n", device, function); |
1487 | "Please choose another device.\n", device, function); | ||
1488 | return -ENODEV; | 1485 | return -ENODEV; |
1489 | } else if (class == PCI_CLASS_DISPLAY_VGA) { | 1486 | } else if (class == PCI_CLASS_DISPLAY_VGA) { |
1490 | err ("The device %x function %x is not supported for hot removing. " | 1487 | err ("The device %x function %x is not supported for hot removing. Please choose another device.\n", device, function); |
1491 | "Please choose another device.\n", device, function); | ||
1492 | return -ENODEV; | 1488 | return -ENODEV; |
1493 | } | 1489 | } |
1494 | 1490 | ||
@@ -1513,9 +1509,7 @@ static int unconfigure_boot_card (struct slot *slot_cur) | |||
1513 | case PCI_HEADER_TYPE_BRIDGE: | 1509 | case PCI_HEADER_TYPE_BRIDGE: |
1514 | class >>= 8; | 1510 | class >>= 8; |
1515 | if (class != PCI_CLASS_BRIDGE_PCI) { | 1511 | if (class != PCI_CLASS_BRIDGE_PCI) { |
1516 | err ("This device %x function %x is not PCI-to-PCI bridge, " | 1512 | err ("This device %x function %x is not PCI-to-PCI bridge, and is not supported for hot-removing. Please try another card.\n", device, function); |
1517 | "and is not supported for hot-removing. " | ||
1518 | "Please try another card.\n", device, function); | ||
1519 | return -ENODEV; | 1513 | return -ENODEV; |
1520 | } | 1514 | } |
1521 | rc = unconfigure_boot_bridge (busno, device, function); | 1515 | rc = unconfigure_boot_bridge (busno, device, function); |
@@ -1529,9 +1523,7 @@ static int unconfigure_boot_card (struct slot *slot_cur) | |||
1529 | case PCI_HEADER_TYPE_MULTIBRIDGE: | 1523 | case PCI_HEADER_TYPE_MULTIBRIDGE: |
1530 | class >>= 8; | 1524 | class >>= 8; |
1531 | if (class != PCI_CLASS_BRIDGE_PCI) { | 1525 | if (class != PCI_CLASS_BRIDGE_PCI) { |
1532 | err ("This device %x function %x is not PCI-to-PCI bridge, " | 1526 | err ("This device %x function %x is not PCI-to-PCI bridge, and is not supported for hot-removing. Please try another card.\n", device, function); |
1533 | "and is not supported for hot-removing. " | ||
1534 | "Please try another card.\n", device, function); | ||
1535 | return -ENODEV; | 1527 | return -ENODEV; |
1536 | } | 1528 | } |
1537 | rc = unconfigure_boot_bridge (busno, device, function); | 1529 | rc = unconfigure_boot_bridge (busno, device, function); |
diff --git a/drivers/pci/hotplug/ibmphp_res.c b/drivers/pci/hotplug/ibmphp_res.c index f62dfc40f753..f34745abd5b6 100644 --- a/drivers/pci/hotplug/ibmphp_res.c +++ b/drivers/pci/hotplug/ibmphp_res.c | |||
@@ -789,8 +789,7 @@ int ibmphp_remove_resource (struct resource_node *res) | |||
789 | bus_cur = find_bus_wprev (res->busno, NULL, 0); | 789 | bus_cur = find_bus_wprev (res->busno, NULL, 0); |
790 | 790 | ||
791 | if (!bus_cur) { | 791 | if (!bus_cur) { |
792 | err ("cannot find corresponding bus of the io resource to remove " | 792 | err ("cannot find corresponding bus of the io resource to remove bailing out...\n"); |
793 | "bailing out...\n"); | ||
794 | return -ENODEV; | 793 | return -ENODEV; |
795 | } | 794 | } |
796 | 795 | ||
diff --git a/drivers/pci/hotplug/pci_hotplug_core.c b/drivers/pci/hotplug/pci_hotplug_core.c index 29caef96a21c..56d8486dc167 100644 --- a/drivers/pci/hotplug/pci_hotplug_core.c +++ b/drivers/pci/hotplug/pci_hotplug_core.c | |||
@@ -432,8 +432,7 @@ int __pci_hp_register(struct hotplug_slot *slot, struct pci_bus *bus, | |||
432 | if ((slot->info == NULL) || (slot->ops == NULL)) | 432 | if ((slot->info == NULL) || (slot->ops == NULL)) |
433 | return -EINVAL; | 433 | return -EINVAL; |
434 | if (slot->release == NULL) { | 434 | if (slot->release == NULL) { |
435 | dbg("Why are you trying to register a hotplug slot " | 435 | dbg("Why are you trying to register a hotplug slot without a proper release function?\n"); |
436 | "without a proper release function?\n"); | ||
437 | return -EINVAL; | 436 | return -EINVAL; |
438 | } | 437 | } |
439 | 438 | ||
diff --git a/drivers/pci/hotplug/pciehp_core.c b/drivers/pci/hotplug/pciehp_core.c index 96bb617e4de5..a2297db80813 100644 --- a/drivers/pci/hotplug/pciehp_core.c +++ b/drivers/pci/hotplug/pciehp_core.c | |||
@@ -266,8 +266,7 @@ static int pciehp_probe(struct pcie_device *dev) | |||
266 | rc = init_slot(ctrl); | 266 | rc = init_slot(ctrl); |
267 | if (rc) { | 267 | if (rc) { |
268 | if (rc == -EBUSY) | 268 | if (rc == -EBUSY) |
269 | ctrl_warn(ctrl, "Slot already registered by another " | 269 | ctrl_warn(ctrl, "Slot already registered by another hotplug driver\n"); |
270 | "hotplug driver\n"); | ||
271 | else | 270 | else |
272 | ctrl_err(ctrl, "Slot initialization failed\n"); | 271 | ctrl_err(ctrl, "Slot initialization failed\n"); |
273 | goto err_out_release_ctlr; | 272 | goto err_out_release_ctlr; |
diff --git a/drivers/pci/hotplug/pciehp_ctrl.c b/drivers/pci/hotplug/pciehp_ctrl.c index c57463e1d756..ff32e85e1de6 100644 --- a/drivers/pci/hotplug/pciehp_ctrl.c +++ b/drivers/pci/hotplug/pciehp_ctrl.c | |||
@@ -376,14 +376,12 @@ static void handle_button_press_event(struct slot *p_slot) | |||
376 | pciehp_get_power_status(p_slot, &getstatus); | 376 | pciehp_get_power_status(p_slot, &getstatus); |
377 | if (getstatus) { | 377 | if (getstatus) { |
378 | p_slot->state = BLINKINGOFF_STATE; | 378 | p_slot->state = BLINKINGOFF_STATE; |
379 | ctrl_info(ctrl, | 379 | ctrl_info(ctrl, "PCI slot #%s - powering off due to button press\n", |
380 | "PCI slot #%s - powering off due to button " | 380 | slot_name(p_slot)); |
381 | "press.\n", slot_name(p_slot)); | ||
382 | } else { | 381 | } else { |
383 | p_slot->state = BLINKINGON_STATE; | 382 | p_slot->state = BLINKINGON_STATE; |
384 | ctrl_info(ctrl, | 383 | ctrl_info(ctrl, "PCI slot #%s - powering on due to button press\n", |
385 | "PCI slot #%s - powering on due to button " | 384 | slot_name(p_slot)); |
386 | "press.\n", slot_name(p_slot)); | ||
387 | } | 385 | } |
388 | /* blink green LED and turn off amber */ | 386 | /* blink green LED and turn off amber */ |
389 | pciehp_green_led_blink(p_slot); | 387 | pciehp_green_led_blink(p_slot); |
@@ -404,8 +402,8 @@ static void handle_button_press_event(struct slot *p_slot) | |||
404 | else | 402 | else |
405 | pciehp_green_led_off(p_slot); | 403 | pciehp_green_led_off(p_slot); |
406 | pciehp_set_attention_status(p_slot, 0); | 404 | pciehp_set_attention_status(p_slot, 0); |
407 | ctrl_info(ctrl, "PCI slot #%s - action canceled " | 405 | ctrl_info(ctrl, "PCI slot #%s - action canceled due to button press\n", |
408 | "due to button press\n", slot_name(p_slot)); | 406 | slot_name(p_slot)); |
409 | p_slot->state = STATIC_STATE; | 407 | p_slot->state = STATIC_STATE; |
410 | break; | 408 | break; |
411 | case POWEROFF_STATE: | 409 | case POWEROFF_STATE: |
diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c index 9334fc76b9d1..42914e04d110 100644 --- a/drivers/pci/hotplug/pciehp_hpc.c +++ b/drivers/pci/hotplug/pciehp_hpc.c | |||
@@ -174,12 +174,10 @@ static void pcie_write_cmd(struct controller *ctrl, u16 cmd, u16 mask) | |||
174 | * event even though it supports none of power | 174 | * event even though it supports none of power |
175 | * controller, attention led, power led and EMI. | 175 | * controller, attention led, power led and EMI. |
176 | */ | 176 | */ |
177 | ctrl_dbg(ctrl, "Unexpected CMD_COMPLETED. Need to " | 177 | ctrl_dbg(ctrl, "Unexpected CMD_COMPLETED. Need to wait for command completed event\n"); |
178 | "wait for command completed event.\n"); | ||
179 | ctrl->no_cmd_complete = 0; | 178 | ctrl->no_cmd_complete = 0; |
180 | } else { | 179 | } else { |
181 | ctrl_dbg(ctrl, "Unexpected CMD_COMPLETED. Maybe " | 180 | ctrl_dbg(ctrl, "Unexpected CMD_COMPLETED. Maybe the controller is broken\n"); |
182 | "the controller is broken.\n"); | ||
183 | } | 181 | } |
184 | } | 182 | } |
185 | 183 | ||
diff --git a/drivers/pci/hotplug/pciehp_pci.c b/drivers/pci/hotplug/pciehp_pci.c index b6cb1df67097..5f871f4c4af1 100644 --- a/drivers/pci/hotplug/pciehp_pci.c +++ b/drivers/pci/hotplug/pciehp_pci.c | |||
@@ -46,9 +46,8 @@ int pciehp_configure_device(struct slot *p_slot) | |||
46 | 46 | ||
47 | dev = pci_get_slot(parent, PCI_DEVFN(0, 0)); | 47 | dev = pci_get_slot(parent, PCI_DEVFN(0, 0)); |
48 | if (dev) { | 48 | if (dev) { |
49 | ctrl_err(ctrl, "Device %s already exists " | 49 | ctrl_err(ctrl, "Device %s already exists at %04x:%02x:00, cannot hot-add\n", |
50 | "at %04x:%02x:00, cannot hot-add\n", pci_name(dev), | 50 | pci_name(dev), pci_domain_nr(parent), parent->number); |
51 | pci_domain_nr(parent), parent->number); | ||
52 | pci_dev_put(dev); | 51 | pci_dev_put(dev); |
53 | ret = -EEXIST; | 52 | ret = -EEXIST; |
54 | goto out; | 53 | goto out; |
diff --git a/drivers/pci/hotplug/sgi_hotplug.c b/drivers/pci/hotplug/sgi_hotplug.c index 0f4c36033ade..bada20999870 100644 --- a/drivers/pci/hotplug/sgi_hotplug.c +++ b/drivers/pci/hotplug/sgi_hotplug.c | |||
@@ -250,15 +250,13 @@ static int sn_slot_enable(struct hotplug_slot *bss_hotplug_slot, | |||
250 | } | 250 | } |
251 | 251 | ||
252 | if (rc == PCI_L1_ERR) { | 252 | if (rc == PCI_L1_ERR) { |
253 | dev_dbg(&slot->pci_bus->self->dev, | 253 | dev_dbg(&slot->pci_bus->self->dev, "L1 failure %d with message: %s", |
254 | "L1 failure %d with message: %s", | ||
255 | resp.resp_sub_errno, resp.resp_l1_msg); | 254 | resp.resp_sub_errno, resp.resp_l1_msg); |
256 | return -EPERM; | 255 | return -EPERM; |
257 | } | 256 | } |
258 | 257 | ||
259 | if (rc) { | 258 | if (rc) { |
260 | dev_dbg(&slot->pci_bus->self->dev, | 259 | dev_dbg(&slot->pci_bus->self->dev, "insert failed with error %d sub-error %d\n", |
261 | "insert failed with error %d sub-error %d\n", | ||
262 | rc, resp.resp_sub_errno); | 260 | rc, resp.resp_sub_errno); |
263 | return -EIO; | 261 | return -EIO; |
264 | } | 262 | } |
@@ -288,21 +286,18 @@ static int sn_slot_disable(struct hotplug_slot *bss_hotplug_slot, | |||
288 | } | 286 | } |
289 | 287 | ||
290 | if ((action == PCI_REQ_SLOT_ELIGIBLE) && (rc == PCI_EMPTY_33MHZ)) { | 288 | if ((action == PCI_REQ_SLOT_ELIGIBLE) && (rc == PCI_EMPTY_33MHZ)) { |
291 | dev_dbg(&slot->pci_bus->self->dev, | 289 | dev_dbg(&slot->pci_bus->self->dev, "Cannot remove last 33MHz card\n"); |
292 | "Cannot remove last 33MHz card\n"); | ||
293 | return -EPERM; | 290 | return -EPERM; |
294 | } | 291 | } |
295 | 292 | ||
296 | if ((action == PCI_REQ_SLOT_ELIGIBLE) && (rc == PCI_L1_ERR)) { | 293 | if ((action == PCI_REQ_SLOT_ELIGIBLE) && (rc == PCI_L1_ERR)) { |
297 | dev_dbg(&slot->pci_bus->self->dev, | 294 | dev_dbg(&slot->pci_bus->self->dev, "L1 failure %d with message \n%s\n", |
298 | "L1 failure %d with message \n%s\n", | ||
299 | resp.resp_sub_errno, resp.resp_l1_msg); | 295 | resp.resp_sub_errno, resp.resp_l1_msg); |
300 | return -EPERM; | 296 | return -EPERM; |
301 | } | 297 | } |
302 | 298 | ||
303 | if ((action == PCI_REQ_SLOT_ELIGIBLE) && rc) { | 299 | if ((action == PCI_REQ_SLOT_ELIGIBLE) && rc) { |
304 | dev_dbg(&slot->pci_bus->self->dev, | 300 | dev_dbg(&slot->pci_bus->self->dev, "remove failed with error %d sub-error %d\n", |
305 | "remove failed with error %d sub-error %d\n", | ||
306 | rc, resp.resp_sub_errno); | 301 | rc, resp.resp_sub_errno); |
307 | return -EIO; | 302 | return -EIO; |
308 | } | 303 | } |
@@ -417,8 +412,7 @@ static int enable_slot(struct hotplug_slot *bss_hotplug_slot) | |||
417 | phandle = acpi_device_handle(PCI_CONTROLLER(slot->pci_bus)->companion); | 412 | phandle = acpi_device_handle(PCI_CONTROLLER(slot->pci_bus)->companion); |
418 | 413 | ||
419 | if (acpi_bus_get_device(phandle, &pdevice)) { | 414 | if (acpi_bus_get_device(phandle, &pdevice)) { |
420 | dev_dbg(&slot->pci_bus->self->dev, | 415 | dev_dbg(&slot->pci_bus->self->dev, "no parent device, assuming NULL\n"); |
421 | "no parent device, assuming NULL\n"); | ||
422 | pdevice = NULL; | 416 | pdevice = NULL; |
423 | } | 417 | } |
424 | 418 | ||
@@ -447,10 +441,8 @@ static int enable_slot(struct hotplug_slot *bss_hotplug_slot) | |||
447 | 441 | ||
448 | ret = acpi_bus_scan(chandle); | 442 | ret = acpi_bus_scan(chandle); |
449 | if (ACPI_FAILURE(ret)) { | 443 | if (ACPI_FAILURE(ret)) { |
450 | printk(KERN_ERR "%s: acpi_bus_scan " | 444 | printk(KERN_ERR "%s: acpi_bus_scan failed (0x%x) for slot %d func %d\n", |
451 | "failed (0x%x) for slot %d " | 445 | __func__, ret, (int)(adr>>16), |
452 | "func %d\n", __func__, | ||
453 | ret, (int)(adr>>16), | ||
454 | (int)(adr&0xffff)); | 446 | (int)(adr&0xffff)); |
455 | /* try to continue on */ | 447 | /* try to continue on */ |
456 | } | 448 | } |
@@ -471,11 +463,9 @@ static int enable_slot(struct hotplug_slot *bss_hotplug_slot) | |||
471 | mutex_unlock(&sn_hotplug_mutex); | 463 | mutex_unlock(&sn_hotplug_mutex); |
472 | 464 | ||
473 | if (rc == 0) | 465 | if (rc == 0) |
474 | dev_dbg(&slot->pci_bus->self->dev, | 466 | dev_dbg(&slot->pci_bus->self->dev, "insert operation successful\n"); |
475 | "insert operation successful\n"); | ||
476 | else | 467 | else |
477 | dev_dbg(&slot->pci_bus->self->dev, | 468 | dev_dbg(&slot->pci_bus->self->dev, "insert operation failed rc = %d\n", rc); |
478 | "insert operation failed rc = %d\n", rc); | ||
479 | 469 | ||
480 | return rc; | 470 | return rc; |
481 | } | 471 | } |
@@ -561,8 +551,7 @@ static int disable_slot(struct hotplug_slot *bss_hotplug_slot) | |||
561 | acpi_status ret; | 551 | acpi_status ret; |
562 | ret = acpi_unload_table_id(ssdt_id); | 552 | ret = acpi_unload_table_id(ssdt_id); |
563 | if (ACPI_FAILURE(ret)) { | 553 | if (ACPI_FAILURE(ret)) { |
564 | printk(KERN_ERR "%s: acpi_unload_table_id " | 554 | printk(KERN_ERR "%s: acpi_unload_table_id failed (0x%x) for id %d\n", |
565 | "failed (0x%x) for id %d\n", | ||
566 | __func__, ret, ssdt_id); | 555 | __func__, ret, ssdt_id); |
567 | /* try to continue on */ | 556 | /* try to continue on */ |
568 | } | 557 | } |
diff --git a/drivers/pci/hotplug/shpchp_core.c b/drivers/pci/hotplug/shpchp_core.c index faf13abd5b99..294ef4b10cf1 100644 --- a/drivers/pci/hotplug/shpchp_core.c +++ b/drivers/pci/hotplug/shpchp_core.c | |||
@@ -143,8 +143,7 @@ static int init_slots(struct controller *ctrl) | |||
143 | snprintf(name, SLOT_NAME_SIZE, "%d", slot->number); | 143 | snprintf(name, SLOT_NAME_SIZE, "%d", slot->number); |
144 | hotplug_slot->ops = &shpchp_hotplug_slot_ops; | 144 | hotplug_slot->ops = &shpchp_hotplug_slot_ops; |
145 | 145 | ||
146 | ctrl_dbg(ctrl, "Registering domain:bus:dev=%04x:%02x:%02x " | 146 | ctrl_dbg(ctrl, "Registering domain:bus:dev=%04x:%02x:%02x hp_slot=%x sun=%x slot_device_offset=%x\n", |
147 | "hp_slot=%x sun=%x slot_device_offset=%x\n", | ||
148 | pci_domain_nr(ctrl->pci_dev->subordinate), | 147 | pci_domain_nr(ctrl->pci_dev->subordinate), |
149 | slot->bus, slot->device, slot->hp_slot, slot->number, | 148 | slot->bus, slot->device, slot->hp_slot, slot->number, |
150 | ctrl->slot_device_offset); | 149 | ctrl->slot_device_offset); |
diff --git a/drivers/pci/hotplug/shpchp_ctrl.c b/drivers/pci/hotplug/shpchp_ctrl.c index 90cd75c1a3a7..e57972366c91 100644 --- a/drivers/pci/hotplug/shpchp_ctrl.c +++ b/drivers/pci/hotplug/shpchp_ctrl.c | |||
@@ -196,8 +196,8 @@ static int change_bus_speed(struct controller *ctrl, struct slot *p_slot, | |||
196 | 196 | ||
197 | ctrl_dbg(ctrl, "Change speed to %d\n", speed); | 197 | ctrl_dbg(ctrl, "Change speed to %d\n", speed); |
198 | if ((rc = p_slot->hpc_ops->set_bus_speed_mode(p_slot, speed))) { | 198 | if ((rc = p_slot->hpc_ops->set_bus_speed_mode(p_slot, speed))) { |
199 | ctrl_err(ctrl, "%s: Issue of set bus speed mode command " | 199 | ctrl_err(ctrl, "%s: Issue of set bus speed mode command failed\n", |
200 | "failed\n", __func__); | 200 | __func__); |
201 | return WRONG_BUS_FREQUENCY; | 201 | return WRONG_BUS_FREQUENCY; |
202 | } | 202 | } |
203 | return rc; | 203 | return rc; |
@@ -215,8 +215,8 @@ static int fix_bus_speed(struct controller *ctrl, struct slot *pslot, | |||
215 | */ | 215 | */ |
216 | if (flag) { | 216 | if (flag) { |
217 | if (asp < bsp) { | 217 | if (asp < bsp) { |
218 | ctrl_err(ctrl, "Speed of bus %x and adapter %x " | 218 | ctrl_err(ctrl, "Speed of bus %x and adapter %x mismatch\n", |
219 | "mismatch\n", bsp, asp); | 219 | bsp, asp); |
220 | rc = WRONG_BUS_FREQUENCY; | 220 | rc = WRONG_BUS_FREQUENCY; |
221 | } | 221 | } |
222 | return rc; | 222 | return rc; |
@@ -250,8 +250,7 @@ static int board_added(struct slot *p_slot) | |||
250 | 250 | ||
251 | hp_slot = p_slot->device - ctrl->slot_device_offset; | 251 | hp_slot = p_slot->device - ctrl->slot_device_offset; |
252 | 252 | ||
253 | ctrl_dbg(ctrl, | 253 | ctrl_dbg(ctrl, "%s: p_slot->device, slot_offset, hp_slot = %d, %d ,%d\n", |
254 | "%s: p_slot->device, slot_offset, hp_slot = %d, %d ,%d\n", | ||
255 | __func__, p_slot->device, ctrl->slot_device_offset, hp_slot); | 254 | __func__, p_slot->device, ctrl->slot_device_offset, hp_slot); |
256 | 255 | ||
257 | /* Power on slot without connecting to bus */ | 256 | /* Power on slot without connecting to bus */ |
@@ -263,8 +262,8 @@ static int board_added(struct slot *p_slot) | |||
263 | 262 | ||
264 | if ((ctrl->pci_dev->vendor == 0x8086) && (ctrl->pci_dev->device == 0x0332)) { | 263 | if ((ctrl->pci_dev->vendor == 0x8086) && (ctrl->pci_dev->device == 0x0332)) { |
265 | if ((rc = p_slot->hpc_ops->set_bus_speed_mode(p_slot, PCI_SPEED_33MHz))) { | 264 | if ((rc = p_slot->hpc_ops->set_bus_speed_mode(p_slot, PCI_SPEED_33MHz))) { |
266 | ctrl_err(ctrl, "%s: Issue of set bus speed mode command" | 265 | ctrl_err(ctrl, "%s: Issue of set bus speed mode command failed\n", |
267 | " failed\n", __func__); | 266 | __func__); |
268 | return WRONG_BUS_FREQUENCY; | 267 | return WRONG_BUS_FREQUENCY; |
269 | } | 268 | } |
270 | 269 | ||
@@ -277,8 +276,7 @@ static int board_added(struct slot *p_slot) | |||
277 | 276 | ||
278 | rc = p_slot->hpc_ops->get_adapter_speed(p_slot, &asp); | 277 | rc = p_slot->hpc_ops->get_adapter_speed(p_slot, &asp); |
279 | if (rc) { | 278 | if (rc) { |
280 | ctrl_err(ctrl, "Can't get adapter speed or " | 279 | ctrl_err(ctrl, "Can't get adapter speed or bus mode mismatch\n"); |
281 | "bus mode mismatch\n"); | ||
282 | return WRONG_BUS_FREQUENCY; | 280 | return WRONG_BUS_FREQUENCY; |
283 | } | 281 | } |
284 | 282 | ||
@@ -289,8 +287,8 @@ static int board_added(struct slot *p_slot) | |||
289 | if (!list_empty(&ctrl->pci_dev->subordinate->devices)) | 287 | if (!list_empty(&ctrl->pci_dev->subordinate->devices)) |
290 | slots_not_empty = 1; | 288 | slots_not_empty = 1; |
291 | 289 | ||
292 | ctrl_dbg(ctrl, "%s: slots_not_empty %d, adapter_speed %d, bus_speed %d," | 290 | ctrl_dbg(ctrl, "%s: slots_not_empty %d, adapter_speed %d, bus_speed %d, max_bus_speed %d\n", |
293 | " max_bus_speed %d\n", __func__, slots_not_empty, asp, | 291 | __func__, slots_not_empty, asp, |
294 | bsp, msp); | 292 | bsp, msp); |
295 | 293 | ||
296 | rc = fix_bus_speed(ctrl, p_slot, slots_not_empty, asp, bsp, msp); | 294 | rc = fix_bus_speed(ctrl, p_slot, slots_not_empty, asp, bsp, msp); |
@@ -490,12 +488,12 @@ static void handle_button_press_event(struct slot *p_slot) | |||
490 | p_slot->hpc_ops->get_power_status(p_slot, &getstatus); | 488 | p_slot->hpc_ops->get_power_status(p_slot, &getstatus); |
491 | if (getstatus) { | 489 | if (getstatus) { |
492 | p_slot->state = BLINKINGOFF_STATE; | 490 | p_slot->state = BLINKINGOFF_STATE; |
493 | ctrl_info(ctrl, "PCI slot #%s - powering off due to " | 491 | ctrl_info(ctrl, "PCI slot #%s - powering off due to button press\n", |
494 | "button press.\n", slot_name(p_slot)); | 492 | slot_name(p_slot)); |
495 | } else { | 493 | } else { |
496 | p_slot->state = BLINKINGON_STATE; | 494 | p_slot->state = BLINKINGON_STATE; |
497 | ctrl_info(ctrl, "PCI slot #%s - powering on due to " | 495 | ctrl_info(ctrl, "PCI slot #%s - powering on due to button press\n", |
498 | "button press.\n", slot_name(p_slot)); | 496 | slot_name(p_slot)); |
499 | } | 497 | } |
500 | /* blink green LED and turn off amber */ | 498 | /* blink green LED and turn off amber */ |
501 | p_slot->hpc_ops->green_led_blink(p_slot); | 499 | p_slot->hpc_ops->green_led_blink(p_slot); |
@@ -518,8 +516,8 @@ static void handle_button_press_event(struct slot *p_slot) | |||
518 | else | 516 | else |
519 | p_slot->hpc_ops->green_led_off(p_slot); | 517 | p_slot->hpc_ops->green_led_off(p_slot); |
520 | p_slot->hpc_ops->set_attention_status(p_slot, 0); | 518 | p_slot->hpc_ops->set_attention_status(p_slot, 0); |
521 | ctrl_info(ctrl, "PCI slot #%s - action canceled due to " | 519 | ctrl_info(ctrl, "PCI slot #%s - action canceled due to button press\n", |
522 | "button press\n", slot_name(p_slot)); | 520 | slot_name(p_slot)); |
523 | p_slot->state = STATIC_STATE; | 521 | p_slot->state = STATIC_STATE; |
524 | break; | 522 | break; |
525 | case POWEROFF_STATE: | 523 | case POWEROFF_STATE: |
diff --git a/drivers/pci/hotplug/shpchp_hpc.c b/drivers/pci/hotplug/shpchp_hpc.c index 12aa9e2b78aa..29e22352822c 100644 --- a/drivers/pci/hotplug/shpchp_hpc.c +++ b/drivers/pci/hotplug/shpchp_hpc.c | |||
@@ -341,8 +341,7 @@ static int shpc_write_cmd(struct slot *slot, u8 t_slot, u8 cmd) | |||
341 | 341 | ||
342 | cmd_status = hpc_check_cmd_status(slot->ctrl); | 342 | cmd_status = hpc_check_cmd_status(slot->ctrl); |
343 | if (cmd_status) { | 343 | if (cmd_status) { |
344 | ctrl_err(ctrl, | 344 | ctrl_err(ctrl, "Failed to issued command 0x%x (error code = %d)\n", |
345 | "Failed to issued command 0x%x (error code = %d)\n", | ||
346 | cmd, cmd_status); | 345 | cmd, cmd_status); |
347 | retval = -EIO; | 346 | retval = -EIO; |
348 | } | 347 | } |
@@ -974,8 +973,8 @@ int shpc_init(struct controller *ctrl, struct pci_dev *pdev) | |||
974 | for (i = 0; i < 9 + num_slots; i++) { | 973 | for (i = 0; i < 9 + num_slots; i++) { |
975 | rc = shpc_indirect_read(ctrl, i, &tempdword); | 974 | rc = shpc_indirect_read(ctrl, i, &tempdword); |
976 | if (rc) { | 975 | if (rc) { |
977 | ctrl_err(ctrl, | 976 | ctrl_err(ctrl, "Cannot read creg (index = %d)\n", |
978 | "Cannot read creg (index = %d)\n", i); | 977 | i); |
979 | goto abort; | 978 | goto abort; |
980 | } | 979 | } |
981 | ctrl_dbg(ctrl, " offset %d: value %x\n", i, tempdword); | 980 | ctrl_dbg(ctrl, " offset %d: value %x\n", i, tempdword); |
@@ -1060,10 +1059,8 @@ int shpc_init(struct controller *ctrl, struct pci_dev *pdev) | |||
1060 | /* Installs the interrupt handler */ | 1059 | /* Installs the interrupt handler */ |
1061 | rc = pci_enable_msi(pdev); | 1060 | rc = pci_enable_msi(pdev); |
1062 | if (rc) { | 1061 | if (rc) { |
1063 | ctrl_info(ctrl, | 1062 | ctrl_info(ctrl, "Can't get msi for the hotplug controller\n"); |
1064 | "Can't get msi for the hotplug controller\n"); | 1063 | ctrl_info(ctrl, "Use INTx for the hotplug controller\n"); |
1065 | ctrl_info(ctrl, | ||
1066 | "Use INTx for the hotplug controller\n"); | ||
1067 | } | 1064 | } |
1068 | 1065 | ||
1069 | rc = request_irq(ctrl->pci_dev->irq, shpc_isr, IRQF_SHARED, | 1066 | rc = request_irq(ctrl->pci_dev->irq, shpc_isr, IRQF_SHARED, |
@@ -1071,8 +1068,8 @@ int shpc_init(struct controller *ctrl, struct pci_dev *pdev) | |||
1071 | ctrl_dbg(ctrl, "request_irq %d (returns %d)\n", | 1068 | ctrl_dbg(ctrl, "request_irq %d (returns %d)\n", |
1072 | ctrl->pci_dev->irq, rc); | 1069 | ctrl->pci_dev->irq, rc); |
1073 | if (rc) { | 1070 | if (rc) { |
1074 | ctrl_err(ctrl, "Can't get irq %d for the hotplug " | 1071 | ctrl_err(ctrl, "Can't get irq %d for the hotplug controller\n", |
1075 | "controller\n", ctrl->pci_dev->irq); | 1072 | ctrl->pci_dev->irq); |
1076 | goto abort_iounmap; | 1073 | goto abort_iounmap; |
1077 | } | 1074 | } |
1078 | } | 1075 | } |
diff --git a/drivers/pci/hotplug/shpchp_pci.c b/drivers/pci/hotplug/shpchp_pci.c index 9202d133485c..469454e0cc48 100644 --- a/drivers/pci/hotplug/shpchp_pci.c +++ b/drivers/pci/hotplug/shpchp_pci.c | |||
@@ -46,9 +46,9 @@ int shpchp_configure_device(struct slot *p_slot) | |||
46 | 46 | ||
47 | dev = pci_get_slot(parent, PCI_DEVFN(p_slot->device, 0)); | 47 | dev = pci_get_slot(parent, PCI_DEVFN(p_slot->device, 0)); |
48 | if (dev) { | 48 | if (dev) { |
49 | ctrl_err(ctrl, "Device %s already exists " | 49 | ctrl_err(ctrl, "Device %s already exists at %04x:%02x:%02x, cannot hot-add\n", |
50 | "at %04x:%02x:%02x, cannot hot-add\n", pci_name(dev), | 50 | pci_name(dev), pci_domain_nr(parent), |
51 | pci_domain_nr(parent), p_slot->bus, p_slot->device); | 51 | p_slot->bus, p_slot->device); |
52 | pci_dev_put(dev); | 52 | pci_dev_put(dev); |
53 | ret = -EINVAL; | 53 | ret = -EINVAL; |
54 | goto out; | 54 | goto out; |
diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index 27a7e67ddfe4..5a68b485e547 100644 --- a/drivers/pci/msi.c +++ b/drivers/pci/msi.c | |||
@@ -980,8 +980,7 @@ int pci_enable_msix(struct pci_dev *dev, struct msix_entry *entries, int nvec) | |||
980 | 980 | ||
981 | /* Check whether driver already requested for MSI irq */ | 981 | /* Check whether driver already requested for MSI irq */ |
982 | if (dev->msi_enabled) { | 982 | if (dev->msi_enabled) { |
983 | dev_info(&dev->dev, "can't enable MSI-X " | 983 | dev_info(&dev->dev, "can't enable MSI-X (MSI IRQ already assigned)\n"); |
984 | "(MSI IRQ already assigned)\n"); | ||
985 | return -EINVAL; | 984 | return -EINVAL; |
986 | } | 985 | } |
987 | status = msix_capability_init(dev, entries, nvec); | 986 | status = msix_capability_init(dev, entries, nvec); |
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c index 41d8d0307347..9ff0a901ecf7 100644 --- a/drivers/pci/pci-sysfs.c +++ b/drivers/pci/pci-sysfs.c | |||
@@ -286,8 +286,8 @@ static ssize_t msi_bus_store(struct device *dev, struct device_attribute *attr, | |||
286 | !!val) { | 286 | !!val) { |
287 | pdev->subordinate->bus_flags ^= PCI_BUS_FLAGS_NO_MSI; | 287 | pdev->subordinate->bus_flags ^= PCI_BUS_FLAGS_NO_MSI; |
288 | 288 | ||
289 | dev_warn(&pdev->dev, "forced subordinate bus to%s support MSI," | 289 | dev_warn(&pdev->dev, "forced subordinate bus to%s support MSI, bad things could happen\n", |
290 | " bad things could happen\n", val ? "" : " not"); | 290 | val ? "" : " not"); |
291 | } | 291 | } |
292 | 292 | ||
293 | return count; | 293 | return count; |
@@ -945,8 +945,7 @@ legacy_io_err: | |||
945 | kfree(b->legacy_io); | 945 | kfree(b->legacy_io); |
946 | b->legacy_io = NULL; | 946 | b->legacy_io = NULL; |
947 | kzalloc_err: | 947 | kzalloc_err: |
948 | printk(KERN_WARNING "pci: warning: could not create legacy I/O port " | 948 | printk(KERN_WARNING "pci: warning: could not create legacy I/O port and ISA memory resources to sysfs\n"); |
949 | "and ISA memory resources to sysfs\n"); | ||
950 | return; | 949 | return; |
951 | } | 950 | } |
952 | 951 | ||
@@ -1006,8 +1005,7 @@ static int pci_mmap_resource(struct kobject *kobj, struct bin_attribute *attr, | |||
1006 | return -ENODEV; | 1005 | return -ENODEV; |
1007 | 1006 | ||
1008 | if (!pci_mmap_fits(pdev, i, vma, PCI_MMAP_SYSFS)) { | 1007 | if (!pci_mmap_fits(pdev, i, vma, PCI_MMAP_SYSFS)) { |
1009 | WARN(1, "process \"%s\" tried to map 0x%08lx bytes " | 1008 | WARN(1, "process \"%s\" tried to map 0x%08lx bytes at page 0x%08lx on %s BAR %d (start 0x%16Lx, size 0x%16Lx)\n", |
1010 | "at page 0x%08lx on %s BAR %d (start 0x%16Lx, size 0x%16Lx)\n", | ||
1011 | current->comm, vma->vm_end-vma->vm_start, vma->vm_pgoff, | 1009 | current->comm, vma->vm_end-vma->vm_start, vma->vm_pgoff, |
1012 | pci_name(pdev), i, | 1010 | pci_name(pdev), i, |
1013 | (u64)pci_resource_start(pdev, i), | 1011 | (u64)pci_resource_start(pdev, i), |
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 952b4b489d0f..0a271a100986 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c | |||
@@ -555,8 +555,8 @@ static int pci_raw_set_power_state(struct pci_dev *dev, pci_power_t state) | |||
555 | */ | 555 | */ |
556 | if (state != PCI_D0 && dev->current_state <= PCI_D3cold | 556 | if (state != PCI_D0 && dev->current_state <= PCI_D3cold |
557 | && dev->current_state > state) { | 557 | && dev->current_state > state) { |
558 | dev_err(&dev->dev, "invalid power transition " | 558 | dev_err(&dev->dev, "invalid power transition (from state %d to %d)\n", |
559 | "(from state %d to %d)\n", dev->current_state, state); | 559 | dev->current_state, state); |
560 | return -EINVAL; | 560 | return -EINVAL; |
561 | } | 561 | } |
562 | 562 | ||
@@ -603,8 +603,8 @@ static int pci_raw_set_power_state(struct pci_dev *dev, pci_power_t state) | |||
603 | pci_read_config_word(dev, dev->pm_cap + PCI_PM_CTRL, &pmcsr); | 603 | pci_read_config_word(dev, dev->pm_cap + PCI_PM_CTRL, &pmcsr); |
604 | dev->current_state = (pmcsr & PCI_PM_CTRL_STATE_MASK); | 604 | dev->current_state = (pmcsr & PCI_PM_CTRL_STATE_MASK); |
605 | if (dev->current_state != state && printk_ratelimit()) | 605 | if (dev->current_state != state && printk_ratelimit()) |
606 | dev_info(&dev->dev, "Refused to change power state, " | 606 | dev_info(&dev->dev, "Refused to change power state, currently in D%d\n", |
607 | "currently in D%d\n", dev->current_state); | 607 | dev->current_state); |
608 | 608 | ||
609 | /* | 609 | /* |
610 | * According to section 5.4.1 of the "PCI BUS POWER MANAGEMENT | 610 | * According to section 5.4.1 of the "PCI BUS POWER MANAGEMENT |
@@ -1029,8 +1029,8 @@ static void pci_restore_config_dword(struct pci_dev *pdev, int offset, | |||
1029 | return; | 1029 | return; |
1030 | 1030 | ||
1031 | for (;;) { | 1031 | for (;;) { |
1032 | dev_dbg(&pdev->dev, "restoring config space at offset " | 1032 | dev_dbg(&pdev->dev, "restoring config space at offset %#x (was %#x, writing %#x)\n", |
1033 | "%#x (was %#x, writing %#x)\n", offset, val, saved_val); | 1033 | offset, val, saved_val); |
1034 | pci_write_config_dword(pdev, offset, saved_val); | 1034 | pci_write_config_dword(pdev, offset, saved_val); |
1035 | if (retry-- <= 0) | 1035 | if (retry-- <= 0) |
1036 | return; | 1036 | return; |
@@ -2815,8 +2815,8 @@ int pci_set_cacheline_size(struct pci_dev *dev) | |||
2815 | if (cacheline_size == pci_cache_line_size) | 2815 | if (cacheline_size == pci_cache_line_size) |
2816 | return 0; | 2816 | return 0; |
2817 | 2817 | ||
2818 | dev_printk(KERN_DEBUG, &dev->dev, "cache line size of %d is not " | 2818 | dev_printk(KERN_DEBUG, &dev->dev, "cache line size of %d is not supported\n", |
2819 | "supported\n", pci_cache_line_size << 2); | 2819 | pci_cache_line_size << 2); |
2820 | 2820 | ||
2821 | return -EINVAL; | 2821 | return -EINVAL; |
2822 | } | 2822 | } |
@@ -2952,8 +2952,8 @@ bool pci_intx_mask_supported(struct pci_dev *dev) | |||
2952 | * go ahead and check it. | 2952 | * go ahead and check it. |
2953 | */ | 2953 | */ |
2954 | if ((new ^ orig) & ~PCI_COMMAND_INTX_DISABLE) { | 2954 | if ((new ^ orig) & ~PCI_COMMAND_INTX_DISABLE) { |
2955 | dev_err(&dev->dev, "Command register changed from " | 2955 | dev_err(&dev->dev, "Command register changed from 0x%x to 0x%x: driver or hardware bug?\n", |
2956 | "0x%x to 0x%x: driver or hardware bug?\n", orig, new); | 2956 | orig, new); |
2957 | } else if ((new ^ orig) & PCI_COMMAND_INTX_DISABLE) { | 2957 | } else if ((new ^ orig) & PCI_COMMAND_INTX_DISABLE) { |
2958 | mask_supported = true; | 2958 | mask_supported = true; |
2959 | pci_write_config_word(dev, PCI_COMMAND, orig); | 2959 | pci_write_config_word(dev, PCI_COMMAND, orig); |
@@ -3138,8 +3138,7 @@ static int pci_af_flr(struct pci_dev *dev, int probe) | |||
3138 | if (pci_wait_for_pending(dev, PCI_AF_STATUS, PCI_AF_STATUS_TP)) | 3138 | if (pci_wait_for_pending(dev, PCI_AF_STATUS, PCI_AF_STATUS_TP)) |
3139 | goto clear; | 3139 | goto clear; |
3140 | 3140 | ||
3141 | dev_err(&dev->dev, "transaction is not cleared; " | 3141 | dev_err(&dev->dev, "transaction is not cleared; proceeding with reset anyway\n"); |
3142 | "proceeding with reset anyway\n"); | ||
3143 | 3142 | ||
3144 | clear: | 3143 | clear: |
3145 | pci_write_config_byte(dev, pos + PCI_AF_CTRL, PCI_AF_CTRL_FLR); | 3144 | pci_write_config_byte(dev, pos + PCI_AF_CTRL, PCI_AF_CTRL_FLR); |
diff --git a/drivers/pci/pcie/aer/aer_inject.c b/drivers/pci/pcie/aer/aer_inject.c index d82cb8fd452e..182224acedbe 100644 --- a/drivers/pci/pcie/aer/aer_inject.c +++ b/drivers/pci/pcie/aer/aer_inject.c | |||
@@ -397,16 +397,14 @@ static int aer_inject(struct aer_error_inj *einj) | |||
397 | if (!aer_mask_override && einj->cor_status && | 397 | if (!aer_mask_override && einj->cor_status && |
398 | !(einj->cor_status & ~cor_mask)) { | 398 | !(einj->cor_status & ~cor_mask)) { |
399 | ret = -EINVAL; | 399 | ret = -EINVAL; |
400 | printk(KERN_WARNING "The correctable error(s) is masked " | 400 | printk(KERN_WARNING "The correctable error(s) is masked by device\n"); |
401 | "by device\n"); | ||
402 | spin_unlock_irqrestore(&inject_lock, flags); | 401 | spin_unlock_irqrestore(&inject_lock, flags); |
403 | goto out_put; | 402 | goto out_put; |
404 | } | 403 | } |
405 | if (!aer_mask_override && einj->uncor_status && | 404 | if (!aer_mask_override && einj->uncor_status && |
406 | !(einj->uncor_status & ~uncor_mask)) { | 405 | !(einj->uncor_status & ~uncor_mask)) { |
407 | ret = -EINVAL; | 406 | ret = -EINVAL; |
408 | printk(KERN_WARNING "The uncorrectable error(s) is masked " | 407 | printk(KERN_WARNING "The uncorrectable error(s) is masked by device\n"); |
409 | "by device\n"); | ||
410 | spin_unlock_irqrestore(&inject_lock, flags); | 408 | spin_unlock_irqrestore(&inject_lock, flags); |
411 | goto out_put; | 409 | goto out_put; |
412 | } | 410 | } |
diff --git a/drivers/pci/pcie/aer/aerdrv_errprint.c b/drivers/pci/pcie/aer/aerdrv_errprint.c index 34ff7026440c..36ed31b52198 100644 --- a/drivers/pci/pcie/aer/aerdrv_errprint.c +++ b/drivers/pci/pcie/aer/aerdrv_errprint.c | |||
@@ -172,9 +172,7 @@ void aer_print_error(struct pci_dev *dev, struct aer_err_info *info) | |||
172 | int id = ((dev->bus->number << 8) | dev->devfn); | 172 | int id = ((dev->bus->number << 8) | dev->devfn); |
173 | 173 | ||
174 | if (!info->status) { | 174 | if (!info->status) { |
175 | dev_err(&dev->dev, | 175 | dev_err(&dev->dev, "PCIe Bus Error: severity=%s, type=Unaccessible, id=%04x(Unregistered Agent ID)\n", |
176 | "PCIe Bus Error: severity=%s, type=Unaccessible, " | ||
177 | "id=%04x(Unregistered Agent ID)\n", | ||
178 | aer_error_severity_string[info->severity], id); | 176 | aer_error_severity_string[info->severity], id); |
179 | goto out; | 177 | goto out; |
180 | } | 178 | } |
@@ -182,13 +180,11 @@ void aer_print_error(struct pci_dev *dev, struct aer_err_info *info) | |||
182 | layer = AER_GET_LAYER_ERROR(info->severity, info->status); | 180 | layer = AER_GET_LAYER_ERROR(info->severity, info->status); |
183 | agent = AER_GET_AGENT(info->severity, info->status); | 181 | agent = AER_GET_AGENT(info->severity, info->status); |
184 | 182 | ||
185 | dev_err(&dev->dev, | 183 | dev_err(&dev->dev, "PCIe Bus Error: severity=%s, type=%s, id=%04x(%s)\n", |
186 | "PCIe Bus Error: severity=%s, type=%s, id=%04x(%s)\n", | ||
187 | aer_error_severity_string[info->severity], | 184 | aer_error_severity_string[info->severity], |
188 | aer_error_layer[layer], id, aer_agent_string[agent]); | 185 | aer_error_layer[layer], id, aer_agent_string[agent]); |
189 | 186 | ||
190 | dev_err(&dev->dev, | 187 | dev_err(&dev->dev, " device [%04x:%04x] error status/mask=%08x/%08x\n", |
191 | " device [%04x:%04x] error status/mask=%08x/%08x\n", | ||
192 | dev->vendor, dev->device, | 188 | dev->vendor, dev->device, |
193 | info->status, info->mask); | 189 | info->status, info->mask); |
194 | 190 | ||
diff --git a/drivers/pci/pcie/pme.c b/drivers/pci/pcie/pme.c index bbc3bdd2b189..82e06a86cd77 100644 --- a/drivers/pci/pcie/pme.c +++ b/drivers/pci/pcie/pme.c | |||
@@ -199,8 +199,7 @@ static void pcie_pme_handle_request(struct pci_dev *port, u16 req_id) | |||
199 | * assuming that the PME was reported by a PCIe-PCI bridge that | 199 | * assuming that the PME was reported by a PCIe-PCI bridge that |
200 | * used devfn different from zero. | 200 | * used devfn different from zero. |
201 | */ | 201 | */ |
202 | dev_dbg(&port->dev, "PME interrupt generated for " | 202 | dev_dbg(&port->dev, "PME interrupt generated for non-existent device %02x:%02x.%d\n", |
203 | "non-existent device %02x:%02x.%d\n", | ||
204 | busnr, PCI_SLOT(devfn), PCI_FUNC(devfn)); | 203 | busnr, PCI_SLOT(devfn), PCI_FUNC(devfn)); |
205 | found = pcie_pme_from_pci_bridge(bus, 0); | 204 | found = pcie_pme_from_pci_bridge(bus, 0); |
206 | } | 205 | } |
diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c index 0d8fdc48e642..80887eaa0668 100644 --- a/drivers/pci/pcie/portdrv_pci.c +++ b/drivers/pci/pcie/portdrv_pci.c | |||
@@ -204,8 +204,8 @@ static int pcie_portdrv_probe(struct pci_dev *dev, | |||
204 | return -ENODEV; | 204 | return -ENODEV; |
205 | 205 | ||
206 | if (!dev->irq && dev->pin) { | 206 | if (!dev->irq && dev->pin) { |
207 | dev_warn(&dev->dev, "device [%04x:%04x] has invalid IRQ; " | 207 | dev_warn(&dev->dev, "device [%04x:%04x] has invalid IRQ; check vendor BIOS\n", |
208 | "check vendor BIOS\n", dev->vendor, dev->device); | 208 | dev->vendor, dev->device); |
209 | } | 209 | } |
210 | status = pcie_port_device_register(dev); | 210 | status = pcie_port_device_register(dev); |
211 | if (status) | 211 | if (status) |
@@ -397,7 +397,7 @@ static struct pci_driver pcie_portdriver = { | |||
397 | static int __init dmi_pcie_pme_disable_msi(const struct dmi_system_id *d) | 397 | static int __init dmi_pcie_pme_disable_msi(const struct dmi_system_id *d) |
398 | { | 398 | { |
399 | pr_notice("%s detected: will not use MSI for PCIe PME signaling\n", | 399 | pr_notice("%s detected: will not use MSI for PCIe PME signaling\n", |
400 | d->ident); | 400 | d->ident); |
401 | pcie_pme_disable_msi(); | 401 | pcie_pme_disable_msi(); |
402 | return 0; | 402 | return 0; |
403 | } | 403 | } |
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 468a6505bef1..e3cf8a2e6292 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c | |||
@@ -433,8 +433,7 @@ static void pci_read_bridge_mmio_pref(struct pci_bus *child) | |||
433 | limit |= ((unsigned long) mem_limit_hi) << 32; | 433 | limit |= ((unsigned long) mem_limit_hi) << 32; |
434 | #else | 434 | #else |
435 | if (mem_base_hi || mem_limit_hi) { | 435 | if (mem_base_hi || mem_limit_hi) { |
436 | dev_err(&dev->dev, "can't handle 64-bit " | 436 | dev_err(&dev->dev, "can't handle 64-bit address space for bridge\n"); |
437 | "address space for bridge\n"); | ||
438 | return; | 437 | return; |
439 | } | 438 | } |
440 | #endif | 439 | #endif |
@@ -933,8 +932,7 @@ int pci_scan_bridge(struct pci_bus *bus, struct pci_dev *dev, int max, int pass) | |||
933 | (child->number > bus->busn_res.end) || | 932 | (child->number > bus->busn_res.end) || |
934 | (child->number < bus->number) || | 933 | (child->number < bus->number) || |
935 | (child->busn_res.end < bus->number)) { | 934 | (child->busn_res.end < bus->number)) { |
936 | dev_info(&child->dev, "%pR %s " | 935 | dev_info(&child->dev, "%pR %s hidden behind%s bridge %s %pR\n", |
937 | "hidden behind%s bridge %s %pR\n", | ||
938 | &child->busn_res, | 936 | &child->busn_res, |
939 | (bus->number > child->busn_res.end && | 937 | (bus->number > child->busn_res.end && |
940 | bus->busn_res.end < child->number) ? | 938 | bus->busn_res.end < child->number) ? |
@@ -1224,13 +1222,13 @@ int pci_setup_device(struct pci_dev *dev) | |||
1224 | break; | 1222 | break; |
1225 | 1223 | ||
1226 | default: /* unknown header */ | 1224 | default: /* unknown header */ |
1227 | dev_err(&dev->dev, "unknown header type %02x, " | 1225 | dev_err(&dev->dev, "unknown header type %02x, ignoring device\n", |
1228 | "ignoring device\n", dev->hdr_type); | 1226 | dev->hdr_type); |
1229 | return -EIO; | 1227 | return -EIO; |
1230 | 1228 | ||
1231 | bad: | 1229 | bad: |
1232 | dev_err(&dev->dev, "ignoring class %#08x (doesn't match header " | 1230 | dev_err(&dev->dev, "ignoring class %#08x (doesn't match header type %02x)\n", |
1233 | "type %02x)\n", dev->class, dev->hdr_type); | 1231 | dev->class, dev->hdr_type); |
1234 | dev->class = PCI_CLASS_NOT_DEFINED; | 1232 | dev->class = PCI_CLASS_NOT_DEFINED; |
1235 | } | 1233 | } |
1236 | 1234 | ||
@@ -1305,10 +1303,9 @@ bool pci_bus_read_dev_vendor_id(struct pci_bus *bus, int devfn, u32 *l, | |||
1305 | return false; | 1303 | return false; |
1306 | /* Card hasn't responded in 60 seconds? Must be stuck. */ | 1304 | /* Card hasn't responded in 60 seconds? Must be stuck. */ |
1307 | if (delay > crs_timeout) { | 1305 | if (delay > crs_timeout) { |
1308 | printk(KERN_WARNING "pci %04x:%02x:%02x.%d: not " | 1306 | printk(KERN_WARNING "pci %04x:%02x:%02x.%d: not responding\n", |
1309 | "responding\n", pci_domain_nr(bus), | 1307 | pci_domain_nr(bus), bus->number, PCI_SLOT(devfn), |
1310 | bus->number, PCI_SLOT(devfn), | 1308 | PCI_FUNC(devfn)); |
1311 | PCI_FUNC(devfn)); | ||
1312 | return false; | 1309 | return false; |
1313 | } | 1310 | } |
1314 | } | 1311 | } |
@@ -1613,9 +1610,7 @@ static void pcie_write_mrrs(struct pci_dev *dev) | |||
1613 | } | 1610 | } |
1614 | 1611 | ||
1615 | if (mrrs < 128) | 1612 | if (mrrs < 128) |
1616 | dev_err(&dev->dev, "MRRS was unable to be configured with a " | 1613 | dev_err(&dev->dev, "MRRS was unable to be configured with a safe value. If problems are experienced, try running with pci=pcie_bus_safe\n"); |
1617 | "safe value. If problems are experienced, try running " | ||
1618 | "with pci=pcie_bus_safe.\n"); | ||
1619 | } | 1614 | } |
1620 | 1615 | ||
1621 | static void pcie_bus_detect_mps(struct pci_dev *dev) | 1616 | static void pcie_bus_detect_mps(struct pci_dev *dev) |
@@ -1652,8 +1647,8 @@ static int pcie_bus_configure_set(struct pci_dev *dev, void *data) | |||
1652 | pcie_write_mps(dev, mps); | 1647 | pcie_write_mps(dev, mps); |
1653 | pcie_write_mrrs(dev); | 1648 | pcie_write_mrrs(dev); |
1654 | 1649 | ||
1655 | dev_info(&dev->dev, "Max Payload Size set to %4d/%4d (was %4d), " | 1650 | dev_info(&dev->dev, "Max Payload Size set to %4d/%4d (was %4d), Max Read Rq %4d\n", |
1656 | "Max Read Rq %4d\n", pcie_get_mps(dev), 128 << dev->pcie_mpss, | 1651 | pcie_get_mps(dev), 128 << dev->pcie_mpss, |
1657 | orig_mps, pcie_get_readrq(dev)); | 1652 | orig_mps, pcie_get_readrq(dev)); |
1658 | 1653 | ||
1659 | return 0; | 1654 | return 0; |
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index e0d78d23483a..f01c50d9f6d7 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c | |||
@@ -315,8 +315,7 @@ static void quirk_cs5536_vsa(struct pci_dev *dev) | |||
315 | if (pci_resource_len(dev, 0) != 8) { | 315 | if (pci_resource_len(dev, 0) != 8) { |
316 | struct resource *res = &dev->resource[0]; | 316 | struct resource *res = &dev->resource[0]; |
317 | res->end = res->start + 8 - 1; | 317 | res->end = res->start + 8 - 1; |
318 | dev_info(&dev->dev, "CS5536 ISA bridge bug detected " | 318 | dev_info(&dev->dev, "CS5536 ISA bridge bug detected (incorrect header); workaround applied\n"); |
319 | "(incorrect header); workaround applied.\n"); | ||
320 | } | 319 | } |
321 | } | 320 | } |
322 | DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_CS5536_ISA, quirk_cs5536_vsa); | 321 | DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_CS5536_ISA, quirk_cs5536_vsa); |
@@ -400,7 +399,8 @@ static void piix4_io_quirk(struct pci_dev *dev, const char *name, unsigned int p | |||
400 | * let's get enough confirmation reports first. | 399 | * let's get enough confirmation reports first. |
401 | */ | 400 | */ |
402 | base &= -size; | 401 | base &= -size; |
403 | dev_info(&dev->dev, "%s PIO at %04x-%04x\n", name, base, base + size - 1); | 402 | dev_info(&dev->dev, "%s PIO at %04x-%04x\n", name, base, |
403 | base + size - 1); | ||
404 | } | 404 | } |
405 | 405 | ||
406 | static void piix4_mem_quirk(struct pci_dev *dev, const char *name, unsigned int port, unsigned int enable) | 406 | static void piix4_mem_quirk(struct pci_dev *dev, const char *name, unsigned int port, unsigned int enable) |
@@ -425,7 +425,8 @@ static void piix4_mem_quirk(struct pci_dev *dev, const char *name, unsigned int | |||
425 | * reserve it, but let's get enough confirmation reports first. | 425 | * reserve it, but let's get enough confirmation reports first. |
426 | */ | 426 | */ |
427 | base &= -size; | 427 | base &= -size; |
428 | dev_info(&dev->dev, "%s MMIO at %04x-%04x\n", name, base, base + size - 1); | 428 | dev_info(&dev->dev, "%s MMIO at %04x-%04x\n", name, base, |
429 | base + size - 1); | ||
429 | } | 430 | } |
430 | 431 | ||
431 | /* | 432 | /* |
@@ -668,8 +669,7 @@ static void quirk_xio2000a(struct pci_dev *dev) | |||
668 | struct pci_dev *pdev; | 669 | struct pci_dev *pdev; |
669 | u16 command; | 670 | u16 command; |
670 | 671 | ||
671 | dev_warn(&dev->dev, "TI XIO2000a quirk detected; " | 672 | dev_warn(&dev->dev, "TI XIO2000a quirk detected; secondary bus fast back-to-back transfers disabled\n"); |
672 | "secondary bus fast back-to-back transfers disabled\n"); | ||
673 | list_for_each_entry(pdev, &dev->subordinate->devices, bus_list) { | 673 | list_for_each_entry(pdev, &dev->subordinate->devices, bus_list) { |
674 | pci_read_config_word(pdev, PCI_COMMAND, &command); | 674 | pci_read_config_word(pdev, PCI_COMMAND, &command); |
675 | if (command & PCI_COMMAND_FAST_BACK) | 675 | if (command & PCI_COMMAND_FAST_BACK) |
@@ -761,8 +761,8 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SI, PCI_ANY_ID, quirk_ioapic_rmw); | |||
761 | static void quirk_amd_8131_mmrbc(struct pci_dev *dev) | 761 | static void quirk_amd_8131_mmrbc(struct pci_dev *dev) |
762 | { | 762 | { |
763 | if (dev->subordinate && dev->revision <= 0x12) { | 763 | if (dev->subordinate && dev->revision <= 0x12) { |
764 | dev_info(&dev->dev, "AMD8131 rev %x detected; " | 764 | dev_info(&dev->dev, "AMD8131 rev %x detected; disabling PCI-X MMRBC\n", |
765 | "disabling PCI-X MMRBC\n", dev->revision); | 765 | dev->revision); |
766 | dev->subordinate->bus_flags |= PCI_BUS_FLAGS_NO_MMRBC; | 766 | dev->subordinate->bus_flags |= PCI_BUS_FLAGS_NO_MMRBC; |
767 | } | 767 | } |
768 | } | 768 | } |
@@ -971,7 +971,8 @@ static void quirk_mediagx_master(struct pci_dev *dev) | |||
971 | pci_read_config_byte(dev, 0x41, ®); | 971 | pci_read_config_byte(dev, 0x41, ®); |
972 | if (reg & 2) { | 972 | if (reg & 2) { |
973 | reg &= ~2; | 973 | reg &= ~2; |
974 | dev_info(&dev->dev, "Fixup for MediaGX/Geode Slave Disconnect Boundary (0x41=0x%02x)\n", reg); | 974 | dev_info(&dev->dev, "Fixup for MediaGX/Geode Slave Disconnect Boundary (0x41=0x%02x)\n", |
975 | reg); | ||
975 | pci_write_config_byte(dev, 0x41, reg); | 976 | pci_write_config_byte(dev, 0x41, reg); |
976 | } | 977 | } |
977 | } | 978 | } |
@@ -1262,7 +1263,8 @@ static void asus_hides_smbus_lpc(struct pci_dev *dev) | |||
1262 | pci_write_config_word(dev, 0xF2, val & (~0x8)); | 1263 | pci_write_config_word(dev, 0xF2, val & (~0x8)); |
1263 | pci_read_config_word(dev, 0xF2, &val); | 1264 | pci_read_config_word(dev, 0xF2, &val); |
1264 | if (val & 0x8) | 1265 | if (val & 0x8) |
1265 | dev_info(&dev->dev, "i801 SMBus device continues to play 'hide and seek'! 0x%x\n", val); | 1266 | dev_info(&dev->dev, "i801 SMBus device continues to play 'hide and seek'! 0x%x\n", |
1267 | val); | ||
1266 | else | 1268 | else |
1267 | dev_info(&dev->dev, "Enabled i801 SMBus device\n"); | 1269 | dev_info(&dev->dev, "Enabled i801 SMBus device\n"); |
1268 | } | 1270 | } |
@@ -1410,7 +1412,8 @@ static void asus_hides_ac97_lpc(struct pci_dev *dev) | |||
1410 | pci_write_config_byte(dev, 0x50, val & (~0xc0)); | 1412 | pci_write_config_byte(dev, 0x50, val & (~0xc0)); |
1411 | pci_read_config_byte(dev, 0x50, &val); | 1413 | pci_read_config_byte(dev, 0x50, &val); |
1412 | if (val & 0xc0) | 1414 | if (val & 0xc0) |
1413 | dev_info(&dev->dev, "Onboard AC97/MC97 devices continue to play 'hide and seek'! 0x%x\n", val); | 1415 | dev_info(&dev->dev, "Onboard AC97/MC97 devices continue to play 'hide and seek'! 0x%x\n", |
1416 | val); | ||
1414 | else | 1417 | else |
1415 | dev_info(&dev->dev, "Enabled onboard AC97/MC97 devices\n"); | 1418 | dev_info(&dev->dev, "Enabled onboard AC97/MC97 devices\n"); |
1416 | } | 1419 | } |
@@ -1720,8 +1723,8 @@ static void quirk_disable_amd_8111_boot_interrupt(struct pci_dev *dev) | |||
1720 | 1723 | ||
1721 | pci_read_config_word(dev, AMD_8111_PCI_IRQ_ROUTING, &pci_config_word); | 1724 | pci_read_config_word(dev, AMD_8111_PCI_IRQ_ROUTING, &pci_config_word); |
1722 | if (!pci_config_word) { | 1725 | if (!pci_config_word) { |
1723 | dev_info(&dev->dev, "boot interrupts on device [%04x:%04x] " | 1726 | dev_info(&dev->dev, "boot interrupts on device [%04x:%04x] already disabled\n", |
1724 | "already disabled\n", dev->vendor, dev->device); | 1727 | dev->vendor, dev->device); |
1725 | return; | 1728 | return; |
1726 | } | 1729 | } |
1727 | pci_write_config_word(dev, AMD_8111_PCI_IRQ_ROUTING, 0); | 1730 | pci_write_config_word(dev, AMD_8111_PCI_IRQ_ROUTING, 0); |
@@ -1769,8 +1772,7 @@ static void quirk_plx_pci9050(struct pci_dev *dev) | |||
1769 | if (pci_resource_len(dev, bar) == 0x80 && | 1772 | if (pci_resource_len(dev, bar) == 0x80 && |
1770 | (pci_resource_start(dev, bar) & 0x80)) { | 1773 | (pci_resource_start(dev, bar) & 0x80)) { |
1771 | struct resource *r = &dev->resource[bar]; | 1774 | struct resource *r = &dev->resource[bar]; |
1772 | dev_info(&dev->dev, | 1775 | dev_info(&dev->dev, "Re-allocating PLX PCI 9050 BAR %u to length 256 to avoid bit 7 bug\n", |
1773 | "Re-allocating PLX PCI 9050 BAR %u to length 256 to avoid bit 7 bug\n", | ||
1774 | bar); | 1776 | bar); |
1775 | r->flags |= IORESOURCE_UNSET; | 1777 | r->flags |= IORESOURCE_UNSET; |
1776 | r->start = 0; | 1778 | r->start = 0; |
@@ -1817,9 +1819,7 @@ static void quirk_netmos(struct pci_dev *dev) | |||
1817 | case PCI_DEVICE_ID_NETMOS_9845: | 1819 | case PCI_DEVICE_ID_NETMOS_9845: |
1818 | case PCI_DEVICE_ID_NETMOS_9855: | 1820 | case PCI_DEVICE_ID_NETMOS_9855: |
1819 | if (num_parallel) { | 1821 | if (num_parallel) { |
1820 | dev_info(&dev->dev, "Netmos %04x (%u parallel, " | 1822 | dev_info(&dev->dev, "Netmos %04x (%u parallel, %u serial); changing class SERIAL to OTHER (use parport_serial)\n", |
1821 | "%u serial); changing class SERIAL to OTHER " | ||
1822 | "(use parport_serial)\n", | ||
1823 | dev->device, num_parallel, num_serial); | 1823 | dev->device, num_parallel, num_serial); |
1824 | dev->class = (PCI_CLASS_COMMUNICATION_OTHER << 8) | | 1824 | dev->class = (PCI_CLASS_COMMUNICATION_OTHER << 8) | |
1825 | (dev->class & 0xff); | 1825 | (dev->class & 0xff); |
@@ -1886,8 +1886,7 @@ static void quirk_e100_interrupt(struct pci_dev *dev) | |||
1886 | 1886 | ||
1887 | cmd_hi = readb(csr + 3); | 1887 | cmd_hi = readb(csr + 3); |
1888 | if (cmd_hi == 0) { | 1888 | if (cmd_hi == 0) { |
1889 | dev_warn(&dev->dev, "Firmware left e100 interrupts enabled; " | 1889 | dev_warn(&dev->dev, "Firmware left e100 interrupts enabled; disabling\n"); |
1890 | "disabling\n"); | ||
1891 | writeb(1, csr + 3); | 1890 | writeb(1, csr + 3); |
1892 | } | 1891 | } |
1893 | 1892 | ||
@@ -1957,8 +1956,7 @@ static void quirk_nvidia_ck804_pcie_aer_ext_cap(struct pci_dev *dev) | |||
1957 | if (pci_read_config_byte(dev, 0xf41, &b) == 0) { | 1956 | if (pci_read_config_byte(dev, 0xf41, &b) == 0) { |
1958 | if (!(b & 0x20)) { | 1957 | if (!(b & 0x20)) { |
1959 | pci_write_config_byte(dev, 0xf41, b | 0x20); | 1958 | pci_write_config_byte(dev, 0xf41, b | 0x20); |
1960 | dev_info(&dev->dev, | 1959 | dev_info(&dev->dev, "Linking AER extended capability\n"); |
1961 | "Linking AER extended capability\n"); | ||
1962 | } | 1960 | } |
1963 | } | 1961 | } |
1964 | } | 1962 | } |
@@ -1996,8 +1994,7 @@ static void quirk_via_cx700_pci_parking_caching(struct pci_dev *dev) | |||
1996 | /* Turn off PCI Bus Parking */ | 1994 | /* Turn off PCI Bus Parking */ |
1997 | pci_write_config_byte(dev, 0x76, b ^ 0x40); | 1995 | pci_write_config_byte(dev, 0x76, b ^ 0x40); |
1998 | 1996 | ||
1999 | dev_info(&dev->dev, | 1997 | dev_info(&dev->dev, "Disabling VIA CX700 PCI parking\n"); |
2000 | "Disabling VIA CX700 PCI parking\n"); | ||
2001 | } | 1998 | } |
2002 | } | 1999 | } |
2003 | 2000 | ||
@@ -2012,8 +2009,7 @@ static void quirk_via_cx700_pci_parking_caching(struct pci_dev *dev) | |||
2012 | /* Disable "Read FIFO Timer" */ | 2009 | /* Disable "Read FIFO Timer" */ |
2013 | pci_write_config_byte(dev, 0x77, 0x0); | 2010 | pci_write_config_byte(dev, 0x77, 0x0); |
2014 | 2011 | ||
2015 | dev_info(&dev->dev, | 2012 | dev_info(&dev->dev, "Disabling VIA CX700 PCI caching\n"); |
2016 | "Disabling VIA CX700 PCI caching\n"); | ||
2017 | } | 2013 | } |
2018 | } | 2014 | } |
2019 | } | 2015 | } |
@@ -2148,8 +2144,7 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_8380_0, quirk_disab | |||
2148 | static void quirk_disable_msi(struct pci_dev *dev) | 2144 | static void quirk_disable_msi(struct pci_dev *dev) |
2149 | { | 2145 | { |
2150 | if (dev->subordinate) { | 2146 | if (dev->subordinate) { |
2151 | dev_warn(&dev->dev, "MSI quirk detected; " | 2147 | dev_warn(&dev->dev, "MSI quirk detected; subordinate MSI disabled\n"); |
2152 | "subordinate MSI disabled\n"); | ||
2153 | dev->subordinate->bus_flags |= PCI_BUS_FLAGS_NO_MSI; | 2148 | dev->subordinate->bus_flags |= PCI_BUS_FLAGS_NO_MSI; |
2154 | } | 2149 | } |
2155 | } | 2150 | } |
@@ -2205,8 +2200,7 @@ static int msi_ht_cap_enabled(struct pci_dev *dev) | |||
2205 | static void quirk_msi_ht_cap(struct pci_dev *dev) | 2200 | static void quirk_msi_ht_cap(struct pci_dev *dev) |
2206 | { | 2201 | { |
2207 | if (dev->subordinate && !msi_ht_cap_enabled(dev)) { | 2202 | if (dev->subordinate && !msi_ht_cap_enabled(dev)) { |
2208 | dev_warn(&dev->dev, "MSI quirk detected; " | 2203 | dev_warn(&dev->dev, "MSI quirk detected; subordinate MSI disabled\n"); |
2209 | "subordinate MSI disabled\n"); | ||
2210 | dev->subordinate->bus_flags |= PCI_BUS_FLAGS_NO_MSI; | 2204 | dev->subordinate->bus_flags |= PCI_BUS_FLAGS_NO_MSI; |
2211 | } | 2205 | } |
2212 | } | 2206 | } |
@@ -2230,8 +2224,7 @@ static void quirk_nvidia_ck804_msi_ht_cap(struct pci_dev *dev) | |||
2230 | if (!pdev) | 2224 | if (!pdev) |
2231 | return; | 2225 | return; |
2232 | if (!msi_ht_cap_enabled(dev) && !msi_ht_cap_enabled(pdev)) { | 2226 | if (!msi_ht_cap_enabled(dev) && !msi_ht_cap_enabled(pdev)) { |
2233 | dev_warn(&dev->dev, "MSI quirk detected; " | 2227 | dev_warn(&dev->dev, "MSI quirk detected; subordinate MSI disabled\n"); |
2234 | "subordinate MSI disabled\n"); | ||
2235 | dev->subordinate->bus_flags |= PCI_BUS_FLAGS_NO_MSI; | 2228 | dev->subordinate->bus_flags |= PCI_BUS_FLAGS_NO_MSI; |
2236 | } | 2229 | } |
2237 | pci_dev_put(pdev); | 2230 | pci_dev_put(pdev); |
@@ -2277,8 +2270,7 @@ static void nvenet_msi_disable(struct pci_dev *dev) | |||
2277 | if (board_name && | 2270 | if (board_name && |
2278 | (strstr(board_name, "P5N32-SLI PREMIUM") || | 2271 | (strstr(board_name, "P5N32-SLI PREMIUM") || |
2279 | strstr(board_name, "P5N32-E SLI"))) { | 2272 | strstr(board_name, "P5N32-E SLI"))) { |
2280 | dev_info(&dev->dev, | 2273 | dev_info(&dev->dev, "Disabling msi for MCP55 NIC on P5N32-SLI\n"); |
2281 | "Disabling msi for MCP55 NIC on P5N32-SLI\n"); | ||
2282 | dev->no_msi = 1; | 2274 | dev->no_msi = 1; |
2283 | } | 2275 | } |
2284 | } | 2276 | } |
@@ -2487,8 +2479,7 @@ static void __nv_msi_ht_cap_quirk(struct pci_dev *dev, int all) | |||
2487 | */ | 2479 | */ |
2488 | host_bridge = pci_get_bus_and_slot(0, PCI_DEVFN(0, 0)); | 2480 | host_bridge = pci_get_bus_and_slot(0, PCI_DEVFN(0, 0)); |
2489 | if (host_bridge == NULL) { | 2481 | if (host_bridge == NULL) { |
2490 | dev_warn(&dev->dev, | 2482 | dev_warn(&dev->dev, "nv_msi_ht_cap_quirk didn't locate host bridge\n"); |
2491 | "nv_msi_ht_cap_quirk didn't locate host bridge\n"); | ||
2492 | return; | 2483 | return; |
2493 | } | 2484 | } |
2494 | 2485 | ||
@@ -2815,8 +2806,7 @@ static void quirk_intel_mc_errata(struct pci_dev *dev) | |||
2815 | */ | 2806 | */ |
2816 | err = pci_read_config_word(dev, 0x48, &rcc); | 2807 | err = pci_read_config_word(dev, 0x48, &rcc); |
2817 | if (err) { | 2808 | if (err) { |
2818 | dev_err(&dev->dev, "Error attempting to read the read " | 2809 | dev_err(&dev->dev, "Error attempting to read the read completion coalescing register\n"); |
2819 | "completion coalescing register.\n"); | ||
2820 | return; | 2810 | return; |
2821 | } | 2811 | } |
2822 | 2812 | ||
@@ -2827,13 +2817,11 @@ static void quirk_intel_mc_errata(struct pci_dev *dev) | |||
2827 | 2817 | ||
2828 | err = pci_write_config_word(dev, 0x48, rcc); | 2818 | err = pci_write_config_word(dev, 0x48, rcc); |
2829 | if (err) { | 2819 | if (err) { |
2830 | dev_err(&dev->dev, "Error attempting to write the read " | 2820 | dev_err(&dev->dev, "Error attempting to write the read completion coalescing register\n"); |
2831 | "completion coalescing register.\n"); | ||
2832 | return; | 2821 | return; |
2833 | } | 2822 | } |
2834 | 2823 | ||
2835 | pr_info_once("Read completion coalescing disabled due to hardware " | 2824 | pr_info_once("Read completion coalescing disabled due to hardware errata relating to 256B MPS\n"); |
2836 | "errata relating to 256B MPS.\n"); | ||
2837 | } | 2825 | } |
2838 | /* Intel 5000 series memory controllers and ports 2-7 */ | 2826 | /* Intel 5000 series memory controllers and ports 2-7 */ |
2839 | DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x25c0, quirk_intel_mc_errata); | 2827 | DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x25c0, quirk_intel_mc_errata); |
@@ -2942,8 +2930,7 @@ static void disable_igfx_irq(struct pci_dev *dev) | |||
2942 | 2930 | ||
2943 | /* Check if any interrupt line is still enabled */ | 2931 | /* Check if any interrupt line is still enabled */ |
2944 | if (readl(regs + I915_DEIER_REG) != 0) { | 2932 | if (readl(regs + I915_DEIER_REG) != 0) { |
2945 | dev_warn(&dev->dev, "BIOS left Intel GPU interrupts enabled; " | 2933 | dev_warn(&dev->dev, "BIOS left Intel GPU interrupts enabled; disabling\n"); |
2946 | "disabling\n"); | ||
2947 | 2934 | ||
2948 | writel(0, regs + I915_DEIER_REG); | 2935 | writel(0, regs + I915_DEIER_REG); |
2949 | } | 2936 | } |
@@ -3110,8 +3097,8 @@ static int __init pci_apply_final_quirks(void) | |||
3110 | if (!tmp || cls == tmp) | 3097 | if (!tmp || cls == tmp) |
3111 | continue; | 3098 | continue; |
3112 | 3099 | ||
3113 | printk(KERN_DEBUG "PCI: CLS mismatch (%u != %u), " | 3100 | printk(KERN_DEBUG "PCI: CLS mismatch (%u != %u), using %u bytes\n", |
3114 | "using %u bytes\n", cls << 2, tmp << 2, | 3101 | cls << 2, tmp << 2, |
3115 | pci_dfl_cache_line_size << 2); | 3102 | pci_dfl_cache_line_size << 2); |
3116 | pci_cache_line_size = pci_dfl_cache_line_size; | 3103 | pci_cache_line_size = pci_dfl_cache_line_size; |
3117 | } | 3104 | } |
diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c index 2f053922dd5c..a5a63ecfb628 100644 --- a/drivers/pci/setup-bus.c +++ b/drivers/pci/setup-bus.c | |||
@@ -148,8 +148,7 @@ static void pdev_sort_resources(struct pci_dev *dev, struct list_head *head) | |||
148 | 148 | ||
149 | tmp = kzalloc(sizeof(*tmp), GFP_KERNEL); | 149 | tmp = kzalloc(sizeof(*tmp), GFP_KERNEL); |
150 | if (!tmp) | 150 | if (!tmp) |
151 | panic("pdev_sort_resources(): " | 151 | panic("pdev_sort_resources(): kmalloc() failed!\n"); |
152 | "kmalloc() failed!\n"); | ||
153 | tmp->res = r; | 152 | tmp->res = r; |
154 | tmp->dev = dev; | 153 | tmp->dev = dev; |
155 | 154 | ||
@@ -859,9 +858,8 @@ static void pbus_size_io(struct pci_bus *bus, resource_size_t min_size, | |||
859 | resource_size(b_res), min_align); | 858 | resource_size(b_res), min_align); |
860 | if (!size0 && !size1) { | 859 | if (!size0 && !size1) { |
861 | if (b_res->start || b_res->end) | 860 | if (b_res->start || b_res->end) |
862 | dev_info(&bus->self->dev, "disabling bridge window " | 861 | dev_info(&bus->self->dev, "disabling bridge window %pR to %pR (unused)\n", |
863 | "%pR to %pR (unused)\n", b_res, | 862 | b_res, &bus->busn_res); |
864 | &bus->busn_res); | ||
865 | b_res->flags = 0; | 863 | b_res->flags = 0; |
866 | return; | 864 | return; |
867 | } | 865 | } |
@@ -872,10 +870,9 @@ static void pbus_size_io(struct pci_bus *bus, resource_size_t min_size, | |||
872 | if (size1 > size0 && realloc_head) { | 870 | if (size1 > size0 && realloc_head) { |
873 | add_to_list(realloc_head, bus->self, b_res, size1-size0, | 871 | add_to_list(realloc_head, bus->self, b_res, size1-size0, |
874 | min_align); | 872 | min_align); |
875 | dev_printk(KERN_DEBUG, &bus->self->dev, "bridge window " | 873 | dev_printk(KERN_DEBUG, &bus->self->dev, "bridge window %pR to %pR add_size %llx\n", |
876 | "%pR to %pR add_size %llx\n", b_res, | 874 | b_res, &bus->busn_res, |
877 | &bus->busn_res, | 875 | (unsigned long long)size1-size0); |
878 | (unsigned long long)size1-size0); | ||
879 | } | 876 | } |
880 | } | 877 | } |
881 | 878 | ||
@@ -974,9 +971,8 @@ static int pbus_size_mem(struct pci_bus *bus, unsigned long mask, | |||
974 | if (order < 0) | 971 | if (order < 0) |
975 | order = 0; | 972 | order = 0; |
976 | if (order >= ARRAY_SIZE(aligns)) { | 973 | if (order >= ARRAY_SIZE(aligns)) { |
977 | dev_warn(&dev->dev, "disabling BAR %d: %pR " | 974 | dev_warn(&dev->dev, "disabling BAR %d: %pR (bad alignment %#llx)\n", |
978 | "(bad alignment %#llx)\n", i, r, | 975 | i, r, (unsigned long long) align); |
979 | (unsigned long long) align); | ||
980 | r->flags = 0; | 976 | r->flags = 0; |
981 | continue; | 977 | continue; |
982 | } | 978 | } |
@@ -1003,9 +999,8 @@ static int pbus_size_mem(struct pci_bus *bus, unsigned long mask, | |||
1003 | resource_size(b_res), min_align); | 999 | resource_size(b_res), min_align); |
1004 | if (!size0 && !size1) { | 1000 | if (!size0 && !size1) { |
1005 | if (b_res->start || b_res->end) | 1001 | if (b_res->start || b_res->end) |
1006 | dev_info(&bus->self->dev, "disabling bridge window " | 1002 | dev_info(&bus->self->dev, "disabling bridge window %pR to %pR (unused)\n", |
1007 | "%pR to %pR (unused)\n", b_res, | 1003 | b_res, &bus->busn_res); |
1008 | &bus->busn_res); | ||
1009 | b_res->flags = 0; | 1004 | b_res->flags = 0; |
1010 | return 0; | 1005 | return 0; |
1011 | } | 1006 | } |
@@ -1014,9 +1009,9 @@ static int pbus_size_mem(struct pci_bus *bus, unsigned long mask, | |||
1014 | b_res->flags |= IORESOURCE_STARTALIGN; | 1009 | b_res->flags |= IORESOURCE_STARTALIGN; |
1015 | if (size1 > size0 && realloc_head) { | 1010 | if (size1 > size0 && realloc_head) { |
1016 | add_to_list(realloc_head, bus->self, b_res, size1-size0, min_align); | 1011 | add_to_list(realloc_head, bus->self, b_res, size1-size0, min_align); |
1017 | dev_printk(KERN_DEBUG, &bus->self->dev, "bridge window " | 1012 | dev_printk(KERN_DEBUG, &bus->self->dev, "bridge window %pR to %pR add_size %llx\n", |
1018 | "%pR to %pR add_size %llx\n", b_res, | 1013 | b_res, &bus->busn_res, |
1019 | &bus->busn_res, (unsigned long long)size1-size0); | 1014 | (unsigned long long)size1-size0); |
1020 | } | 1015 | } |
1021 | return 0; | 1016 | return 0; |
1022 | } | 1017 | } |
@@ -1274,8 +1269,8 @@ void __pci_bus_assign_resources(const struct pci_bus *bus, | |||
1274 | break; | 1269 | break; |
1275 | 1270 | ||
1276 | default: | 1271 | default: |
1277 | dev_info(&dev->dev, "not setting up bridge for bus " | 1272 | dev_info(&dev->dev, "not setting up bridge for bus %04x:%02x\n", |
1278 | "%04x:%02x\n", pci_domain_nr(b), b->number); | 1273 | pci_domain_nr(b), b->number); |
1279 | break; | 1274 | break; |
1280 | } | 1275 | } |
1281 | } | 1276 | } |
@@ -1312,8 +1307,8 @@ static void __pci_bridge_assign_resources(const struct pci_dev *bridge, | |||
1312 | break; | 1307 | break; |
1313 | 1308 | ||
1314 | default: | 1309 | default: |
1315 | dev_info(&bridge->dev, "not setting up bridge for bus " | 1310 | dev_info(&bridge->dev, "not setting up bridge for bus %04x:%02x\n", |
1316 | "%04x:%02x\n", pci_domain_nr(b), b->number); | 1311 | pci_domain_nr(b), b->number); |
1317 | break; | 1312 | break; |
1318 | } | 1313 | } |
1319 | } | 1314 | } |
diff --git a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c index 211b36f96ff3..caed1ce6facd 100644 --- a/drivers/pci/setup-res.c +++ b/drivers/pci/setup-res.c | |||
@@ -96,8 +96,8 @@ void pci_update_resource(struct pci_dev *dev, int resno) | |||
96 | pci_write_config_dword(dev, reg + 4, new); | 96 | pci_write_config_dword(dev, reg + 4, new); |
97 | pci_read_config_dword(dev, reg + 4, &check); | 97 | pci_read_config_dword(dev, reg + 4, &check); |
98 | if (check != new) { | 98 | if (check != new) { |
99 | dev_err(&dev->dev, "BAR %d: error updating " | 99 | dev_err(&dev->dev, "BAR %d: error updating (high %#08x != %#08x)\n", |
100 | "(high %#08x != %#08x)\n", resno, new, check); | 100 | resno, new, check); |
101 | } | 101 | } |
102 | } | 102 | } |
103 | 103 | ||
@@ -289,8 +289,8 @@ int pci_assign_resource(struct pci_dev *dev, int resno) | |||
289 | res->flags |= IORESOURCE_UNSET; | 289 | res->flags |= IORESOURCE_UNSET; |
290 | align = pci_resource_alignment(dev, res); | 290 | align = pci_resource_alignment(dev, res); |
291 | if (!align) { | 291 | if (!align) { |
292 | dev_info(&dev->dev, "BAR %d: can't assign %pR " | 292 | dev_info(&dev->dev, "BAR %d: can't assign %pR (bogus alignment)\n", |
293 | "(bogus alignment)\n", resno, res); | 293 | resno, res); |
294 | return -EINVAL; | 294 | return -EINVAL; |
295 | } | 295 | } |
296 | 296 | ||
@@ -325,8 +325,8 @@ int pci_reassign_resource(struct pci_dev *dev, int resno, resource_size_t addsiz | |||
325 | 325 | ||
326 | res->flags |= IORESOURCE_UNSET; | 326 | res->flags |= IORESOURCE_UNSET; |
327 | if (!res->parent) { | 327 | if (!res->parent) { |
328 | dev_info(&dev->dev, "BAR %d: can't reassign an unassigned resource %pR " | 328 | dev_info(&dev->dev, "BAR %d: can't reassign an unassigned resource %pR\n", |
329 | "\n", resno, res); | 329 | resno, res); |
330 | return -EINVAL; | 330 | return -EINVAL; |
331 | } | 331 | } |
332 | 332 | ||