aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/usb/phy
diff options
context:
space:
mode:
authorGrazvydas Ignotas <notasas@gmail.com>2013-03-17 14:23:23 -0400
committerFelipe Balbi <balbi@ti.com>2013-03-21 08:20:29 -0400
commit15460de7f3d9cf0846af1cfdb4a3995d2f270ce7 (patch)
treec87a2eec69b317c9e08e87b7f4732eebd56c9075 /drivers/usb/phy
parentca4f70ce78de9a2fa09741f80cf7bda2f4256ecc (diff)
usb: phy: twl4030-usb: don't switch the phy on/off needlessly
With runtime_pm in place there is no longer need to turn the phy on/off in OTG layer on cable connect/disconnect, OMAP glue does this through otg.set_suspend() callback after it's called through omap_musb_mailbox() on VBUS/ID interrupt. Not doing this will save power when cable is connected but no gadget driver is loaded. This will also have side effect of automatic USB charging no longer working without twl4030_charger driver, because a regulator needed for charging will no longer be enabled, so be sure to enable charger driver if charging is needed. Signed-off-by: Grazvydas Ignotas <notasas@gmail.com> Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb/phy')
-rw-r--r--drivers/usb/phy/phy-twl4030-usb.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/usb/phy/phy-twl4030-usb.c b/drivers/usb/phy/phy-twl4030-usb.c
index 7ff67ce373dc..f4ec53a58103 100644
--- a/drivers/usb/phy/phy-twl4030-usb.c
+++ b/drivers/usb/phy/phy-twl4030-usb.c
@@ -498,12 +498,6 @@ static irqreturn_t twl4030_usb_irq(int irq, void *_twl)
498 * USB_LINK_VBUS state. musb_hdrc won't care until it 498 * USB_LINK_VBUS state. musb_hdrc won't care until it
499 * starts to handle softconnect right. 499 * starts to handle softconnect right.
500 */ 500 */
501 if (status == OMAP_MUSB_VBUS_OFF ||
502 status == OMAP_MUSB_ID_FLOAT)
503 twl4030_phy_suspend(twl, 0);
504 else
505 twl4030_phy_resume(twl);
506
507 omap_musb_mailbox(twl->linkstat); 501 omap_musb_mailbox(twl->linkstat);
508 } 502 }
509 sysfs_notify(&twl->dev->kobj, NULL, "vbus"); 503 sysfs_notify(&twl->dev->kobj, NULL, "vbus");