diff options
author | Alan Stern <stern@rowland.harvard.edu> | 2013-05-29 13:21:01 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-05-30 08:34:29 -0400 |
commit | 8a1ea51f87a6149c3263a63e9c60d852bedbecd7 (patch) | |
tree | 010bf48bb0172df256677885e4e3a9c35e9bb455 /drivers/usb/musb/musb_host.c | |
parent | e6b0166f2106e087a197c528eb1e465071f5225b (diff) |
USB: MUSB: upgrade the isochronous API
This patch attempts to fix the isochonour API in the musb host
driver. In particular, the urb->start_frame field should always be
set by the driver; it isn't an input parameter.
The simplest way to accomplish this is to treat all URBs as though the
URB_ISO_ASAP flag was set. This won't give the right behavior when an
underrun occurs, but I don't know enough about the musb driver to
handle that case.
Unfortunately, I have no way to test this change.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/musb/musb_host.c')
-rw-r--r-- | drivers/usb/musb/musb_host.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c index 8914dec49f01..85ed11e04f35 100644 --- a/drivers/usb/musb/musb_host.c +++ b/drivers/usb/musb/musb_host.c | |||
@@ -269,8 +269,7 @@ musb_start_urb(struct musb *musb, int is_in, struct musb_qh *qh) | |||
269 | /* FIXME this doesn't implement that scheduling policy ... | 269 | /* FIXME this doesn't implement that scheduling policy ... |
270 | * or handle framecounter wrapping | 270 | * or handle framecounter wrapping |
271 | */ | 271 | */ |
272 | if ((urb->transfer_flags & URB_ISO_ASAP) | 272 | if (1) { /* Always assume URB_ISO_ASAP */ |
273 | || (frame >= urb->start_frame)) { | ||
274 | /* REVISIT the SOF irq handler shouldn't duplicate | 273 | /* REVISIT the SOF irq handler shouldn't duplicate |
275 | * this code; and we don't init urb->start_frame... | 274 | * this code; and we don't init urb->start_frame... |
276 | */ | 275 | */ |