aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/usb/gadget/function/f_uac1.c
diff options
context:
space:
mode:
authorRobert Baldyga <r.baldyga@samsung.com>2015-09-16 06:10:58 -0400
committerFelipe Balbi <balbi@ti.com>2015-09-27 11:54:31 -0400
commit6ae6e1a241c1d7a5c5800d035d195a66911d96f1 (patch)
tree18815bb4ffcc7e9928871f659f643a32a33ed4bc /drivers/usb/gadget/function/f_uac1.c
parentbb38c18adb872714d5b27b0fe2d87c6489cb6275 (diff)
usb: gadget: f_uac1: eliminate abuse of ep->driver data
Since ep->driver_data is not used for endpoint claiming, neither for enabled/disabled state storing, we can reduce number of places where we read or modify it's value, as now it has no particular meaning for function or framework logic. In case of f_uac1, ep->driver_data was used only for endpoint claiming and marking endpoints as enabled, so we can simplify code by reducing it. Signed-off-by: Robert Baldyga <r.baldyga@samsung.com> Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb/gadget/function/f_uac1.c')
-rw-r--r--drivers/usb/gadget/function/f_uac1.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/usb/gadget/function/f_uac1.c b/drivers/usb/gadget/function/f_uac1.c
index 7856b3394494..8ee701924d29 100644
--- a/drivers/usb/gadget/function/f_uac1.c
+++ b/drivers/usb/gadget/function/f_uac1.c
@@ -593,7 +593,6 @@ static int f_audio_set_alt(struct usb_function *f, unsigned intf, unsigned alt)
593 return err; 593 return err;
594 594
595 usb_ep_enable(out_ep); 595 usb_ep_enable(out_ep);
596 out_ep->driver_data = audio;
597 audio->copy_buf = f_audio_buffer_alloc(audio_buf_size); 596 audio->copy_buf = f_audio_buffer_alloc(audio_buf_size);
598 if (IS_ERR(audio->copy_buf)) 597 if (IS_ERR(audio->copy_buf))
599 return -ENOMEM; 598 return -ENOMEM;
@@ -718,7 +717,6 @@ f_audio_bind(struct usb_configuration *c, struct usb_function *f)
718 goto fail; 717 goto fail;
719 audio->out_ep = ep; 718 audio->out_ep = ep;
720 audio->out_ep->desc = &as_out_ep_desc; 719 audio->out_ep->desc = &as_out_ep_desc;
721 ep->driver_data = cdev; /* claim */
722 720
723 status = -ENOMEM; 721 status = -ENOMEM;
724 722
@@ -730,8 +728,6 @@ f_audio_bind(struct usb_configuration *c, struct usb_function *f)
730 728
731fail: 729fail:
732 gaudio_cleanup(&audio->card); 730 gaudio_cleanup(&audio->card);
733 if (ep)
734 ep->driver_data = NULL;
735 return status; 731 return status;
736} 732}
737 733