diff options
author | Max Lohrmann <post@wickenrode.com> | 2017-03-08 01:09:56 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-03-26 07:05:58 -0400 |
commit | 033850b953004b7398466effbaec77bc2e404f6f (patch) | |
tree | 340b113e7cf9cdcc8a2575e63343c15acecde6fc /drivers/target | |
parent | de1ff848c74fcc5b172323c1d5fac88dc1ab0281 (diff) |
target: Fix VERIFY_16 handling in sbc_parse_cdb
commit 13603685c1f12c67a7a2427f00b63f39a2b6f7c9 upstream.
As reported by Max, the Windows 2008 R2 chkdsk utility expects
VERIFY_16 to be supported, and does not handle the returned
CHECK_CONDITION properly, resulting in an infinite loop.
The kernel will log huge amounts of this error:
kernel: TARGET_CORE[iSCSI]: Unsupported SCSI Opcode 0x8f, sending
CHECK_CONDITION.
Signed-off-by: Max Lohrmann <post@wickenrode.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/target')
-rw-r--r-- | drivers/target/target_core_sbc.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/drivers/target/target_core_sbc.c b/drivers/target/target_core_sbc.c index aabd6602da6c..a53fb23a0411 100644 --- a/drivers/target/target_core_sbc.c +++ b/drivers/target/target_core_sbc.c | |||
@@ -1104,9 +1104,15 @@ sbc_parse_cdb(struct se_cmd *cmd, struct sbc_ops *ops) | |||
1104 | return ret; | 1104 | return ret; |
1105 | break; | 1105 | break; |
1106 | case VERIFY: | 1106 | case VERIFY: |
1107 | case VERIFY_16: | ||
1107 | size = 0; | 1108 | size = 0; |
1108 | sectors = transport_get_sectors_10(cdb); | 1109 | if (cdb[0] == VERIFY) { |
1109 | cmd->t_task_lba = transport_lba_32(cdb); | 1110 | sectors = transport_get_sectors_10(cdb); |
1111 | cmd->t_task_lba = transport_lba_32(cdb); | ||
1112 | } else { | ||
1113 | sectors = transport_get_sectors_16(cdb); | ||
1114 | cmd->t_task_lba = transport_lba_64(cdb); | ||
1115 | } | ||
1110 | cmd->execute_cmd = sbc_emulate_noop; | 1116 | cmd->execute_cmd = sbc_emulate_noop; |
1111 | goto check_lba; | 1117 | goto check_lba; |
1112 | case REZERO_UNIT: | 1118 | case REZERO_UNIT: |