target: Only reset specific dynamic entries during lun_group creation

This patch changes core_tpg_add_node_to_devs() to avoid unnecessarly
resetting every se_dev_entry in se_node_acl->tpg_lun_hlist when the
operation is driven by an explicit configfs se_lun->lun_group creation
via core_dev_add_lun() to only update a single se_lun.

Otherwise for the second core_tpg_check_initiator_node_acl() case, go
ahead and continue to scan the full set of currently active se_lun in
se_portal_group->tpg_lun_hlist.

Reviewed-by: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagig@mellanox.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

1 files changed, 5 insertions, 2 deletions

diff --git a/drivers/target/target_core_tpg.c b/drivers/target/target_core_tpg.c
index 73c25bda5a25..f66c208386f8 100644
--- a/drivers/target/target_core_tpg.c
+++ b/drivers/target/target_core_tpg.c
@@ -89,7 +89,8 @@ EXPORT_SYMBOL(core_tpg_get_initiator_node_acl);
  */
 void core_tpg_add_node_to_devs(
         struct se_node_acl *acl,
-        struct se_portal_group *tpg)
+        struct se_portal_group *tpg,
+        struct se_lun *lun_orig)
 {
         u32 lun_access = 0;
         struct se_lun *lun;
@@ -99,6 +100,8 @@ void core_tpg_add_node_to_devs(
         hlist_for_each_entry_rcu(lun, &tpg->tpg_lun_hlist, link) {
                 if (lun->lun_status != TRANSPORT_LUN_STATUS_ACTIVE)
                         continue;
+                if (lun_orig && lun != lun_orig)
+                        continue;
 
                 dev = lun->lun_se_dev;
                 /*
@@ -238,7 +241,7 @@ struct se_node_acl *core_tpg_check_initiator_node_acl(
          */
         if ((tpg->se_tpg_tfo->tpg_check_demo_mode_login_only == NULL) ||
             (tpg->se_tpg_tfo->tpg_check_demo_mode_login_only(tpg) != 1))
-                core_tpg_add_node_to_devs(acl, tpg);
+                core_tpg_add_node_to_devs(acl, tpg, NULL);
 
         target_add_node_acl(acl);
         return acl;