diff options
author | Ivan Safonov <insafonov@gmail.com> | 2016-09-18 13:23:42 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-09-20 07:33:48 -0400 |
commit | 43969aa7e8506765412087f5c1fc5ae4f0fe5d9a (patch) | |
tree | 6c1b09b6c2496bef058cdf8d4653fcb3e0efe110 /drivers/staging | |
parent | d37843d1a956bf87e219067a0f45bc82db260216 (diff) |
staging: r8188eu: change last argument type of the usb_write_port function
usb_write_port writes only xmit_buf object data to device.
In addition, an appropriate name for this argument is used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging')
-rw-r--r-- | drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c | 4 | ||||
-rw-r--r-- | drivers/staging/rtl8188eu/include/usb_ops_linux.h | 2 | ||||
-rw-r--r-- | drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 29 |
3 files changed, 17 insertions, 18 deletions
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c b/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c index 3e6f5ca5e5c2..5482f479907c 100644 --- a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c +++ b/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c | |||
@@ -387,7 +387,7 @@ static s32 rtw_dump_xframe(struct adapter *adapt, struct xmit_frame *pxmitframe) | |||
387 | } | 387 | } |
388 | ff_hwaddr = rtw_get_ff_hwaddr(pxmitframe); | 388 | ff_hwaddr = rtw_get_ff_hwaddr(pxmitframe); |
389 | 389 | ||
390 | inner_ret = usb_write_port(adapt, ff_hwaddr, w_sz, (unsigned char *)pxmitbuf); | 390 | inner_ret = usb_write_port(adapt, ff_hwaddr, w_sz, pxmitbuf); |
391 | 391 | ||
392 | rtw_count_tx_stats(adapt, pxmitframe, sz); | 392 | rtw_count_tx_stats(adapt, pxmitframe, sz); |
393 | 393 | ||
@@ -592,7 +592,7 @@ s32 rtl8188eu_xmitframe_complete(struct adapter *adapt, struct xmit_priv *pxmitp | |||
592 | 592 | ||
593 | /* 3 4. write xmit buffer to USB FIFO */ | 593 | /* 3 4. write xmit buffer to USB FIFO */ |
594 | ff_hwaddr = rtw_get_ff_hwaddr(pfirstframe); | 594 | ff_hwaddr = rtw_get_ff_hwaddr(pfirstframe); |
595 | usb_write_port(adapt, ff_hwaddr, pbuf_tail, (u8 *)pxmitbuf); | 595 | usb_write_port(adapt, ff_hwaddr, pbuf_tail, pxmitbuf); |
596 | 596 | ||
597 | /* 3 5. update statisitc */ | 597 | /* 3 5. update statisitc */ |
598 | pbuf_tail -= (pfirstframe->agg_num * TXDESC_SIZE); | 598 | pbuf_tail -= (pfirstframe->agg_num * TXDESC_SIZE); |
diff --git a/drivers/staging/rtl8188eu/include/usb_ops_linux.h b/drivers/staging/rtl8188eu/include/usb_ops_linux.h index 220733314f8b..fde7753916ee 100644 --- a/drivers/staging/rtl8188eu/include/usb_ops_linux.h +++ b/drivers/staging/rtl8188eu/include/usb_ops_linux.h | |||
@@ -75,7 +75,7 @@ int usb_write8(struct adapter *adapter, u32 addr, u8 val); | |||
75 | int usb_write16(struct adapter *adapter, u32 addr, u16 val); | 75 | int usb_write16(struct adapter *adapter, u32 addr, u16 val); |
76 | int usb_write32(struct adapter *adapter, u32 addr, u32 val); | 76 | int usb_write32(struct adapter *adapter, u32 addr, u32 val); |
77 | 77 | ||
78 | u32 usb_write_port(struct adapter *adapter, u32 addr, u32 cnt, u8 *pmem); | 78 | u32 usb_write_port(struct adapter *adapter, u32 addr, u32 cnt, struct xmit_buf *pmem); |
79 | void usb_write_port_cancel(struct adapter *adapter); | 79 | void usb_write_port_cancel(struct adapter *adapter); |
80 | 80 | ||
81 | #endif | 81 | #endif |
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c index 9359cc7c7a49..52fa65980661 100644 --- a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c +++ b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | |||
@@ -693,7 +693,7 @@ check_completion: | |||
693 | tasklet_hi_schedule(&pxmitpriv->xmit_tasklet); | 693 | tasklet_hi_schedule(&pxmitpriv->xmit_tasklet); |
694 | } | 694 | } |
695 | 695 | ||
696 | u32 usb_write_port(struct adapter *padapter, u32 addr, u32 cnt, u8 *wmem) | 696 | u32 usb_write_port(struct adapter *padapter, u32 addr, u32 cnt, struct xmit_buf *xmitbuf) |
697 | { | 697 | { |
698 | unsigned long irqL; | 698 | unsigned long irqL; |
699 | unsigned int pipe; | 699 | unsigned int pipe; |
@@ -702,8 +702,7 @@ u32 usb_write_port(struct adapter *padapter, u32 addr, u32 cnt, u8 *wmem) | |||
702 | struct urb *purb = NULL; | 702 | struct urb *purb = NULL; |
703 | struct dvobj_priv *pdvobj = adapter_to_dvobj(padapter); | 703 | struct dvobj_priv *pdvobj = adapter_to_dvobj(padapter); |
704 | struct xmit_priv *pxmitpriv = &padapter->xmitpriv; | 704 | struct xmit_priv *pxmitpriv = &padapter->xmitpriv; |
705 | struct xmit_buf *pxmitbuf = (struct xmit_buf *)wmem; | 705 | struct xmit_frame *pxmitframe = (struct xmit_frame *)xmitbuf->priv_data; |
706 | struct xmit_frame *pxmitframe = (struct xmit_frame *)pxmitbuf->priv_data; | ||
707 | struct usb_device *pusbd = pdvobj->pusbdev; | 706 | struct usb_device *pusbd = pdvobj->pusbdev; |
708 | 707 | ||
709 | 708 | ||
@@ -713,7 +712,7 @@ u32 usb_write_port(struct adapter *padapter, u32 addr, u32 cnt, u8 *wmem) | |||
713 | (padapter->pwrctrlpriv.pnp_bstop_trx)) { | 712 | (padapter->pwrctrlpriv.pnp_bstop_trx)) { |
714 | RT_TRACE(_module_hci_ops_os_c_, _drv_err_, | 713 | RT_TRACE(_module_hci_ops_os_c_, _drv_err_, |
715 | ("usb_write_port:( padapter->bDriverStopped ||padapter->bSurpriseRemoved ||adapter->pwrctrlpriv.pnp_bstop_trx)!!!\n")); | 714 | ("usb_write_port:( padapter->bDriverStopped ||padapter->bSurpriseRemoved ||adapter->pwrctrlpriv.pnp_bstop_trx)!!!\n")); |
716 | rtw_sctx_done_err(&pxmitbuf->sctx, RTW_SCTX_DONE_TX_DENY); | 715 | rtw_sctx_done_err(&xmitbuf->sctx, RTW_SCTX_DONE_TX_DENY); |
717 | goto exit; | 716 | goto exit; |
718 | } | 717 | } |
719 | 718 | ||
@@ -722,44 +721,44 @@ u32 usb_write_port(struct adapter *padapter, u32 addr, u32 cnt, u8 *wmem) | |||
722 | switch (addr) { | 721 | switch (addr) { |
723 | case VO_QUEUE_INX: | 722 | case VO_QUEUE_INX: |
724 | pxmitpriv->voq_cnt++; | 723 | pxmitpriv->voq_cnt++; |
725 | pxmitbuf->flags = VO_QUEUE_INX; | 724 | xmitbuf->flags = VO_QUEUE_INX; |
726 | break; | 725 | break; |
727 | case VI_QUEUE_INX: | 726 | case VI_QUEUE_INX: |
728 | pxmitpriv->viq_cnt++; | 727 | pxmitpriv->viq_cnt++; |
729 | pxmitbuf->flags = VI_QUEUE_INX; | 728 | xmitbuf->flags = VI_QUEUE_INX; |
730 | break; | 729 | break; |
731 | case BE_QUEUE_INX: | 730 | case BE_QUEUE_INX: |
732 | pxmitpriv->beq_cnt++; | 731 | pxmitpriv->beq_cnt++; |
733 | pxmitbuf->flags = BE_QUEUE_INX; | 732 | xmitbuf->flags = BE_QUEUE_INX; |
734 | break; | 733 | break; |
735 | case BK_QUEUE_INX: | 734 | case BK_QUEUE_INX: |
736 | pxmitpriv->bkq_cnt++; | 735 | pxmitpriv->bkq_cnt++; |
737 | pxmitbuf->flags = BK_QUEUE_INX; | 736 | xmitbuf->flags = BK_QUEUE_INX; |
738 | break; | 737 | break; |
739 | case HIGH_QUEUE_INX: | 738 | case HIGH_QUEUE_INX: |
740 | pxmitbuf->flags = HIGH_QUEUE_INX; | 739 | xmitbuf->flags = HIGH_QUEUE_INX; |
741 | break; | 740 | break; |
742 | default: | 741 | default: |
743 | pxmitbuf->flags = MGT_QUEUE_INX; | 742 | xmitbuf->flags = MGT_QUEUE_INX; |
744 | break; | 743 | break; |
745 | } | 744 | } |
746 | 745 | ||
747 | spin_unlock_irqrestore(&pxmitpriv->lock, irqL); | 746 | spin_unlock_irqrestore(&pxmitpriv->lock, irqL); |
748 | 747 | ||
749 | purb = pxmitbuf->pxmit_urb[0]; | 748 | purb = xmitbuf->pxmit_urb[0]; |
750 | 749 | ||
751 | /* translate DMA FIFO addr to pipehandle */ | 750 | /* translate DMA FIFO addr to pipehandle */ |
752 | pipe = ffaddr2pipehdl(pdvobj, addr); | 751 | pipe = ffaddr2pipehdl(pdvobj, addr); |
753 | 752 | ||
754 | usb_fill_bulk_urb(purb, pusbd, pipe, | 753 | usb_fill_bulk_urb(purb, pusbd, pipe, |
755 | pxmitframe->buf_addr, /* pxmitbuf->pbuf */ | 754 | pxmitframe->buf_addr, /* xmitbuf->pbuf */ |
756 | cnt, | 755 | cnt, |
757 | usb_write_port_complete, | 756 | usb_write_port_complete, |
758 | pxmitbuf);/* context is pxmitbuf */ | 757 | xmitbuf);/* context is xmitbuf */ |
759 | 758 | ||
760 | status = usb_submit_urb(purb, GFP_ATOMIC); | 759 | status = usb_submit_urb(purb, GFP_ATOMIC); |
761 | if (status) { | 760 | if (status) { |
762 | rtw_sctx_done_err(&pxmitbuf->sctx, RTW_SCTX_DONE_WRITE_PORT_ERR); | 761 | rtw_sctx_done_err(&xmitbuf->sctx, RTW_SCTX_DONE_WRITE_PORT_ERR); |
763 | DBG_88E("usb_write_port, status =%d\n", status); | 762 | DBG_88E("usb_write_port, status =%d\n", status); |
764 | RT_TRACE(_module_hci_ops_os_c_, _drv_err_, ("usb_write_port(): usb_submit_urb, status =%x\n", status)); | 763 | RT_TRACE(_module_hci_ops_os_c_, _drv_err_, ("usb_write_port(): usb_submit_urb, status =%x\n", status)); |
765 | 764 | ||
@@ -781,7 +780,7 @@ u32 usb_write_port(struct adapter *padapter, u32 addr, u32 cnt, u8 *wmem) | |||
781 | 780 | ||
782 | exit: | 781 | exit: |
783 | if (ret != _SUCCESS) | 782 | if (ret != _SUCCESS) |
784 | rtw_free_xmitbuf(pxmitpriv, pxmitbuf); | 783 | rtw_free_xmitbuf(pxmitpriv, xmitbuf); |
785 | return ret; | 784 | return ret; |
786 | } | 785 | } |
787 | 786 | ||