diff options
author | Sandhya Bankar <bankarsandhya512@gmail.com> | 2016-09-20 05:07:43 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-09-20 07:38:00 -0400 |
commit | 11975c56b6d130970ef31dbcd3f307baec253c18 (patch) | |
tree | 02e35f4ec79ac040139f10a1f3d44d89864b512d /drivers/staging | |
parent | 78f70e6dfeb9d988a3211ac010dc62c22883c1ba (diff) |
Staging: rtl8712: rtl871x_cmd: Use !x instead of x == NULL.
Use !x instead of x == NULL. This patch was found by checkpatch.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging')
-rw-r--r-- | drivers/staging/rtl8712/rtl871x_cmd.c | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c index 51b6959fc9d8..b7ee5e63af33 100644 --- a/drivers/staging/rtl8712/rtl871x_cmd.c +++ b/drivers/staging/rtl8712/rtl871x_cmd.c | |||
@@ -66,13 +66,13 @@ static sint _init_cmd_priv(struct cmd_priv *pcmdpriv) | |||
66 | pcmdpriv->cmd_seq = 1; | 66 | pcmdpriv->cmd_seq = 1; |
67 | pcmdpriv->cmd_allocated_buf = kmalloc(MAX_CMDSZ + CMDBUFF_ALIGN_SZ, | 67 | pcmdpriv->cmd_allocated_buf = kmalloc(MAX_CMDSZ + CMDBUFF_ALIGN_SZ, |
68 | GFP_ATOMIC); | 68 | GFP_ATOMIC); |
69 | if (pcmdpriv->cmd_allocated_buf == NULL) | 69 | if (!pcmdpriv->cmd_allocated_buf) |
70 | return _FAIL; | 70 | return _FAIL; |
71 | pcmdpriv->cmd_buf = pcmdpriv->cmd_allocated_buf + CMDBUFF_ALIGN_SZ - | 71 | pcmdpriv->cmd_buf = pcmdpriv->cmd_allocated_buf + CMDBUFF_ALIGN_SZ - |
72 | ((addr_t)(pcmdpriv->cmd_allocated_buf) & | 72 | ((addr_t)(pcmdpriv->cmd_allocated_buf) & |
73 | (CMDBUFF_ALIGN_SZ - 1)); | 73 | (CMDBUFF_ALIGN_SZ - 1)); |
74 | pcmdpriv->rsp_allocated_buf = kmalloc(MAX_RSPSZ + 4, GFP_ATOMIC); | 74 | pcmdpriv->rsp_allocated_buf = kmalloc(MAX_RSPSZ + 4, GFP_ATOMIC); |
75 | if (pcmdpriv->rsp_allocated_buf == NULL) | 75 | if (!pcmdpriv->rsp_allocated_buf) |
76 | return _FAIL; | 76 | return _FAIL; |
77 | pcmdpriv->rsp_buf = pcmdpriv->rsp_allocated_buf + 4 - | 77 | pcmdpriv->rsp_buf = pcmdpriv->rsp_allocated_buf + 4 - |
78 | ((addr_t)(pcmdpriv->rsp_allocated_buf) & 3); | 78 | ((addr_t)(pcmdpriv->rsp_allocated_buf) & 3); |
@@ -88,7 +88,7 @@ static sint _init_evt_priv(struct evt_priv *pevtpriv) | |||
88 | pevtpriv->event_seq = 0; | 88 | pevtpriv->event_seq = 0; |
89 | pevtpriv->evt_allocated_buf = kmalloc(MAX_EVTSZ + 4, GFP_ATOMIC); | 89 | pevtpriv->evt_allocated_buf = kmalloc(MAX_EVTSZ + 4, GFP_ATOMIC); |
90 | 90 | ||
91 | if (pevtpriv->evt_allocated_buf == NULL) | 91 | if (!pevtpriv->evt_allocated_buf) |
92 | return _FAIL; | 92 | return _FAIL; |
93 | pevtpriv->evt_buf = pevtpriv->evt_allocated_buf + 4 - | 93 | pevtpriv->evt_buf = pevtpriv->evt_allocated_buf + 4 - |
94 | ((addr_t)(pevtpriv->evt_allocated_buf) & 3); | 94 | ((addr_t)(pevtpriv->evt_allocated_buf) & 3); |
@@ -123,7 +123,7 @@ static sint _enqueue_cmd(struct __queue *queue, struct cmd_obj *obj) | |||
123 | { | 123 | { |
124 | unsigned long irqL; | 124 | unsigned long irqL; |
125 | 125 | ||
126 | if (obj == NULL) | 126 | if (!obj) |
127 | return _SUCCESS; | 127 | return _SUCCESS; |
128 | spin_lock_irqsave(&queue->lock, irqL); | 128 | spin_lock_irqsave(&queue->lock, irqL); |
129 | list_add_tail(&obj->list, &queue->queue); | 129 | list_add_tail(&obj->list, &queue->queue); |
@@ -181,7 +181,7 @@ u32 r8712_enqueue_cmd_ex(struct cmd_priv *pcmdpriv, struct cmd_obj *obj) | |||
181 | unsigned long irqL; | 181 | unsigned long irqL; |
182 | struct __queue *queue; | 182 | struct __queue *queue; |
183 | 183 | ||
184 | if (obj == NULL) | 184 | if (!obj) |
185 | return _SUCCESS; | 185 | return _SUCCESS; |
186 | if (pcmdpriv->padapter->eeprompriv.bautoload_fail_flag) | 186 | if (pcmdpriv->padapter->eeprompriv.bautoload_fail_flag) |
187 | return _FAIL; | 187 | return _FAIL; |
@@ -477,7 +477,7 @@ u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnetwork) | |||
477 | } | 477 | } |
478 | } | 478 | } |
479 | psecnetwork = &psecuritypriv->sec_bss; | 479 | psecnetwork = &psecuritypriv->sec_bss; |
480 | if (psecnetwork == NULL) { | 480 | if (!psecnetwork) { |
481 | kfree(pcmd); | 481 | kfree(pcmd); |
482 | return _FAIL; | 482 | return _FAIL; |
483 | } | 483 | } |
@@ -884,16 +884,16 @@ void r8712_createbss_cmd_callback(struct _adapter *padapter, | |||
884 | if (!psta) { | 884 | if (!psta) { |
885 | psta = r8712_alloc_stainfo(&padapter->stapriv, | 885 | psta = r8712_alloc_stainfo(&padapter->stapriv, |
886 | pnetwork->MacAddress); | 886 | pnetwork->MacAddress); |
887 | if (psta == NULL) | 887 | if (!psta) |
888 | goto createbss_cmd_fail; | 888 | goto createbss_cmd_fail; |
889 | } | 889 | } |
890 | r8712_indicate_connect(padapter); | 890 | r8712_indicate_connect(padapter); |
891 | } else { | 891 | } else { |
892 | pwlan = _r8712_alloc_network(pmlmepriv); | 892 | pwlan = _r8712_alloc_network(pmlmepriv); |
893 | if (pwlan == NULL) { | 893 | if (!pwlan) { |
894 | pwlan = r8712_get_oldest_wlan_network( | 894 | pwlan = r8712_get_oldest_wlan_network( |
895 | &pmlmepriv->scanned_queue); | 895 | &pmlmepriv->scanned_queue); |
896 | if (pwlan == NULL) | 896 | if (!pwlan) |
897 | goto createbss_cmd_fail; | 897 | goto createbss_cmd_fail; |
898 | pwlan->last_scanned = jiffies; | 898 | pwlan->last_scanned = jiffies; |
899 | } else | 899 | } else |
@@ -925,7 +925,7 @@ void r8712_setstaKey_cmdrsp_callback(struct _adapter *padapter, | |||
925 | struct sta_info *psta = r8712_get_stainfo(pstapriv, | 925 | struct sta_info *psta = r8712_get_stainfo(pstapriv, |
926 | psetstakey_rsp->addr); | 926 | psetstakey_rsp->addr); |
927 | 927 | ||
928 | if (psta == NULL) | 928 | if (!psta) |
929 | goto exit; | 929 | goto exit; |
930 | psta->aid = psta->mac_id = psetstakey_rsp->keyid; /*CAM_ID(CAM_ENTRY)*/ | 930 | psta->aid = psta->mac_id = psetstakey_rsp->keyid; /*CAM_ID(CAM_ENTRY)*/ |
931 | exit: | 931 | exit: |
@@ -945,7 +945,7 @@ void r8712_setassocsta_cmdrsp_callback(struct _adapter *padapter, | |||
945 | struct sta_info *psta = r8712_get_stainfo(pstapriv, | 945 | struct sta_info *psta = r8712_get_stainfo(pstapriv, |
946 | passocsta_parm->addr); | 946 | passocsta_parm->addr); |
947 | 947 | ||
948 | if (psta == NULL) | 948 | if (!psta) |
949 | return; | 949 | return; |
950 | psta->aid = psta->mac_id = passocsta_rsp->cam_id; | 950 | psta->aid = psta->mac_id = passocsta_rsp->cam_id; |
951 | spin_lock_irqsave(&pmlmepriv->lock, irqL); | 951 | spin_lock_irqsave(&pmlmepriv->lock, irqL); |