diff options
author | Sebastian Herbszt <herbszt@gmx.de> | 2016-04-17 07:27:27 -0400 |
---|---|---|
committer | Martin K. Petersen <martin.petersen@oracle.com> | 2016-04-25 22:06:49 -0400 |
commit | 718924180a6a79afa558bd978c8a3436c39691ff (patch) | |
tree | 8364ede548680480d951dbfb43cae53d615c2f1c /drivers/scsi | |
parent | 9c8a76d5f00dbfd1da6ea242a9263a47133e4053 (diff) |
lpfc: remove incorrect lockdep assertion
Remove incorrect lockdep assertion from lpfc_sli_hbqbuf_find() which
acquires the hbalock itself. Fix the comment which resulted in this
mistake.
Fixes: 1c2ba475eb0e ("lpfc: Add lockdep assertions")
Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi')
-rw-r--r-- | drivers/scsi/lpfc/lpfc_sli.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index 6b267b67f845..70edf21ae1b9 100644 --- a/drivers/scsi/lpfc/lpfc_sli.c +++ b/drivers/scsi/lpfc/lpfc_sli.c | |||
@@ -2000,10 +2000,9 @@ lpfc_sli_hbqbuf_get(struct list_head *rb_list) | |||
2000 | * @phba: Pointer to HBA context object. | 2000 | * @phba: Pointer to HBA context object. |
2001 | * @tag: Tag of the hbq buffer. | 2001 | * @tag: Tag of the hbq buffer. |
2002 | * | 2002 | * |
2003 | * This function is called with hbalock held. This function searches | 2003 | * This function searches for the hbq buffer associated with the given tag in |
2004 | * for the hbq buffer associated with the given tag in the hbq buffer | 2004 | * the hbq buffer list. If it finds the hbq buffer, it returns the hbq_buffer |
2005 | * list. If it finds the hbq buffer, it returns the hbq_buffer other wise | 2005 | * otherwise it returns NULL. |
2006 | * it returns NULL. | ||
2007 | **/ | 2006 | **/ |
2008 | static struct hbq_dmabuf * | 2007 | static struct hbq_dmabuf * |
2009 | lpfc_sli_hbqbuf_find(struct lpfc_hba *phba, uint32_t tag) | 2008 | lpfc_sli_hbqbuf_find(struct lpfc_hba *phba, uint32_t tag) |
@@ -2012,8 +2011,6 @@ lpfc_sli_hbqbuf_find(struct lpfc_hba *phba, uint32_t tag) | |||
2012 | struct hbq_dmabuf *hbq_buf; | 2011 | struct hbq_dmabuf *hbq_buf; |
2013 | uint32_t hbqno; | 2012 | uint32_t hbqno; |
2014 | 2013 | ||
2015 | lockdep_assert_held(&phba->hbalock); | ||
2016 | |||
2017 | hbqno = tag >> 16; | 2014 | hbqno = tag >> 16; |
2018 | if (hbqno >= LPFC_MAX_HBQS) | 2015 | if (hbqno >= LPFC_MAX_HBQS) |
2019 | return NULL; | 2016 | return NULL; |