aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/scsi
diff options
context:
space:
mode:
authorJohannes Thumshirn <jthumshirn@suse.de>2016-08-03 09:00:18 -0400
committerMartin K. Petersen <martin.petersen@oracle.com>2016-08-08 21:27:13 -0400
commit0d667f72b2a20bbac72bec0ab11467fc70bb0f1f (patch)
treedd902103343c1e2a1a2a1630c704d5fd87d48340 /drivers/scsi
parent8bbb1cf63f5e345685d42749606d0474cfde6def (diff)
mpt3sas: Don't spam logs if logging level is 0
In _scsih_io_done() we test if the ioc->logging_level does _not_ have the MPT_DEBUG_REPLY bit set and if it hasn't we print the debug messages. This unfortunately is the wrong way around. Note, the actual bug is older than af0094115 but this commit removed the CONFIG_SCSI_MPT3SAS_LOGGING Kconfig option which hid the bug. Fixes: af0094115 'mpt2sas, mpt3sas: Remove SCSI_MPTXSAS_LOGGING entry from Kconfig' Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de> Acked-by: Chaitra P B <chaitra.basappa@broadcom.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi')
-rw-r--r--drivers/scsi/mpt3sas/mpt3sas_scsih.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
index 7732e3ef2db7..209a969a979d 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
@@ -4692,7 +4692,7 @@ _scsih_io_done(struct MPT3SAS_ADAPTER *ioc, u16 smid, u8 msix_index, u32 reply)
4692 le16_to_cpu(mpi_reply->DevHandle)); 4692 le16_to_cpu(mpi_reply->DevHandle));
4693 mpt3sas_trigger_scsi(ioc, data.skey, data.asc, data.ascq); 4693 mpt3sas_trigger_scsi(ioc, data.skey, data.asc, data.ascq);
4694 4694
4695 if (!(ioc->logging_level & MPT_DEBUG_REPLY) && 4695 if ((ioc->logging_level & MPT_DEBUG_REPLY) &&
4696 ((scmd->sense_buffer[2] == UNIT_ATTENTION) || 4696 ((scmd->sense_buffer[2] == UNIT_ATTENTION) ||
4697 (scmd->sense_buffer[2] == MEDIUM_ERROR) || 4697 (scmd->sense_buffer[2] == MEDIUM_ERROR) ||
4698 (scmd->sense_buffer[2] == HARDWARE_ERROR))) 4698 (scmd->sense_buffer[2] == HARDWARE_ERROR)))