scsi: remove abuses of scsi_populate_tag

Unless we want to build a SPI tag message we should just check SCMD_TAGGED
instead of reverse engineering a tag type through the use of
scsi_populate_tag_msg.

Also rename the function to spi_populate_tag_msg, make it behave like the
other spi message helpers, and move it to the spi transport class.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Reviewed-by: Hannes Reinecke <hare@suse.de>

1 files changed, 0 insertions, 10 deletions

diff --git a/drivers/scsi/qla4xxx/ql4_iocb.c b/drivers/scsi/qla4xxx/ql4_iocb.c
index 08ab6dac226d..17222eb49762 100644
--- a/drivers/scsi/qla4xxx/ql4_iocb.c
+++ b/drivers/scsi/qla4xxx/ql4_iocb.c
@@ -280,7 +280,6 @@ int qla4xxx_send_command_to_isp(struct scsi_qla_host *ha, struct srb * srb)
         uint16_t req_cnt;
         unsigned long flags;
         uint32_t index;
-        char tag[2];
 
         /* Get real lun and adapter */
         ddb_entry = srb->ddb;
@@ -352,15 +351,6 @@ int qla4xxx_send_command_to_isp(struct scsi_qla_host *ha, struct srb * srb)
 
         /* Set tagged queueing control flags */
         cmd_entry->control_flags |= CF_SIMPLE_TAG;
-        if (scsi_populate_tag_msg(cmd, tag))
-                switch (tag[0]) {
-                case MSG_HEAD_TAG:
-                        cmd_entry->control_flags |= CF_HEAD_TAG;
-                        break;
-                case MSG_ORDERED_TAG:
-                        cmd_entry->control_flags |= CF_ORDERED_TAG;
-                        break;
-                }
 
         qla4xxx_advance_req_ring_ptr(ha);
         qla4xxx_build_scsi_iocbs(srb, cmd_entry, tot_dsds);