aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/scsi/mvumi.c
diff options
context:
space:
mode:
authorJoe Perches <joe@perches.com>2014-08-08 17:24:46 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2014-08-08 18:57:29 -0400
commit7c845eb5e184977d9c7135ae20d012b59f8cc729 (patch)
tree71115a1f8b3528722917faf589171a4c690547ea /drivers/scsi/mvumi.c
parent8ac41b9dc719b4a5c65a2192988e8199278bb71a (diff)
scsi: use pci_zalloc_consistent
Remove the now unnecessary memset too. Signed-off-by: Joe Perches <joe@perches.com> Cc: Adam Radford <linuxraid@lsi.com> Cc: "James E.J. Bottomley" <JBottomley@parallels.com> Cc: Jayamohan Kallickal <jayamohan.kallickal@emulex.com> Cc: Dario Ballabio <ballabio_dario@emc.com> Cc: Michael Neuffer <mike@i-Connect.Net> Cc: "Stephen M. Cameron" <scameron@beardog.cce.hp.com> Cc: Neela Syam Kolli <megaraidlinux@lsi.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/scsi/mvumi.c')
-rw-r--r--drivers/scsi/mvumi.c9
1 files changed, 3 insertions, 6 deletions
diff --git a/drivers/scsi/mvumi.c b/drivers/scsi/mvumi.c
index edbee8dc62c9..3e716b2f611a 100644
--- a/drivers/scsi/mvumi.c
+++ b/drivers/scsi/mvumi.c
@@ -142,8 +142,8 @@ static struct mvumi_res *mvumi_alloc_mem_resource(struct mvumi_hba *mhba,
142 142
143 case RESOURCE_UNCACHED_MEMORY: 143 case RESOURCE_UNCACHED_MEMORY:
144 size = round_up(size, 8); 144 size = round_up(size, 8);
145 res->virt_addr = pci_alloc_consistent(mhba->pdev, size, 145 res->virt_addr = pci_zalloc_consistent(mhba->pdev, size,
146 &res->bus_addr); 146 &res->bus_addr);
147 if (!res->virt_addr) { 147 if (!res->virt_addr) {
148 dev_err(&mhba->pdev->dev, 148 dev_err(&mhba->pdev->dev,
149 "unable to allocate consistent mem," 149 "unable to allocate consistent mem,"
@@ -151,7 +151,6 @@ static struct mvumi_res *mvumi_alloc_mem_resource(struct mvumi_hba *mhba,
151 kfree(res); 151 kfree(res);
152 return NULL; 152 return NULL;
153 } 153 }
154 memset(res->virt_addr, 0, size);
155 break; 154 break;
156 155
157 default: 156 default:
@@ -258,12 +257,10 @@ static int mvumi_internal_cmd_sgl(struct mvumi_hba *mhba, struct mvumi_cmd *cmd,
258 if (size == 0) 257 if (size == 0)
259 return 0; 258 return 0;
260 259
261 virt_addr = pci_alloc_consistent(mhba->pdev, size, &phy_addr); 260 virt_addr = pci_zalloc_consistent(mhba->pdev, size, &phy_addr);
262 if (!virt_addr) 261 if (!virt_addr)
263 return -1; 262 return -1;
264 263
265 memset(virt_addr, 0, size);
266
267 m_sg = (struct mvumi_sgl *) &cmd->frame->payload[0]; 264 m_sg = (struct mvumi_sgl *) &cmd->frame->payload[0];
268 cmd->frame->sg_counts = 1; 265 cmd->frame->sg_counts = 1;
269 cmd->data_buf = virt_addr; 266 cmd->data_buf = virt_addr;