diff options
author | Christoph Hellwig <hch@lst.de> | 2014-11-13 08:25:11 -0500 |
---|---|---|
committer | Christoph Hellwig <hch@lst.de> | 2014-11-24 08:45:12 -0500 |
commit | c40ecc12cfdb630332198a04e2832ae8218a61f1 (patch) | |
tree | 881456a7d46ca017dba4cc003e2fe1be427614fc /drivers/s390 | |
parent | 89dac7bb3b0494685241369951f95494e86ee61f (diff) |
scsi: avoid ->change_queue_depth indirection for queue full tracking
All drivers use the implementation for ramping the queue up and down, so
instead of overloading the change_queue_depth method call the
implementation diretly if the driver opts into it by setting the
track_queue_depth flag in the host template.
Note that a few drivers validated the new queue depth in their
change_queue_depth method, but as we never go over the queue depth
set during slave_configure or the sysfs file this isn't nessecary
and can safely be removed.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Venkatesh Srinivas <venkateshs@google.com>
Diffstat (limited to 'drivers/s390')
-rw-r--r-- | drivers/s390/scsi/zfcp_scsi.c | 15 |
1 files changed, 2 insertions, 13 deletions
diff --git a/drivers/s390/scsi/zfcp_scsi.c b/drivers/s390/scsi/zfcp_scsi.c index b5dfa51f396f..179bf3d8af6c 100644 --- a/drivers/s390/scsi/zfcp_scsi.c +++ b/drivers/s390/scsi/zfcp_scsi.c | |||
@@ -35,19 +35,7 @@ MODULE_PARM_DESC(allow_lun_scan, "For NPIV, scan and attach all storage LUNs"); | |||
35 | static int zfcp_scsi_change_queue_depth(struct scsi_device *sdev, int depth, | 35 | static int zfcp_scsi_change_queue_depth(struct scsi_device *sdev, int depth, |
36 | int reason) | 36 | int reason) |
37 | { | 37 | { |
38 | switch (reason) { | 38 | scsi_adjust_queue_depth(sdev, depth); |
39 | case SCSI_QDEPTH_DEFAULT: | ||
40 | scsi_adjust_queue_depth(sdev, depth); | ||
41 | break; | ||
42 | case SCSI_QDEPTH_QFULL: | ||
43 | scsi_track_queue_full(sdev, depth); | ||
44 | break; | ||
45 | case SCSI_QDEPTH_RAMP_UP: | ||
46 | scsi_adjust_queue_depth(sdev, depth); | ||
47 | break; | ||
48 | default: | ||
49 | return -EOPNOTSUPP; | ||
50 | } | ||
51 | return sdev->queue_depth; | 39 | return sdev->queue_depth; |
52 | } | 40 | } |
53 | 41 | ||
@@ -320,6 +308,7 @@ static struct scsi_host_template zfcp_scsi_host_template = { | |||
320 | .use_clustering = 1, | 308 | .use_clustering = 1, |
321 | .shost_attrs = zfcp_sysfs_shost_attrs, | 309 | .shost_attrs = zfcp_sysfs_shost_attrs, |
322 | .sdev_attrs = zfcp_sysfs_sdev_attrs, | 310 | .sdev_attrs = zfcp_sysfs_sdev_attrs, |
311 | .track_queue_depth = 1, | ||
323 | }; | 312 | }; |
324 | 313 | ||
325 | /** | 314 | /** |