aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/rtc
diff options
context:
space:
mode:
authorVladimir Zapolskiy <vz@mleia.com>2015-07-26 17:48:29 -0400
committerAlexandre Belloni <alexandre.belloni@free-electrons.com>2015-09-05 07:19:10 -0400
commitf4843b19d2c7b5effd25e2a65b487d02bf55e96f (patch)
treee7e5586424edd7bc3c041fa9de06be41e60cbfe6 /drivers/rtc
parentca7c14d3a1ab1932732c506e32ab5b189b9c0a16 (diff)
rtc: ds1343: clean up ds1343_nvram_read()/ds1343_nvram_write()
The change removes redundant sysfs binary file boundary checks, since this task is already done on caller side in fs/sysfs/file.c Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Diffstat (limited to 'drivers/rtc')
-rw-r--r--drivers/rtc/rtc-ds1343.c12
1 files changed, 0 insertions, 12 deletions
diff --git a/drivers/rtc/rtc-ds1343.c b/drivers/rtc/rtc-ds1343.c
index ae9f997223b1..79a06dd3c185 100644
--- a/drivers/rtc/rtc-ds1343.c
+++ b/drivers/rtc/rtc-ds1343.c
@@ -162,12 +162,6 @@ static ssize_t ds1343_nvram_write(struct file *filp, struct kobject *kobj,
162 struct device *dev = kobj_to_dev(kobj); 162 struct device *dev = kobj_to_dev(kobj);
163 struct ds1343_priv *priv = dev_get_drvdata(dev); 163 struct ds1343_priv *priv = dev_get_drvdata(dev);
164 164
165 if (unlikely(!count))
166 return count;
167
168 if ((count + off) > DS1343_NVRAM_LEN)
169 count = DS1343_NVRAM_LEN - off;
170
171 address = DS1343_NVRAM + off; 165 address = DS1343_NVRAM + off;
172 166
173 ret = regmap_bulk_write(priv->map, address, buf, count); 167 ret = regmap_bulk_write(priv->map, address, buf, count);
@@ -187,12 +181,6 @@ static ssize_t ds1343_nvram_read(struct file *filp, struct kobject *kobj,
187 struct device *dev = kobj_to_dev(kobj); 181 struct device *dev = kobj_to_dev(kobj);
188 struct ds1343_priv *priv = dev_get_drvdata(dev); 182 struct ds1343_priv *priv = dev_get_drvdata(dev);
189 183
190 if (unlikely(!count))
191 return count;
192
193 if ((count + off) > DS1343_NVRAM_LEN)
194 count = DS1343_NVRAM_LEN - off;
195
196 address = DS1343_NVRAM + off; 184 address = DS1343_NVRAM + off;
197 185
198 ret = regmap_bulk_read(priv->map, address, buf, count); 186 ret = regmap_bulk_read(priv->map, address, buf, count);