diff options
author | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2015-07-23 19:01:07 -0400 |
---|---|---|
committer | Alexandre Belloni <alexandre.belloni@free-electrons.com> | 2015-09-05 07:19:07 -0400 |
commit | a17ccd1c6a327e5b468358e8352a6af004261473 (patch) | |
tree | ba35a70e7909a61d0b075d0e34ede51f9d8b189e /drivers/rtc | |
parent | df100c017ea9f1a6a517c3fba84f8507973c004e (diff) |
rtc: switch wakealarm attribute to DEVICE_ATTR_RW
Instead of using older style DEVICE_ATTR for wakealarm attribute let's
switch to using DEVICE_ATTR_RW that ensures consistent across the kernel
permissions on the attribute.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Diffstat (limited to 'drivers/rtc')
-rw-r--r-- | drivers/rtc/rtc-sysfs.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/drivers/rtc/rtc-sysfs.c b/drivers/rtc/rtc-sysfs.c index 2fbc11bb4352..e3ce1dc92b65 100644 --- a/drivers/rtc/rtc-sysfs.c +++ b/drivers/rtc/rtc-sysfs.c | |||
@@ -134,8 +134,7 @@ static struct attribute *rtc_attrs[] = { | |||
134 | ATTRIBUTE_GROUPS(rtc); | 134 | ATTRIBUTE_GROUPS(rtc); |
135 | 135 | ||
136 | static ssize_t | 136 | static ssize_t |
137 | rtc_sysfs_show_wakealarm(struct device *dev, struct device_attribute *attr, | 137 | wakealarm_show(struct device *dev, struct device_attribute *attr, char *buf) |
138 | char *buf) | ||
139 | { | 138 | { |
140 | ssize_t retval; | 139 | ssize_t retval; |
141 | unsigned long alarm; | 140 | unsigned long alarm; |
@@ -159,7 +158,7 @@ rtc_sysfs_show_wakealarm(struct device *dev, struct device_attribute *attr, | |||
159 | } | 158 | } |
160 | 159 | ||
161 | static ssize_t | 160 | static ssize_t |
162 | rtc_sysfs_set_wakealarm(struct device *dev, struct device_attribute *attr, | 161 | wakealarm_store(struct device *dev, struct device_attribute *attr, |
163 | const char *buf, size_t n) | 162 | const char *buf, size_t n) |
164 | { | 163 | { |
165 | ssize_t retval; | 164 | ssize_t retval; |
@@ -221,8 +220,7 @@ rtc_sysfs_set_wakealarm(struct device *dev, struct device_attribute *attr, | |||
221 | retval = rtc_set_alarm(rtc, &alm); | 220 | retval = rtc_set_alarm(rtc, &alm); |
222 | return (retval < 0) ? retval : n; | 221 | return (retval < 0) ? retval : n; |
223 | } | 222 | } |
224 | static DEVICE_ATTR(wakealarm, S_IRUGO | S_IWUSR, | 223 | static DEVICE_ATTR_RW(wakealarm); |
225 | rtc_sysfs_show_wakealarm, rtc_sysfs_set_wakealarm); | ||
226 | 224 | ||
227 | 225 | ||
228 | /* The reason to trigger an alarm with no process watching it (via sysfs) | 226 | /* The reason to trigger an alarm with no process watching it (via sysfs) |