aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/rtc
diff options
context:
space:
mode:
authorVladimir Zapolskiy <vz@mleia.com>2015-07-26 17:48:36 -0400
committerAlexandre Belloni <alexandre.belloni@free-electrons.com>2015-09-05 07:19:10 -0400
commit824625d3926f0caf4753426d2b24a8fc08a406c8 (patch)
treeb5b9fa72fb65f28464c007243ab3759648f85e36 /drivers/rtc
parentecc663c3d0dc181fd15e4d60753024d180fd7e8f (diff)
rtc: tx4939: clean up tx4939_rtc_nvram_read()/tx4939_rtc_nvram_write()
The change removes redundant sysfs binary file boundary checks, since this task is already done on caller side in fs/sysfs/file.c Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Diffstat (limited to 'drivers/rtc')
-rw-r--r--drivers/rtc/rtc-tx4939.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/rtc/rtc-tx4939.c b/drivers/rtc/rtc-tx4939.c
index cb7f94ede516..560d9a5e0225 100644
--- a/drivers/rtc/rtc-tx4939.c
+++ b/drivers/rtc/rtc-tx4939.c
@@ -199,8 +199,7 @@ static ssize_t tx4939_rtc_nvram_read(struct file *filp, struct kobject *kobj,
199 ssize_t count; 199 ssize_t count;
200 200
201 spin_lock_irq(&pdata->lock); 201 spin_lock_irq(&pdata->lock);
202 for (count = 0; size > 0 && pos < TX4939_RTC_REG_RAMSIZE; 202 for (count = 0; count < size; count++) {
203 count++, size--) {
204 __raw_writel(pos++, &rtcreg->adr); 203 __raw_writel(pos++, &rtcreg->adr);
205 *buf++ = __raw_readl(&rtcreg->dat); 204 *buf++ = __raw_readl(&rtcreg->dat);
206 } 205 }
@@ -218,8 +217,7 @@ static ssize_t tx4939_rtc_nvram_write(struct file *filp, struct kobject *kobj,
218 ssize_t count; 217 ssize_t count;
219 218
220 spin_lock_irq(&pdata->lock); 219 spin_lock_irq(&pdata->lock);
221 for (count = 0; size > 0 && pos < TX4939_RTC_REG_RAMSIZE; 220 for (count = 0; count < size; count++) {
222 count++, size--) {
223 __raw_writel(pos++, &rtcreg->adr); 221 __raw_writel(pos++, &rtcreg->adr);
224 __raw_writel(*buf++, &rtcreg->dat); 222 __raw_writel(*buf++, &rtcreg->dat);
225 } 223 }