diff options
author | Axel Lin <axel.lin@gmail.com> | 2011-05-12 01:47:50 -0400 |
---|---|---|
committer | Liam Girdwood <lrg@slimlogic.co.uk> | 2011-05-27 05:49:09 -0400 |
commit | 77fa44d0e10711e899788c58fe53f8f7b18c7f67 (patch) | |
tree | fb2a0313778dd0ade523162506af3a0835e2ccc3 /drivers/regulator/tps65910-regulator.c | |
parent | c01e36dde4632e0a7474fddf0716f1e54f01f13e (diff) |
regulator: Fix desc_id for tps65023/6507x/65910
The desc_id variable should not be a static variable.
The rest of the code assumes the desc_id must less than TPSxxxxx_NUM_REGULATOR.
If we set desc_id to be a static variable, checking the return value of
rdev_get_id() may return error.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Cc: Anuj Aggarwal <anuj.aggarwal@ti.com>
Cc: Graeme Gregory <gg@slimlogic.co.uk>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
Diffstat (limited to 'drivers/regulator/tps65910-regulator.c')
-rw-r--r-- | drivers/regulator/tps65910-regulator.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/regulator/tps65910-regulator.c b/drivers/regulator/tps65910-regulator.c index d461fa7906b8..048ba47e058f 100644 --- a/drivers/regulator/tps65910-regulator.c +++ b/drivers/regulator/tps65910-regulator.c | |||
@@ -604,7 +604,6 @@ static __devinit int tps65910_probe(struct platform_device *pdev) | |||
604 | struct regulator_dev *rdev; | 604 | struct regulator_dev *rdev; |
605 | struct tps65910_reg *pmic; | 605 | struct tps65910_reg *pmic; |
606 | struct tps65910_board *pmic_plat_data; | 606 | struct tps65910_board *pmic_plat_data; |
607 | static int desc_id; | ||
608 | int i, err; | 607 | int i, err; |
609 | 608 | ||
610 | pmic_plat_data = dev_get_platdata(tps65910->dev); | 609 | pmic_plat_data = dev_get_platdata(tps65910->dev); |
@@ -630,7 +629,7 @@ static __devinit int tps65910_probe(struct platform_device *pdev) | |||
630 | pmic->info[i] = info; | 629 | pmic->info[i] = info; |
631 | 630 | ||
632 | pmic->desc[i].name = info->name; | 631 | pmic->desc[i].name = info->name; |
633 | pmic->desc[i].id = desc_id++; | 632 | pmic->desc[i].id = i; |
634 | pmic->desc[i].n_voltages = info->table_len; | 633 | pmic->desc[i].n_voltages = info->table_len; |
635 | 634 | ||
636 | if ((i == TPS65910_REG_VDD1) || (i == TPS65910_REG_VDD2)) | 635 | if ((i == TPS65910_REG_VDD1) || (i == TPS65910_REG_VDD2)) |