aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/power
diff options
context:
space:
mode:
authorIvaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>2016-02-02 07:47:37 -0500
committerSebastian Reichel <sre@kernel.org>2016-02-21 14:49:34 -0500
commit9aafabc7fece13c8e2a1f680908c73ee19f0f79b (patch)
tree89b50bbe9d863072ea2a9c636a200352839b19a0 /drivers/power
parente35a49b163fa2108cf82c6f07a3fbe371e468878 (diff)
power: bq27xxx_battery: Restore device name
Patch <703df6c09795> ("power: bq27xxx_battery: Reorganize I2C into a module") has removed the device name numbering from bq27xxx_battery_i2c_probe. Fix that by restoring the code. Fixes: 703df6c097956d17a818e63961c82e8e9eef9fef Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> Reviewed-by: Pali Rohár <pali.rohar@gmail.com> Tested-by: Pali Rohár <pali.rohar@gmail.com> Signed-off-by: Sebastian Reichel <sre@kernel.org>
Diffstat (limited to 'drivers/power')
-rw-r--r--drivers/power/bq27xxx_battery_i2c.c37
1 files changed, 34 insertions, 3 deletions
diff --git a/drivers/power/bq27xxx_battery_i2c.c b/drivers/power/bq27xxx_battery_i2c.c
index 9429e66be096..8eafc6f0df88 100644
--- a/drivers/power/bq27xxx_battery_i2c.c
+++ b/drivers/power/bq27xxx_battery_i2c.c
@@ -21,6 +21,9 @@
21 21
22#include <linux/power/bq27xxx_battery.h> 22#include <linux/power/bq27xxx_battery.h>
23 23
24static DEFINE_IDR(battery_id);
25static DEFINE_MUTEX(battery_mutex);
26
24static irqreturn_t bq27xxx_battery_irq_handler_thread(int irq, void *data) 27static irqreturn_t bq27xxx_battery_irq_handler_thread(int irq, void *data)
25{ 28{
26 struct bq27xxx_device_info *di = data; 29 struct bq27xxx_device_info *di = data;
@@ -70,19 +73,33 @@ static int bq27xxx_battery_i2c_probe(struct i2c_client *client,
70{ 73{
71 struct bq27xxx_device_info *di; 74 struct bq27xxx_device_info *di;
72 int ret; 75 int ret;
76 char *name;
77 int num;
78
79 /* Get new ID for the new battery device */
80 mutex_lock(&battery_mutex);
81 num = idr_alloc(&battery_id, client, 0, 0, GFP_KERNEL);
82 mutex_unlock(&battery_mutex);
83 if (num < 0)
84 return num;
85
86 name = devm_kasprintf(&client->dev, GFP_KERNEL, "%s-%d", id->name, num);
87 if (!name)
88 goto err_mem;
73 89
74 di = devm_kzalloc(&client->dev, sizeof(*di), GFP_KERNEL); 90 di = devm_kzalloc(&client->dev, sizeof(*di), GFP_KERNEL);
75 if (!di) 91 if (!di)
76 return -ENOMEM; 92 goto err_mem;
77 93
94 di->id = num;
78 di->dev = &client->dev; 95 di->dev = &client->dev;
79 di->chip = id->driver_data; 96 di->chip = id->driver_data;
80 di->name = id->name; 97 di->name = name;
81 di->bus.read = bq27xxx_battery_i2c_read; 98 di->bus.read = bq27xxx_battery_i2c_read;
82 99
83 ret = bq27xxx_battery_setup(di); 100 ret = bq27xxx_battery_setup(di);
84 if (ret) 101 if (ret)
85 return ret; 102 goto err_failed;
86 103
87 /* Schedule a polling after about 1 min */ 104 /* Schedule a polling after about 1 min */
88 schedule_delayed_work(&di->work, 60 * HZ); 105 schedule_delayed_work(&di->work, 60 * HZ);
@@ -103,6 +120,16 @@ static int bq27xxx_battery_i2c_probe(struct i2c_client *client,
103 } 120 }
104 121
105 return 0; 122 return 0;
123
124err_mem:
125 ret = -ENOMEM;
126
127err_failed:
128 mutex_lock(&battery_mutex);
129 idr_remove(&battery_id, num);
130 mutex_unlock(&battery_mutex);
131
132 return ret;
106} 133}
107 134
108static int bq27xxx_battery_i2c_remove(struct i2c_client *client) 135static int bq27xxx_battery_i2c_remove(struct i2c_client *client)
@@ -111,6 +138,10 @@ static int bq27xxx_battery_i2c_remove(struct i2c_client *client)
111 138
112 bq27xxx_battery_teardown(di); 139 bq27xxx_battery_teardown(di);
113 140
141 mutex_lock(&battery_mutex);
142 idr_remove(&battery_id, di->id);
143 mutex_unlock(&battery_mutex);
144
114 return 0; 145 return 0;
115} 146}
116 147