diff options
author | Krzysztof Kozlowski <k.kozlowski@samsung.com> | 2015-03-12 03:43:59 -0400 |
---|---|---|
committer | Sebastian Reichel <sre@kernel.org> | 2015-03-13 17:52:52 -0400 |
commit | ad774702f1705c04e5fa492b793d8d477a504fa6 (patch) | |
tree | 809fb6906114bcd6a064af018092b9c9857c9932 /drivers/platform | |
parent | 0595439a0a8740f776a0ae367a4c7f243add24ec (diff) |
compal-laptop: Fix leaking hwmon device
The commit c2be45f09bb0 ("compal-laptop: Use
devm_hwmon_device_register_with_groups") wanted to change the
registering of hwmon device to resource-managed version. It mostly did
it except the main thing - it forgot to use devm-like function so the
hwmon device leaked after device removal or probe failure.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Fixes: c2be45f09bb0 ("compal-laptop: Use devm_hwmon_device_register_with_groups")
Cc: <stable@vger.kernel.org>
Acked-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Darren Hart <dvhart@linux.intel.com>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
Diffstat (limited to 'drivers/platform')
-rw-r--r-- | drivers/platform/x86/compal-laptop.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/platform/x86/compal-laptop.c b/drivers/platform/x86/compal-laptop.c index 15c0fab2bfa1..eb9885e7fb0e 100644 --- a/drivers/platform/x86/compal-laptop.c +++ b/drivers/platform/x86/compal-laptop.c | |||
@@ -1026,9 +1026,9 @@ static int compal_probe(struct platform_device *pdev) | |||
1026 | if (err) | 1026 | if (err) |
1027 | return err; | 1027 | return err; |
1028 | 1028 | ||
1029 | hwmon_dev = hwmon_device_register_with_groups(&pdev->dev, | 1029 | hwmon_dev = devm_hwmon_device_register_with_groups(&pdev->dev, |
1030 | "compal", data, | 1030 | "compal", data, |
1031 | compal_hwmon_groups); | 1031 | compal_hwmon_groups); |
1032 | if (IS_ERR(hwmon_dev)) { | 1032 | if (IS_ERR(hwmon_dev)) { |
1033 | err = PTR_ERR(hwmon_dev); | 1033 | err = PTR_ERR(hwmon_dev); |
1034 | goto remove; | 1034 | goto remove; |