diff options
| author | Jonas Gorski <jogo@openwrt.org> | 2015-10-11 11:34:19 -0400 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2015-10-16 16:20:21 -0400 |
| commit | 98c85d583a5dee70d75faed3eb79851dd0a2e2fe (patch) | |
| tree | b26dcc3d711d8531cc7011602eca7037723bd042 /drivers/pinctrl/qcom | |
| parent | 31831f41bfd1e340bad66014a1b7ccd761ee51cf (diff) | |
pinctrl: replace trivial implementations of gpio_chip request/free
Replace all trivial request/free callbacks that do nothing but call into
pinctrl code with the generic versions.
Signed-off-by: Jonas Gorski <jogo@openwrt.org>
Acked-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Acked-by: Heiko Stuebner <heiko@sntech.de>
Acked-by: Eric Anholt <eric@anholt.net>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Andrew Bresticker <abrestic@chromium.org>
Acked-by: Baruch Siach <baruch@tkos.co.il>
Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
Acked-by: Lee Jones <lee@kernel.org>
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/qcom')
| -rw-r--r-- | drivers/pinctrl/qcom/pinctrl-msm.c | 16 | ||||
| -rw-r--r-- | drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 14 | ||||
| -rw-r--r-- | drivers/pinctrl/qcom/pinctrl-spmi-mpp.c | 14 |
3 files changed, 6 insertions, 38 deletions
diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c index a0c7407c1cac..146264a41ec8 100644 --- a/drivers/pinctrl/qcom/pinctrl-msm.c +++ b/drivers/pinctrl/qcom/pinctrl-msm.c | |||
| @@ -458,18 +458,6 @@ static void msm_gpio_set(struct gpio_chip *chip, unsigned offset, int value) | |||
| 458 | spin_unlock_irqrestore(&pctrl->lock, flags); | 458 | spin_unlock_irqrestore(&pctrl->lock, flags); |
| 459 | } | 459 | } |
| 460 | 460 | ||
| 461 | static int msm_gpio_request(struct gpio_chip *chip, unsigned offset) | ||
| 462 | { | ||
| 463 | int gpio = chip->base + offset; | ||
| 464 | return pinctrl_request_gpio(gpio); | ||
| 465 | } | ||
| 466 | |||
| 467 | static void msm_gpio_free(struct gpio_chip *chip, unsigned offset) | ||
| 468 | { | ||
| 469 | int gpio = chip->base + offset; | ||
| 470 | return pinctrl_free_gpio(gpio); | ||
| 471 | } | ||
| 472 | |||
| 473 | #ifdef CONFIG_DEBUG_FS | 461 | #ifdef CONFIG_DEBUG_FS |
| 474 | #include <linux/seq_file.h> | 462 | #include <linux/seq_file.h> |
| 475 | 463 | ||
| @@ -527,8 +515,8 @@ static struct gpio_chip msm_gpio_template = { | |||
| 527 | .direction_output = msm_gpio_direction_output, | 515 | .direction_output = msm_gpio_direction_output, |
| 528 | .get = msm_gpio_get, | 516 | .get = msm_gpio_get, |
| 529 | .set = msm_gpio_set, | 517 | .set = msm_gpio_set, |
| 530 | .request = msm_gpio_request, | 518 | .request = gpiochip_generic_request, |
| 531 | .free = msm_gpio_free, | 519 | .free = gpiochip_generic_free, |
| 532 | .dbg_show = msm_gpio_dbg_show, | 520 | .dbg_show = msm_gpio_dbg_show, |
| 533 | }; | 521 | }; |
| 534 | 522 | ||
diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c index bd1e24598e12..6c42ca14d2fd 100644 --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | |||
| @@ -546,16 +546,6 @@ static void pmic_gpio_set(struct gpio_chip *chip, unsigned pin, int value) | |||
| 546 | pmic_gpio_config_set(state->ctrl, pin, &config, 1); | 546 | pmic_gpio_config_set(state->ctrl, pin, &config, 1); |
| 547 | } | 547 | } |
| 548 | 548 | ||
| 549 | static int pmic_gpio_request(struct gpio_chip *chip, unsigned base) | ||
| 550 | { | ||
| 551 | return pinctrl_request_gpio(chip->base + base); | ||
| 552 | } | ||
| 553 | |||
| 554 | static void pmic_gpio_free(struct gpio_chip *chip, unsigned base) | ||
| 555 | { | ||
| 556 | pinctrl_free_gpio(chip->base + base); | ||
| 557 | } | ||
| 558 | |||
| 559 | static int pmic_gpio_of_xlate(struct gpio_chip *chip, | 549 | static int pmic_gpio_of_xlate(struct gpio_chip *chip, |
| 560 | const struct of_phandle_args *gpio_desc, | 550 | const struct of_phandle_args *gpio_desc, |
| 561 | u32 *flags) | 551 | u32 *flags) |
| @@ -595,8 +585,8 @@ static const struct gpio_chip pmic_gpio_gpio_template = { | |||
| 595 | .direction_output = pmic_gpio_direction_output, | 585 | .direction_output = pmic_gpio_direction_output, |
| 596 | .get = pmic_gpio_get, | 586 | .get = pmic_gpio_get, |
| 597 | .set = pmic_gpio_set, | 587 | .set = pmic_gpio_set, |
| 598 | .request = pmic_gpio_request, | 588 | .request = gpiochip_generic_request, |
| 599 | .free = pmic_gpio_free, | 589 | .free = gpiochip_generic_free, |
| 600 | .of_xlate = pmic_gpio_of_xlate, | 590 | .of_xlate = pmic_gpio_of_xlate, |
| 601 | .to_irq = pmic_gpio_to_irq, | 591 | .to_irq = pmic_gpio_to_irq, |
| 602 | .dbg_show = pmic_gpio_dbg_show, | 592 | .dbg_show = pmic_gpio_dbg_show, |
diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c b/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c index e3be3ce2cada..9ce0e30e33e8 100644 --- a/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c +++ b/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c | |||
| @@ -604,16 +604,6 @@ static void pmic_mpp_set(struct gpio_chip *chip, unsigned pin, int value) | |||
| 604 | pmic_mpp_config_set(state->ctrl, pin, &config, 1); | 604 | pmic_mpp_config_set(state->ctrl, pin, &config, 1); |
| 605 | } | 605 | } |
| 606 | 606 | ||
| 607 | static int pmic_mpp_request(struct gpio_chip *chip, unsigned base) | ||
| 608 | { | ||
| 609 | return pinctrl_request_gpio(chip->base + base); | ||
| 610 | } | ||
| 611 | |||
| 612 | static void pmic_mpp_free(struct gpio_chip *chip, unsigned base) | ||
| 613 | { | ||
| 614 | pinctrl_free_gpio(chip->base + base); | ||
| 615 | } | ||
| 616 | |||
| 617 | static int pmic_mpp_of_xlate(struct gpio_chip *chip, | 607 | static int pmic_mpp_of_xlate(struct gpio_chip *chip, |
| 618 | const struct of_phandle_args *gpio_desc, | 608 | const struct of_phandle_args *gpio_desc, |
| 619 | u32 *flags) | 609 | u32 *flags) |
| @@ -653,8 +643,8 @@ static const struct gpio_chip pmic_mpp_gpio_template = { | |||
| 653 | .direction_output = pmic_mpp_direction_output, | 643 | .direction_output = pmic_mpp_direction_output, |
| 654 | .get = pmic_mpp_get, | 644 | .get = pmic_mpp_get, |
| 655 | .set = pmic_mpp_set, | 645 | .set = pmic_mpp_set, |
| 656 | .request = pmic_mpp_request, | 646 | .request = gpiochip_generic_request, |
| 657 | .free = pmic_mpp_free, | 647 | .free = gpiochip_generic_free, |
| 658 | .of_xlate = pmic_mpp_of_xlate, | 648 | .of_xlate = pmic_mpp_of_xlate, |
| 659 | .to_irq = pmic_mpp_to_irq, | 649 | .to_irq = pmic_mpp_to_irq, |
| 660 | .dbg_show = pmic_mpp_dbg_show, | 650 | .dbg_show = pmic_mpp_dbg_show, |
