diff options
author | Bjorn Helgaas <bhelgaas@google.com> | 2016-10-06 14:36:57 -0400 |
---|---|---|
committer | Bjorn Helgaas <bhelgaas@google.com> | 2016-10-11 23:54:54 -0400 |
commit | f3eca6c4f42dc2dc057d6ef5d7dae1a5307f4f9f (patch) | |
tree | 4f7be704175478a6a21bce36084ae07f3eedefa2 /drivers/pci/host | |
parent | 21fa0c51f02fcff8761b6ed1d47b579f3f436135 (diff) |
PCI: keystone: Use generic DesignWare accessors
The dw_pcie_readl_rc() and dw_pcie_writel_rc() interfaces already add in
pp->dbi_base, so use those instead of doing it ourselves in the keystone
driver. No functional change intended.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'drivers/pci/host')
-rw-r--r-- | drivers/pci/host/pci-keystone-dw.c | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/drivers/pci/host/pci-keystone-dw.c b/drivers/pci/host/pci-keystone-dw.c index e2c04d1a8a87..ce97816f5d64 100644 --- a/drivers/pci/host/pci-keystone-dw.c +++ b/drivers/pci/host/pci-keystone-dw.c | |||
@@ -362,8 +362,8 @@ void ks_dw_pcie_setup_rc_app_regs(struct keystone_pcie *ks_pcie) | |||
362 | 362 | ||
363 | /* Disable BARs for inbound access */ | 363 | /* Disable BARs for inbound access */ |
364 | ks_dw_pcie_set_dbi_mode(ks_pcie->va_app_base); | 364 | ks_dw_pcie_set_dbi_mode(ks_pcie->va_app_base); |
365 | writel(0, pp->dbi_base + PCI_BASE_ADDRESS_0); | 365 | dw_pcie_writel_rc(pp, PCI_BASE_ADDRESS_0, 0); |
366 | writel(0, pp->dbi_base + PCI_BASE_ADDRESS_1); | 366 | dw_pcie_writel_rc(pp, PCI_BASE_ADDRESS_1, 0); |
367 | ks_dw_pcie_clear_dbi_mode(ks_pcie->va_app_base); | 367 | ks_dw_pcie_clear_dbi_mode(ks_pcie->va_app_base); |
368 | 368 | ||
369 | /* Set outbound translation size per window division */ | 369 | /* Set outbound translation size per window division */ |
@@ -461,8 +461,8 @@ void ks_dw_pcie_v3_65_scan_bus(struct pcie_port *pp) | |||
461 | ks_dw_pcie_set_dbi_mode(ks_pcie->va_app_base); | 461 | ks_dw_pcie_set_dbi_mode(ks_pcie->va_app_base); |
462 | 462 | ||
463 | /* Enable BAR0 */ | 463 | /* Enable BAR0 */ |
464 | writel(1, pp->dbi_base + PCI_BASE_ADDRESS_0); | 464 | dw_pcie_writel_rc(pp, PCI_BASE_ADDRESS_0, 1); |
465 | writel(SZ_4K - 1, pp->dbi_base + PCI_BASE_ADDRESS_0); | 465 | dw_pcie_writel_rc(pp, PCI_BASE_ADDRESS_0, SZ_4K - 1); |
466 | 466 | ||
467 | ks_dw_pcie_clear_dbi_mode(ks_pcie->va_app_base); | 467 | ks_dw_pcie_clear_dbi_mode(ks_pcie->va_app_base); |
468 | 468 | ||
@@ -470,7 +470,7 @@ void ks_dw_pcie_v3_65_scan_bus(struct pcie_port *pp) | |||
470 | * For BAR0, just setting bus address for inbound writes (MSI) should | 470 | * For BAR0, just setting bus address for inbound writes (MSI) should |
471 | * be sufficient. Use physical address to avoid any conflicts. | 471 | * be sufficient. Use physical address to avoid any conflicts. |
472 | */ | 472 | */ |
473 | writel(ks_pcie->app.start, pp->dbi_base + PCI_BASE_ADDRESS_0); | 473 | dw_pcie_writel_rc(pp, PCI_BASE_ADDRESS_0, ks_pcie->app.start); |
474 | } | 474 | } |
475 | 475 | ||
476 | /** | 476 | /** |
@@ -478,8 +478,9 @@ void ks_dw_pcie_v3_65_scan_bus(struct pcie_port *pp) | |||
478 | */ | 478 | */ |
479 | int ks_dw_pcie_link_up(struct pcie_port *pp) | 479 | int ks_dw_pcie_link_up(struct pcie_port *pp) |
480 | { | 480 | { |
481 | u32 val = readl(pp->dbi_base + DEBUG0); | 481 | u32 val; |
482 | 482 | ||
483 | val = dw_pcie_readl_rc(pp, DEBUG0); | ||
483 | return (val & LTSSM_STATE_MASK) == LTSSM_STATE_L0; | 484 | return (val & LTSSM_STATE_MASK) == LTSSM_STATE_L0; |
484 | } | 485 | } |
485 | 486 | ||