mac80211: clarify interface iteration and make it configurable

During hardware restart, all interfaces are iterated even
though they haven't been re-added to the driver, document
this behaviour. The same also happens during resume, which
is even more confusing since all of the interfaces were
previously removed from the driver. Make this optional so
drivers relying on the current behaviour can still use it,
but to let drivers that don't want this behaviour disable
it.

Also convert all API users, keeping the old semantics
except in hwsim, where the new normal ones are desired.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>

1 files changed, 8 insertions, 3 deletions

diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c
index 9b4f76718db7..a8ec7086ad09 100644
--- a/drivers/net/wireless/mac80211_hwsim.c
+++ b/drivers/net/wireless/mac80211_hwsim.c
@@ -571,6 +571,7 @@ static bool mac80211_hwsim_addr_match(struct mac80211_hwsim_data *data,
         md.ret = false;
         md.addr = addr;
         ieee80211_iterate_active_interfaces_atomic(data->hw,
+                                                   IEEE80211_IFACE_ITER_NORMAL,
                                                    mac80211_hwsim_addr_iter,
                                                    &md);
 
@@ -744,8 +745,8 @@ static bool mac80211_hwsim_tx_frame_no_nl(struct ieee80211_hw *hw,
                 if (!hwsim_chans_compat(chan, data2->tmp_chan) &&
                     !hwsim_chans_compat(chan, data2->channel)) {
                         ieee80211_iterate_active_interfaces_atomic(
-                                data2->hw, mac80211_hwsim_tx_iter,
-                                &tx_iter_data);
+                                data2->hw, IEEE80211_IFACE_ITER_NORMAL,
+                                mac80211_hwsim_tx_iter, &tx_iter_data);
                         if (!tx_iter_data.receive)
                                 continue;
                 }
@@ -958,7 +959,8 @@ static void mac80211_hwsim_beacon(unsigned long arg)
                 return;
 
         ieee80211_iterate_active_interfaces_atomic(
-                hw, mac80211_hwsim_beacon_tx, hw);
+                hw, IEEE80211_IFACE_ITER_NORMAL,
+                mac80211_hwsim_beacon_tx, hw);
 
         data->beacon_timer.expires = jiffies + data->beacon_int;
         add_timer(&data->beacon_timer);
@@ -1680,14 +1682,17 @@ static int hwsim_fops_ps_write(void *dat, u64 val)
 
         if (val == PS_MANUAL_POLL) {
                 ieee80211_iterate_active_interfaces(data->hw,
+                                                    IEEE80211_IFACE_ITER_NORMAL,
                                                     hwsim_send_ps_poll, data);
                 data->ps_poll_pending = true;
         } else if (old_ps == PS_DISABLED && val != PS_DISABLED) {
                 ieee80211_iterate_active_interfaces(data->hw,
+                                                    IEEE80211_IFACE_ITER_NORMAL,
                                                     hwsim_send_nullfunc_ps,
                                                     data);
         } else if (old_ps != PS_DISABLED && val == PS_DISABLED) {
                 ieee80211_iterate_active_interfaces(data->hw,
+                                                    IEEE80211_IFACE_ITER_NORMAL,
                                                     hwsim_send_nullfunc_no_ps,
                                                     data);
         }