Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next

Pull networking updates from David Miller:
 "Highlights:

   1) Support more Realtek wireless chips, from Jes Sorenson.

   2) New BPF types for per-cpu hash and arrap maps, from Alexei
      Starovoitov.

   3) Make several TCP sysctls per-namespace, from Nikolay Borisov.

   4) Allow the use of SO_REUSEPORT in order to do per-thread processing
   of incoming TCP/UDP connections.  The muxing can be done using a
   BPF program which hashes the incoming packet.  From Craig Gallek.

   5) Add a multiplexer for TCP streams, to provide a messaged based
      interface.  BPF programs can be used to determine the message
      boundaries.  From Tom Herbert.

   6) Add 802.1AE MACSEC support, from Sabrina Dubroca.

   7) Avoid factorial complexity when taking down an inetdev interface
      with lots of configured addresses.  We were doing things like
      traversing the entire address less for each address removed, and
      flushing the entire netfilter conntrack table for every address as
      well.

   8) Add and use SKB bulk free infrastructure, from Jesper Brouer.

   9) Allow offloading u32 classifiers to hardware, and implement for
      ixgbe, from John Fastabend.

  10) Allow configuring IRQ coalescing parameters on a per-queue basis,
      from Kan Liang.

  11) Extend ethtool so that larger link mode masks can be supported.
      From David Decotigny.

  12) Introduce devlink, which can be used to configure port link types
      (ethernet vs Infiniband, etc.), port splitting, and switch device
      level attributes as a whole.  From Jiri Pirko.

  13) Hardware offload support for flower classifiers, from Amir Vadai.

  14) Add "Local Checksum Offload".  Basically, for a tunneled packet
      the checksum of the outer header is 'constant' (because with the
      checksum field filled into the inner protocol header, the payload
      of the outer frame checksums to 'zero'), and we can take advantage
      of that in various ways.  From Edward Cree"

* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next: (1548 commits)
  bonding: fix bond_get_stats()
  net: bcmgenet: fix dma api length mismatch
  net/mlx4_core: Fix backward compatibility on VFs
  phy: mdio-thunder: Fix some Kconfig typos
  lan78xx: add ndo_get_stats64
  lan78xx: handle statistics counter rollover
  RDS: TCP: Remove unused constant
  RDS: TCP: Add sysctl tunables for sndbuf/rcvbuf on rds-tcp socket
  net: smc911x: convert pxa dma to dmaengine
  team: remove duplicate set of flag IFF_MULTICAST
  bonding: remove duplicate set of flag IFF_MULTICAST
  net: fix a comment typo
  ethernet: micrel: fix some error codes
  ip_tunnels, bpf: define IP_TUNNEL_OPTS_MAX and use it
  bpf, dst: add and use dst_tclassid helper
  bpf: make skb->tc_classid also readable
  net: mvneta: bm: clarify dependencies
  cls_bpf: reset class and reuse major in da
  ldmvsw: Checkpatch sunvnet.c and sunvnet_common.c
  ldmvsw: Add ldmvsw.c driver code
  ...

1 files changed, 24 insertions, 19 deletions

diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c
index d61da9ece3ba..4fd861063ed4 100644
--- a/drivers/net/ppp/ppp_generic.c
+++ b/drivers/net/ppp/ppp_generic.c
@@ -575,7 +575,7 @@ static int get_filter(void __user *arg, struct sock_filter **p)
 
 static long ppp_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 {
-        struct ppp_file *pf = file->private_data;
+        struct ppp_file *pf;
         struct ppp *ppp;
         int err = -EFAULT, val, val2, i;
         struct ppp_idle idle;
@@ -585,9 +585,14 @@ static long ppp_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
         void __user *argp = (void __user *)arg;
         int __user *p = argp;
 
-        if (!pf)
-                return ppp_unattached_ioctl(current->nsproxy->net_ns,
-                                        pf, file, cmd, arg);
+        mutex_lock(&ppp_mutex);
+
+        pf = file->private_data;
+        if (!pf) {
+                err = ppp_unattached_ioctl(current->nsproxy->net_ns,
+                                           pf, file, cmd, arg);
+                goto out;
+        }
 
         if (cmd == PPPIOCDETACH) {
                 /*
@@ -602,7 +607,6 @@ static long ppp_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
                  * this fd and reopening /dev/ppp.
                  */
                 err = -EINVAL;
-                mutex_lock(&ppp_mutex);
                 if (pf->kind == INTERFACE) {
                         ppp = PF_TO_PPP(pf);
                         rtnl_lock();
@@ -616,15 +620,13 @@ static long ppp_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
                 } else
                         pr_warn("PPPIOCDETACH file->f_count=%ld\n",
                                 atomic_long_read(&file->f_count));
-                mutex_unlock(&ppp_mutex);
-                return err;
+                goto out;
         }
 
         if (pf->kind == CHANNEL) {
                 struct channel *pch;
                 struct ppp_channel *chan;
 
-                mutex_lock(&ppp_mutex);
                 pch = PF_TO_CHANNEL(pf);
 
                 switch (cmd) {
@@ -646,17 +648,16 @@ static long ppp_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
                                 err = chan->ops->ioctl(chan, cmd, arg);
                         up_read(&pch->chan_sem);
                 }
-                mutex_unlock(&ppp_mutex);
-                return err;
+                goto out;
         }
 
         if (pf->kind != INTERFACE) {
                 /* can't happen */
                 pr_err("PPP: not interface or channel??\n");
-                return -EINVAL;
+                err = -EINVAL;
+                goto out;
         }
 
-        mutex_lock(&ppp_mutex);
         ppp = PF_TO_PPP(pf);
         switch (cmd) {
         case PPPIOCSMRU:
@@ -831,7 +832,10 @@ static long ppp_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
         default:
                 err = -ENOTTY;
         }
+
+out:
         mutex_unlock(&ppp_mutex);
+
         return err;
 }
 
@@ -844,7 +848,6 @@ static int ppp_unattached_ioctl(struct net *net, struct ppp_file *pf,
         struct ppp_net *pn;
         int __user *p = (int __user *)arg;
 
-        mutex_lock(&ppp_mutex);
         switch (cmd) {
         case PPPIOCNEWUNIT:
                 /* Create a new ppp unit */
@@ -894,7 +897,7 @@ static int ppp_unattached_ioctl(struct net *net, struct ppp_file *pf,
         default:
                 err = -ENOTTY;
         }
-        mutex_unlock(&ppp_mutex);
+
         return err;
 }
 
@@ -2437,13 +2440,15 @@ ppp_set_compress(struct ppp *ppp, unsigned long arg)
         unsigned char ccp_option[CCP_MAX_OPTION_LENGTH];
 
         err = -EFAULT;
-        if (copy_from_user(&data, (void __user *) arg, sizeof(data)) ||
-            (data.length <= CCP_MAX_OPTION_LENGTH &&
-             copy_from_user(ccp_option, (void __user *) data.ptr, data.length)))
+        if (copy_from_user(&data, (void __user *) arg, sizeof(data)))
+                goto out;
+        if (data.length > CCP_MAX_OPTION_LENGTH)
                 goto out;
+        if (copy_from_user(ccp_option, (void __user *) data.ptr, data.length))
+                goto out;
+
         err = -EINVAL;
-        if (data.length > CCP_MAX_OPTION_LENGTH ||
-            ccp_option[1] < 2 || ccp_option[1] > data.length)
+        if (data.length < 2 || ccp_option[1] < 2 || ccp_option[1] > data.length)
                 goto out;
 
         cp = try_then_request_module(