diff options
author | David Miller <davem@davemloft.net> | 2015-12-17 16:05:49 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-12-18 16:03:03 -0500 |
commit | d79f16c046086f4fe0d42184a458e187464eb83e (patch) | |
tree | 0707cd45b01d5e7a910676b93babc584548d53f9 /drivers/net/hamradio/mkiss.c | |
parent | acf673a3187edf72068ee2f92f4dc47d66baed47 (diff) |
mkiss: Fix use after free in mkiss_close().
Need to do the unregister_device() after all references to the driver
private have been done.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/hamradio/mkiss.c')
-rw-r--r-- | drivers/net/hamradio/mkiss.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/hamradio/mkiss.c b/drivers/net/hamradio/mkiss.c index 216bfd350169..0b72b9de5207 100644 --- a/drivers/net/hamradio/mkiss.c +++ b/drivers/net/hamradio/mkiss.c | |||
@@ -798,13 +798,13 @@ static void mkiss_close(struct tty_struct *tty) | |||
798 | if (!atomic_dec_and_test(&ax->refcnt)) | 798 | if (!atomic_dec_and_test(&ax->refcnt)) |
799 | down(&ax->dead_sem); | 799 | down(&ax->dead_sem); |
800 | 800 | ||
801 | unregister_netdev(ax->dev); | ||
802 | |||
803 | /* Free all AX25 frame buffers. */ | 801 | /* Free all AX25 frame buffers. */ |
804 | kfree(ax->rbuff); | 802 | kfree(ax->rbuff); |
805 | kfree(ax->xbuff); | 803 | kfree(ax->xbuff); |
806 | 804 | ||
807 | ax->tty = NULL; | 805 | ax->tty = NULL; |
806 | |||
807 | unregister_netdev(ax->dev); | ||
808 | } | 808 | } |
809 | 809 | ||
810 | /* Perform I/O control on an active ax25 channel. */ | 810 | /* Perform I/O control on an active ax25 channel. */ |