ixgbe: use BIT() macro

Several areas of ixgbe were written before widespread usage of the
BIT(n) macro. With the impending release of GCC 6 and its associated new
warnings, some usages such as (1 << 31) have been noted within the ixgbe
driver source. Fix these wholesale and prevent future issues by simply
using BIT macro instead of hand coded bit shifts.

Also fix a few shifts that are shifting values into place by using the
'u' prefix to indicate unsigned. It doesn't strictly matter in these
cases because we're not shifting by too large a value, but these are all
unsigned values and should be indicated as such.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

1 files changed, 3 insertions, 3 deletions

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c
index 6ecd598c6ef5..fb51be74dd4c 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c
@@ -792,7 +792,7 @@ mac_reset_top:
         }
 
         gheccr = IXGBE_READ_REG(hw, IXGBE_GHECCR);
-        gheccr &= ~((1 << 21) | (1 << 18) | (1 << 9) | (1 << 6));
+        gheccr &= ~(BIT(21) | BIT(18) | BIT(9) | BIT(6));
         IXGBE_WRITE_REG(hw, IXGBE_GHECCR, gheccr);
 
         /*
@@ -914,10 +914,10 @@ static s32 ixgbe_set_vfta_82598(struct ixgbe_hw *hw, u32 vlan, u32 vind,
         bits = IXGBE_READ_REG(hw, IXGBE_VFTA(regindex));
         if (vlan_on)
                 /* Turn on this VLAN id */
-                bits |= (1 << bitindex);
+                bits |= BIT(bitindex);
         else
                 /* Turn off this VLAN id */
-                bits &= ~(1 << bitindex);
+                bits &= ~BIT(bitindex);
         IXGBE_WRITE_REG(hw, IXGBE_VFTA(regindex), bits);
 
         return 0;