aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/mfd
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2016-09-06 09:53:29 -0400
committerLee Jones <lee.jones@linaro.org>2016-10-04 10:48:03 -0400
commitb53046cbf8c90ca67a818c9093227e60cf1387b6 (patch)
treeed0352f85fafa9081544312aa65963fcd6c615a8 /drivers/mfd
parentbab1e0c01810629a878faf0b3a2dd672693c58af (diff)
mfd: ucb1x00: Remove NO_IRQ check
probe_irq_off() returns '0' on failure, not NO_IRQ, so the check in this driver is clearly wrong. This replaces it with the regular '!irq' check used in other drivers. The sa1100 platform that this driver is used on originally numbered all its interrupts starting at '0', which would have conflicted with this change, but as of commit 18f3aec ("ARM: 8230/1: sa1100: shift IRQs by one"), this is not a problem any more. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers/mfd')
-rw-r--r--drivers/mfd/ucb1x00-core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mfd/ucb1x00-core.c b/drivers/mfd/ucb1x00-core.c
index 48bea5038654..d6fb2e1a759a 100644
--- a/drivers/mfd/ucb1x00-core.c
+++ b/drivers/mfd/ucb1x00-core.c
@@ -537,7 +537,7 @@ static int ucb1x00_probe(struct mcp *mcp)
537 ucb1x00_enable(ucb); 537 ucb1x00_enable(ucb);
538 ucb->irq = ucb1x00_detect_irq(ucb); 538 ucb->irq = ucb1x00_detect_irq(ucb);
539 ucb1x00_disable(ucb); 539 ucb1x00_disable(ucb);
540 if (ucb->irq == NO_IRQ) { 540 if (!ucb->irq) {
541 dev_err(&ucb->dev, "IRQ probe failed\n"); 541 dev_err(&ucb->dev, "IRQ probe failed\n");
542 ret = -ENODEV; 542 ret = -ENODEV;
543 goto err_no_irq; 543 goto err_no_irq;