aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/hid/hid-wacom.c
diff options
context:
space:
mode:
authorBenjamin Tissoires <benjamin.tissoires@redhat.com>2014-02-10 12:58:54 -0500
committerJiri Kosina <jkosina@suse.cz>2014-02-17 08:56:50 -0500
commitb0dd72aafd785785bedbb6db932955807e454a65 (patch)
tree9957e630bb70bd5c8f177546a8b805f281c17ac8 /drivers/hid/hid-wacom.c
parentbd27e202c640d19fbf948a56914c230dcbaee6d0 (diff)
HID: replace hid_output_raw_report with hid_hw_raw_request for feature requests
ret = hid_output_raw_report(A, B, C, HID_FEATURE_REPORT); is equivalent to ret = hid_hw_raw_request(A, B[0], B, C, HID_FEATURE_REPORT, HID_REQ_SET_REPORT); whatever the transport layer is. So use the new API where available Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/hid-wacom.c')
-rw-r--r--drivers/hid/hid-wacom.c26
1 files changed, 15 insertions, 11 deletions
diff --git a/drivers/hid/hid-wacom.c b/drivers/hid/hid-wacom.c
index c720db912edb..902013ec041b 100644
--- a/drivers/hid/hid-wacom.c
+++ b/drivers/hid/hid-wacom.c
@@ -128,7 +128,8 @@ static void wacom_set_image(struct hid_device *hdev, const char *image,
128 128
129 rep_data[0] = WAC_CMD_ICON_START_STOP; 129 rep_data[0] = WAC_CMD_ICON_START_STOP;
130 rep_data[1] = 0; 130 rep_data[1] = 0;
131 ret = hid_output_raw_report(hdev, rep_data, 2, HID_FEATURE_REPORT); 131 ret = hid_hw_raw_request(hdev, rep_data[0], rep_data, 2,
132 HID_FEATURE_REPORT, HID_REQ_SET_REPORT);
132 if (ret < 0) 133 if (ret < 0)
133 goto err; 134 goto err;
134 135
@@ -142,14 +143,15 @@ static void wacom_set_image(struct hid_device *hdev, const char *image,
142 rep_data[j + 3] = p[(i << 6) + j]; 143 rep_data[j + 3] = p[(i << 6) + j];
143 144
144 rep_data[2] = i; 145 rep_data[2] = i;
145 ret = hid_output_raw_report(hdev, rep_data, 67, 146 ret = hid_hw_raw_request(hdev, rep_data[0], rep_data, 67,
146 HID_FEATURE_REPORT); 147 HID_FEATURE_REPORT, HID_REQ_SET_REPORT);
147 } 148 }
148 149
149 rep_data[0] = WAC_CMD_ICON_START_STOP; 150 rep_data[0] = WAC_CMD_ICON_START_STOP;
150 rep_data[1] = 0; 151 rep_data[1] = 0;
151 152
152 ret = hid_output_raw_report(hdev, rep_data, 2, HID_FEATURE_REPORT); 153 ret = hid_hw_raw_request(hdev, rep_data[0], rep_data, 2,
154 HID_FEATURE_REPORT, HID_REQ_SET_REPORT);
153 155
154err: 156err:
155 return; 157 return;
@@ -181,7 +183,8 @@ static void wacom_leds_set_brightness(struct led_classdev *led_dev,
181 buf[3] = value; 183 buf[3] = value;
182 /* use fixed brightness for OLEDs */ 184 /* use fixed brightness for OLEDs */
183 buf[4] = 0x08; 185 buf[4] = 0x08;
184 hid_output_raw_report(hdev, buf, 9, HID_FEATURE_REPORT); 186 hid_hw_raw_request(hdev, buf[0], buf, 9, HID_FEATURE_REPORT,
187 HID_REQ_SET_REPORT);
185 kfree(buf); 188 kfree(buf);
186 } 189 }
187 190
@@ -337,8 +340,8 @@ static void wacom_set_features(struct hid_device *hdev, u8 speed)
337 rep_data[0] = 0x03 ; rep_data[1] = 0x00; 340 rep_data[0] = 0x03 ; rep_data[1] = 0x00;
338 limit = 3; 341 limit = 3;
339 do { 342 do {
340 ret = hid_output_raw_report(hdev, rep_data, 2, 343 ret = hid_hw_raw_request(hdev, rep_data[0], rep_data, 2,
341 HID_FEATURE_REPORT); 344 HID_FEATURE_REPORT, HID_REQ_SET_REPORT);
342 } while (ret < 0 && limit-- > 0); 345 } while (ret < 0 && limit-- > 0);
343 346
344 if (ret >= 0) { 347 if (ret >= 0) {
@@ -350,8 +353,9 @@ static void wacom_set_features(struct hid_device *hdev, u8 speed)
350 rep_data[1] = 0x00; 353 rep_data[1] = 0x00;
351 limit = 3; 354 limit = 3;
352 do { 355 do {
353 ret = hid_output_raw_report(hdev, 356 ret = hid_hw_raw_request(hdev, rep_data[0],
354 rep_data, 2, HID_FEATURE_REPORT); 357 rep_data, 2, HID_FEATURE_REPORT,
358 HID_REQ_SET_REPORT);
355 } while (ret < 0 && limit-- > 0); 359 } while (ret < 0 && limit-- > 0);
356 360
357 if (ret >= 0) { 361 if (ret >= 0) {
@@ -376,8 +380,8 @@ static void wacom_set_features(struct hid_device *hdev, u8 speed)
376 rep_data[0] = 0x03; 380 rep_data[0] = 0x03;
377 rep_data[1] = wdata->features; 381 rep_data[1] = wdata->features;
378 382
379 ret = hid_output_raw_report(hdev, rep_data, 2, 383 ret = hid_hw_raw_request(hdev, rep_data[0], rep_data, 2,
380 HID_FEATURE_REPORT); 384 HID_FEATURE_REPORT, HID_REQ_SET_REPORT);
381 if (ret >= 0) 385 if (ret >= 0)
382 wdata->high_speed = speed; 386 wdata->high_speed = speed;
383 break; 387 break;