drm: use drm_file to tag vm-bos

Rather than using "struct file*", use "struct drm_file*" as tag VM tag for
BOs. This will pave the way for "struct drm_file*" without any "struct
file*" back-pointer.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20160901124837.680-3-dh.herrmann@gmail.com

10 files changed, 40 insertions, 32 deletions

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index 5447973483ec..e36bfc47dceb 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -226,7 +226,8 @@ static int amdgpu_verify_access(struct ttm_buffer_object *bo, struct file *filp)
 
         if (amdgpu_ttm_tt_get_usermm(bo->ttm))
                 return -EPERM;
-        return drm_vma_node_verify_access(&rbo->gem_base.vma_node, filp);
+        return drm_vma_node_verify_access(&rbo->gem_base.vma_node,
+                                          filp->private_data);
 }
 
 static void amdgpu_move_null(struct ttm_buffer_object *bo,
diff --git a/drivers/gpu/drm/ast/ast_ttm.c b/drivers/gpu/drm/ast/ast_ttm.c
index b29a41218fc9..608df4c90520 100644
--- a/drivers/gpu/drm/ast/ast_ttm.c
+++ b/drivers/gpu/drm/ast/ast_ttm.c
@@ -150,7 +150,8 @@ static int ast_bo_verify_access(struct ttm_buffer_object *bo, struct file *filp)
 {
         struct ast_bo *astbo = ast_bo(bo);
 
-        return drm_vma_node_verify_access(&astbo->gem.vma_node, filp);
+        return drm_vma_node_verify_access(&astbo->gem.vma_node,
+                                          filp->private_data);
 }
 
 static int ast_ttm_io_mem_reserve(struct ttm_bo_device *bdev,
diff --git a/drivers/gpu/drm/bochs/bochs_mm.c b/drivers/gpu/drm/bochs/bochs_mm.c
index 5c5638a777a1..269cfca9ca06 100644
--- a/drivers/gpu/drm/bochs/bochs_mm.c
+++ b/drivers/gpu/drm/bochs/bochs_mm.c
@@ -128,7 +128,8 @@ static int bochs_bo_verify_access(struct ttm_buffer_object *bo,
 {
         struct bochs_bo *bochsbo = bochs_bo(bo);
 
-        return drm_vma_node_verify_access(&bochsbo->gem.vma_node, filp);
+        return drm_vma_node_verify_access(&bochsbo->gem.vma_node,
+                                          filp->private_data);
 }
 
 static int bochs_ttm_io_mem_reserve(struct ttm_bo_device *bdev,
diff --git a/drivers/gpu/drm/cirrus/cirrus_ttm.c b/drivers/gpu/drm/cirrus/cirrus_ttm.c
index 1cc9ee607128..bb2438dd8733 100644
--- a/drivers/gpu/drm/cirrus/cirrus_ttm.c
+++ b/drivers/gpu/drm/cirrus/cirrus_ttm.c
@@ -150,7 +150,8 @@ static int cirrus_bo_verify_access(struct ttm_buffer_object *bo, struct file *fi
 {
         struct cirrus_bo *cirrusbo = cirrus_bo(bo);
 
-        return drm_vma_node_verify_access(&cirrusbo->gem.vma_node, filp);
+        return drm_vma_node_verify_access(&cirrusbo->gem.vma_node,
+                                          filp->private_data);
 }
 
 static int cirrus_ttm_io_mem_reserve(struct ttm_bo_device *bdev,
diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index 9134ae134667..465bacd0a630 100644
--- a/drivers/gpu/drm/drm_gem.c
+++ b/drivers/gpu/drm/drm_gem.c
@@ -257,7 +257,7 @@ drm_gem_object_release_handle(int id, void *ptr, void *data)
 
         if (drm_core_check_feature(dev, DRIVER_PRIME))
                 drm_gem_remove_prime_handles(obj, file_priv);
-        drm_vma_node_revoke(&obj->vma_node, file_priv->filp);
+        drm_vma_node_revoke(&obj->vma_node, file_priv);
 
         if (dev->driver->gem_close_object)
                 dev->driver->gem_close_object(obj, file_priv);
@@ -372,7 +372,7 @@ drm_gem_handle_create_tail(struct drm_file *file_priv,
 
         handle = ret;
 
-        ret = drm_vma_node_allow(&obj->vma_node, file_priv->filp);
+        ret = drm_vma_node_allow(&obj->vma_node, file_priv);
         if (ret)
                 goto err_remove;
 
@@ -386,7 +386,7 @@ drm_gem_handle_create_tail(struct drm_file *file_priv,
         return 0;
 
 err_revoke:
-        drm_vma_node_revoke(&obj->vma_node, file_priv->filp);
+        drm_vma_node_revoke(&obj->vma_node, file_priv);
 err_remove:
         spin_lock(&file_priv->table_lock);
         idr_remove(&file_priv->object_idr, handle);
@@ -991,7 +991,7 @@ int drm_gem_mmap(struct file *filp, struct vm_area_struct *vma)
         if (!obj)
                 return -EINVAL;
 
-        if (!drm_vma_node_is_allowed(node, filp)) {
+        if (!drm_vma_node_is_allowed(node, priv)) {
                 drm_gem_object_unreference_unlocked(obj);
                 return -EACCES;
         }
diff --git a/drivers/gpu/drm/drm_vma_manager.c b/drivers/gpu/drm/drm_vma_manager.c
index 0aef432679f9..20cc33d1bfc1 100644
--- a/drivers/gpu/drm/drm_vma_manager.c
+++ b/drivers/gpu/drm/drm_vma_manager.c
@@ -25,7 +25,6 @@
 #include <drm/drmP.h>
 #include <drm/drm_mm.h>
 #include <drm/drm_vma_manager.h>
-#include <linux/fs.h>
 #include <linux/mm.h>
 #include <linux/module.h>
 #include <linux/rbtree.h>
@@ -252,9 +251,9 @@ EXPORT_SYMBOL(drm_vma_offset_remove);
 /**
  * drm_vma_node_allow - Add open-file to list of allowed users
  * @node: Node to modify
- * @filp: Open file to add
+ * @tag: Tag of file to remove
  *
- * Add @filp to the list of allowed open-files for this node. If @filp is
+ * Add @tag to the list of allowed open-files for this node. If @tag is
  * already on this list, the ref-count is incremented.
  *
  * The list of allowed-users is preserved across drm_vma_offset_add() and
@@ -269,7 +268,7 @@ EXPORT_SYMBOL(drm_vma_offset_remove);
  * RETURNS:
  * 0 on success, negative error code on internal failure (out-of-mem)
  */
-int drm_vma_node_allow(struct drm_vma_offset_node *node, struct file *filp)
+int drm_vma_node_allow(struct drm_vma_offset_node *node, struct drm_file *tag)
 {
         struct rb_node **iter;
         struct rb_node *parent = NULL;
@@ -290,10 +289,10 @@ int drm_vma_node_allow(struct drm_vma_offset_node *node, struct file *filp)
                 parent = *iter;
                 entry = rb_entry(*iter, struct drm_vma_offset_file, vm_rb);
 
-                if (filp == entry->vm_filp) {
+                if (tag == entry->vm_tag) {
                         entry->vm_count++;
                         goto unlock;
-                } else if (filp > entry->vm_filp) {
+                } else if (tag > entry->vm_tag) {
                         iter = &(*iter)->rb_right;
                 } else {
                         iter = &(*iter)->rb_left;
@@ -305,7 +304,7 @@ int drm_vma_node_allow(struct drm_vma_offset_node *node, struct file *filp)
                 goto unlock;
         }
 
-        new->vm_filp = filp;
+        new->vm_tag = tag;
         new->vm_count = 1;
         rb_link_node(&new->vm_rb, parent, iter);
         rb_insert_color(&new->vm_rb, &node->vm_files);
@@ -321,17 +320,18 @@ EXPORT_SYMBOL(drm_vma_node_allow);
 /**
  * drm_vma_node_revoke - Remove open-file from list of allowed users
  * @node: Node to modify
- * @filp: Open file to remove
+ * @tag: Tag of file to remove
  *
- * Decrement the ref-count of @filp in the list of allowed open-files on @node.
- * If the ref-count drops to zero, remove @filp from the list. You must call
- * this once for every drm_vma_node_allow() on @filp.
+ * Decrement the ref-count of @tag in the list of allowed open-files on @node.
+ * If the ref-count drops to zero, remove @tag from the list. You must call
+ * this once for every drm_vma_node_allow() on @tag.
  *
  * This is locked against concurrent access internally.
  *
- * If @filp is not on the list, nothing is done.
+ * If @tag is not on the list, nothing is done.
  */
-void drm_vma_node_revoke(struct drm_vma_offset_node *node, struct file *filp)
+void drm_vma_node_revoke(struct drm_vma_offset_node *node,
+                         struct drm_file *tag)
 {
         struct drm_vma_offset_file *entry;
         struct rb_node *iter;
@@ -341,13 +341,13 @@ void drm_vma_node_revoke(struct drm_vma_offset_node *node, struct file *filp)
         iter = node->vm_files.rb_node;
         while (likely(iter)) {
                 entry = rb_entry(iter, struct drm_vma_offset_file, vm_rb);
-                if (filp == entry->vm_filp) {
+                if (tag == entry->vm_tag) {
                         if (!--entry->vm_count) {
                                 rb_erase(&entry->vm_rb, &node->vm_files);
                                 kfree(entry);
                         }
                         break;
-                } else if (filp > entry->vm_filp) {
+                } else if (tag > entry->vm_tag) {
                         iter = iter->rb_right;
                 } else {
                         iter = iter->rb_left;
@@ -361,9 +361,9 @@ EXPORT_SYMBOL(drm_vma_node_revoke);
 /**
  * drm_vma_node_is_allowed - Check whether an open-file is granted access
  * @node: Node to check
- * @filp: Open-file to check for
+ * @tag: Tag of file to remove
  *
- * Search the list in @node whether @filp is currently on the list of allowed
+ * Search the list in @node whether @tag is currently on the list of allowed
  * open-files (see drm_vma_node_allow()).
  *
  * This is locked against concurrent access internally.
@@ -372,7 +372,7 @@ EXPORT_SYMBOL(drm_vma_node_revoke);
  * true iff @filp is on the list
  */
 bool drm_vma_node_is_allowed(struct drm_vma_offset_node *node,
-                             struct file *filp)
+                             struct drm_file *tag)
 {
         struct drm_vma_offset_file *entry;
         struct rb_node *iter;
@@ -382,9 +382,9 @@ bool drm_vma_node_is_allowed(struct drm_vma_offset_node *node,
         iter = node->vm_files.rb_node;
         while (likely(iter)) {
                 entry = rb_entry(iter, struct drm_vma_offset_file, vm_rb);
-                if (filp == entry->vm_filp)
+                if (tag == entry->vm_tag)
                         break;
-                else if (filp > entry->vm_filp)
+                else if (tag > entry->vm_tag)
                         iter = iter->rb_right;
                 else
                         iter = iter->rb_left;
diff --git a/drivers/gpu/drm/mgag200/mgag200_ttm.c b/drivers/gpu/drm/mgag200/mgag200_ttm.c
index 68268e55d595..919b35f2ad24 100644
--- a/drivers/gpu/drm/mgag200/mgag200_ttm.c
+++ b/drivers/gpu/drm/mgag200/mgag200_ttm.c
@@ -150,7 +150,8 @@ static int mgag200_bo_verify_access(struct ttm_buffer_object *bo, struct file *f
 {
         struct mgag200_bo *mgabo = mgag200_bo(bo);
 
-        return drm_vma_node_verify_access(&mgabo->gem.vma_node, filp);
+        return drm_vma_node_verify_access(&mgabo->gem.vma_node,
+                                          filp->private_data);
 }
 
 static int mgag200_ttm_io_mem_reserve(struct ttm_bo_device *bdev,
diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c
index 8ab9ce5089fe..66f31c3eb8ba 100644
--- a/drivers/gpu/drm/nouveau/nouveau_bo.c
+++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
@@ -1315,7 +1315,8 @@ nouveau_bo_verify_access(struct ttm_buffer_object *bo, struct file *filp)
 {
         struct nouveau_bo *nvbo = nouveau_bo(bo);
 
-        return drm_vma_node_verify_access(&nvbo->gem.vma_node, filp);
+        return drm_vma_node_verify_access(&nvbo->gem.vma_node,
+                                          filp->private_data);
 }
 
 static int
diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c
index 6a22de045cb5..b2fe2f8e6ae9 100644
--- a/drivers/gpu/drm/qxl/qxl_ttm.c
+++ b/drivers/gpu/drm/qxl/qxl_ttm.c
@@ -210,7 +210,8 @@ static int qxl_verify_access(struct ttm_buffer_object *bo, struct file *filp)
 {
         struct qxl_bo *qbo = to_qxl_bo(bo);
 
-        return drm_vma_node_verify_access(&qbo->gem_base.vma_node, filp);
+        return drm_vma_node_verify_access(&qbo->gem_base.vma_node,
+                                          filp->private_data);
 }
 
 static int qxl_ttm_io_mem_reserve(struct ttm_bo_device *bdev,
diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
index 93414aca60d6..27ee0ab0e1a7 100644
--- a/drivers/gpu/drm/radeon/radeon_ttm.c
+++ b/drivers/gpu/drm/radeon/radeon_ttm.c
@@ -237,7 +237,8 @@ static int radeon_verify_access(struct ttm_buffer_object *bo, struct file *filp)
 
         if (radeon_ttm_tt_has_userptr(bo->ttm))
                 return -EPERM;
-        return drm_vma_node_verify_access(&rbo->gem_base.vma_node, filp);
+        return drm_vma_node_verify_access(&rbo->gem_base.vma_node,
+                                          filp->private_data);
 }
 
 static void radeon_move_null(struct ttm_buffer_object *bo,