diff options
author | Maarten Lankhorst <maarten.lankhorst@linux.intel.com> | 2015-10-19 11:09:23 -0400 |
---|---|---|
committer | Maarten Lankhorst <maarten.lankhorst@linux.intel.com> | 2015-10-21 03:55:08 -0400 |
commit | fc32b1fdce1f85ea5a1277478f5d916ac3d6a284 (patch) | |
tree | e9b7278ff632b0d53743441a80db019c599aadc6 /drivers/gpu/drm/i915/intel_display.c | |
parent | 86efe24a85ce8e937db2732b7cd7d9a1394d102e (diff) |
drm/i915: Do not wait for flips in intel_crtc_disable_noatomic.
intel_crtc_disable_noatomic is called from hw readout during init, resume and possibly reset.
During init it's too early to have a page flip queued, before suspending all page flips
should be finished and during hw reset all page flips should be removed.
It's a bug when there are pending flips here, complain with WARN_ON instead of handling it.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/562507A3.3080901@linux.intel.com
Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm/i915/intel_display.c')
-rw-r--r-- | drivers/gpu/drm/i915/intel_display.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index c1286896aca3..bd1977ed6e88 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c | |||
@@ -6255,7 +6255,8 @@ static void intel_crtc_disable_noatomic(struct drm_crtc *crtc) | |||
6255 | return; | 6255 | return; |
6256 | 6256 | ||
6257 | if (to_intel_plane_state(crtc->primary->state)->visible) { | 6257 | if (to_intel_plane_state(crtc->primary->state)->visible) { |
6258 | intel_crtc_wait_for_pending_flips(crtc); | 6258 | WARN_ON(intel_crtc->unpin_work); |
6259 | |||
6259 | intel_pre_disable_primary(crtc); | 6260 | intel_pre_disable_primary(crtc); |
6260 | } | 6261 | } |
6261 | 6262 | ||