diff options
author | Chris Wilson <chris@chris-wilson.co.uk> | 2016-06-30 10:32:56 -0400 |
---|---|---|
committer | Chris Wilson <chris@chris-wilson.co.uk> | 2016-06-30 10:42:06 -0400 |
commit | 370004d38abc65bf920ae188be72caa7c7572033 (patch) | |
tree | cf807ade8853fb65fc2caad11290c5d4c1f277db /drivers/gpu/drm/i915/intel_display.c | |
parent | 6b18826a9e656d6e2d791ae925752323e92f706b (diff) |
drm/i915: Convert wait_for(I915_READ(reg)) to intel_wait_for_register()
By using the out-of-line intel_wait_for_register() not only do we can
efficiency from using the hybrid wait_for() contained within, but we
avoid code bloat from the numerous inlined loops, in total (all patches):
text data bss dec hex filename
1078551 4557 416 1083524 108884 drivers/gpu/drm/i915/i915.ko
1070775 4557 416 1075748 106a24 drivers/gpu/drm/i915/i915.ko
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1467297225-21379-13-git-send-email-chris@chris-wilson.co.uk
Diffstat (limited to 'drivers/gpu/drm/i915/intel_display.c')
-rw-r--r-- | drivers/gpu/drm/i915/intel_display.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index fc0794de595b..1be0c02f5b4d 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c | |||
@@ -1820,7 +1820,9 @@ void vlv_wait_port_ready(struct drm_i915_private *dev_priv, | |||
1820 | BUG(); | 1820 | BUG(); |
1821 | } | 1821 | } |
1822 | 1822 | ||
1823 | if (wait_for((I915_READ(dpll_reg) & port_mask) == expected_mask, 1000)) | 1823 | if (intel_wait_for_register(dev_priv, |
1824 | dpll_reg, port_mask, expected_mask, | ||
1825 | 1000)) | ||
1824 | WARN(1, "timed out waiting for port %c ready: got 0x%x, expected 0x%x\n", | 1826 | WARN(1, "timed out waiting for port %c ready: got 0x%x, expected 0x%x\n", |
1825 | port_name(dport->port), I915_READ(dpll_reg) & port_mask, expected_mask); | 1827 | port_name(dport->port), I915_READ(dpll_reg) & port_mask, expected_mask); |
1826 | } | 1828 | } |